From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Leo <sunpeng.li@amd.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_color: Add 10bpc frame buffer parameterization to subtests
Date: Thu, 12 Dec 2019 23:13:26 +0200 [thread overview]
Message-ID: <20191212211326.GU1208@intel.com> (raw)
In-Reply-To: <cd5191d3-a041-5d7e-ba3a-69fb11aafa30@amd.com>
On Thu, Dec 12, 2019 at 03:53:34PM -0500, Leo wrote:
>
>
> On 2019-12-12 10:03 a.m., Ville Syrjälä wrote:
> > On Wed, Dec 11, 2019 at 03:46:36PM -0500, sunpeng.li@amd.com wrote:
> >> From: Leo Li <sunpeng.li@amd.com>
> >>
> >> We'd like to test the hardware pipe's color management with 10bit
> >> surfaces.
> >
> > Why exactly? The pipe color management stuff doesn't care what
> > pixel format the plane used.
> >
>
> We expose 10bpc support to usermode with color management, so it'd be
> good to cover it with a test.
>
> With amdpgu, color management indeed doesn't care about surface format,
> since it's all converted to fixed point in hardware beforehand.
Totally missed this came from AMD folks. Good thing I was still
correct with my statement then :)
> But I
> think it's best to not assume hardware behavior, and test the actual
> use case instead.
I think what we would really want is a test that makes sure we can
achieve the desired precision in the output for some fb depth and
gamma configuration (sadly the gamma uapi doesn't let us do that
ATM in a hardware agnostic way). I don't think this test currently
checks anything like that. But maybe I'm misremebering what it
actually does.
--
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-12-12 21:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 20:46 [igt-dev] [PATCH i-g-t] tests/kms_color: Add 10bpc frame buffer parameterization to subtests sunpeng.li
2019-12-11 20:54 ` Kazlauskas, Nicholas
2019-12-11 21:15 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2019-12-12 8:12 ` [igt-dev] ✗ GitLab.Pipeline: " Patchwork
2019-12-12 15:03 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
2019-12-12 20:53 ` Leo
2019-12-12 21:13 ` Ville Syrjälä [this message]
2019-12-17 14:00 ` Leo
2020-01-02 22:59 ` Harry Wentland
2020-01-02 23:03 ` Harry Wentland
2020-01-08 14:44 ` Leo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212211326.GU1208@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.