From: Adrian Bunk <bunk@stusta.de>
To: Khem Raj <raj.khem@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH] xterm: Fix latent issue found with musl
Date: Fri, 13 Dec 2019 06:37:16 +0200 [thread overview]
Message-ID: <20191213043716.GA30893@localhost> (raw)
In-Reply-To: <20191212202252.2786262-3-raj.khem@gmail.com>
On Thu, Dec 12, 2019 at 12:22:52PM -0800, Khem Raj wrote:
>...
> +Upstream-Status: Pending
Not upstreamed OE-only musl patches create a technical debt.
>...
> +there is no test to define HAVE_GRANTPT_PTY_ISATTY
Is the definition in xterm_io.h not working?
>...
> +_POSIX_SOURCE is app-defined not system
This is true for musl, not for glibc.
The handling of _POSIX_SOURCE and _POSIX_VERSION differs between musl
and glibc due to glibc supporting older POSIX versions, and glibc also
supporting developers of portable code to select some specific older
POSIX version.
>...
> +-#if defined(_POSIX_SOURCE) || defined(SVR4) || defined(__convex__) || defined(__SCO__) || defined(__QNX__)
> ++#if defined(_POSIX_VERSION) || defined(SVR4) || defined(__convex__) || defined(__SCO__) || defined(__QNX__)
> + int pgrp = setsid(); /* variable may not be used... */
> + #else
> + int pgrp = getpid();
>...
So this was caused by musl not supporting older versions of POSIX,
where _POSIX_SOURCE was part of the standard.
The proper fix would be an autoconf test for setsid().
cu
Adrian
next prev parent reply other threads:[~2019-12-13 4:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 20:22 [meta-oe][PATCH] hdf5: Upgrade to 1.8.21 Khem Raj
2019-12-12 20:22 ` [meta-networking][PATCH] libnftnl: upgrade 1.1.4 -> 1.1.5 Khem Raj
2019-12-12 20:22 ` [meta-oe][PATCH] xterm: Fix latent issue found with musl Khem Raj
2019-12-13 4:37 ` Adrian Bunk [this message]
2019-12-13 21:55 ` Khem Raj
2019-12-13 22:58 ` Adrian Bunk
2019-12-14 5:55 ` Khem Raj
2019-12-14 14:20 ` Adrian Bunk
2019-12-14 15:24 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213043716.GA30893@localhost \
--to=bunk@stusta.de \
--cc=openembedded-devel@lists.openembedded.org \
--cc=raj.khem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.