From: Brian Gianforcaro <b.gianfo@gmail.com>
To: io-uring@vger.kernel.org
Subject: [PATCH] io_uring: Fix stale comment and a few typos.
Date: Fri, 13 Dec 2019 03:09:50 -0800 [thread overview]
Message-ID: <20191213110950.124702-1-b.gianfo@gmail.com> (raw)
- Fix a few typos found while reading the code.
- Fix stale io_get_sqring comment referencing s->sqe,
the 's' parameter was renamed to 'req', but the
comment still holds.
Signed-off-by: Brian Gianforcaro <b.gianfo@gmail.com>
---
fs/io-wq.c | 2 +-
fs/io_uring.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/io-wq.c b/fs/io-wq.c
index 74b40506c5d9..e6b2cd5a709c 100644
--- a/fs/io-wq.c
+++ b/fs/io-wq.c
@@ -934,7 +934,7 @@ static enum io_wq_cancel io_wqe_cancel_work(struct io_wqe *wqe,
/*
* Now check if a free (going busy) or busy worker has the work
* currently running. If we find it there, we'll return CANCEL_RUNNING
- * as an indication that we attempte to signal cancellation. The
+ * as an indication that we attempt to signal cancellation. The
* completion will run normally in this case.
*/
rcu_read_lock();
diff --git a/fs/io_uring.c b/fs/io_uring.c
index 405be10da73d..0896f495665b 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -1175,7 +1175,7 @@ static int io_do_iopoll(struct io_ring_ctx *ctx, unsigned int *nr_events,
}
/*
- * Poll for a mininum of 'min' events. Note that if min == 0 we consider that a
+ * Poll for a minimum of 'min' events. Note that if min == 0 we consider that a
* non-spinning poll check - we'll still enter the driver poll loop, but only
* as a non-spinning completion check.
*/
@@ -2567,7 +2567,7 @@ static enum hrtimer_restart io_timeout_fn(struct hrtimer *timer)
/*
* Adjust the reqs sequence before the current one because it
- * will consume a slot in the cq_ring and the the cq_tail
+ * will consume a slot in the cq_ring and the cq_tail
* pointer will be increased, otherwise other timeout reqs may
* return in advance without waiting for enough wait_nr.
*/
@@ -3414,7 +3414,7 @@ static void io_commit_sqring(struct io_ring_ctx *ctx)
}
/*
- * Fetch an sqe, if one is available. Note that s->sqe will point to memory
+ * Fetch an sqe, if one is available. Note that req->sqe will point to memory
* that is mapped by userspace. This means that care needs to be taken to
* ensure that reads are stable, as we cannot rely on userspace always
* being a good citizen. If members of the sqe are validated and then later
@@ -3676,7 +3676,7 @@ static inline bool io_should_wake(struct io_wait_queue *iowq, bool noflush)
struct io_ring_ctx *ctx = iowq->ctx;
/*
- * Wake up if we have enough events, or if a timeout occured since we
+ * Wake up if we have enough events, or if a timeout occurred since we
* started waiting. For timeouts, we always want to return to userspace,
* regardless of event count.
*/
base-commit: 37d4e84f765bb3038ddfeebdc5d1cfd7e1ef688f
--
2.24.0
next reply other threads:[~2019-12-13 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 11:09 Brian Gianforcaro [this message]
2019-12-14 18:44 ` [PATCH] io_uring: Fix stale comment and a few typos Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213110950.124702-1-b.gianfo@gmail.com \
--to=b.gianfo@gmail.com \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.