All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	dri-devel@lists.freedesktop.org,
	Steven Price <steven.price@arm.com>,
	kernel@collabora.com, Robin Murphy <robin.murphy@arm.com>
Subject: Re: [PATCH] drm/panfrost: Prefix interrupt handlers' names
Date: Fri, 13 Dec 2019 10:51:45 -0500	[thread overview]
Message-ID: <20191213155145.GC3042@kevin> (raw)
In-Reply-To: <ea53ddf32af4e2c9c7f5c1e1a13b85afbffce150.camel@collabora.com>


[-- Attachment #1.1: Type: text/plain, Size: 838 bytes --]

> (Feedback for kernel patches on the same day, am I dreaming??)

That's panfrost!

> > Agreed, while the current implementation may be confusing it is at least 
> > self-consistent. TBH it would probably be sufficient to save the bother 
> > of allocating strings and just settle on "panfrost-{gpu,job,mmu}", since 
> > upstream users are unlikely to ever come across a system with more than 
> > one Mali in it ;)
> > 
> > And FWIW note that "GPU" really is the specific hardware name of that 
> > IRQ output; it's not just a generic fill-in for "the one that isn't the 
> > Job or MMU IRQ".
> > 
> 
> Yeah, that makese sense. So how about we go for "panfrost-{job,mmu}"
> and leave the "gpu" one?
> 
> Or "panfrost-{gpu,job,mmu}" for consistency?

I would prefer "panfrost-{gpu,job,mmu}" for consistency, I think.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      reply	other threads:[~2019-12-14 14:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-13 12:39 [PATCH] drm/panfrost: Prefix interrupt handlers' names Ezequiel Garcia
2019-12-13 13:18 ` Neil Armstrong
2019-12-13 13:46   ` Robin Murphy
2019-12-13 14:32     ` Alyssa Rosenzweig
2019-12-13 15:31       ` Robin Murphy
2019-12-13 15:49         ` Alyssa Rosenzweig
2019-12-13 15:46     ` Ezequiel Garcia
2019-12-13 15:51       ` Alyssa Rosenzweig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191213155145.GC3042@kevin \
    --to=alyssa.rosenzweig@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ezequiel@collabora.com \
    --cc=kernel@collabora.com \
    --cc=narmstrong@baylibre.com \
    --cc=robin.murphy@arm.com \
    --cc=steven.price@arm.com \
    --cc=tomeu.vizoso@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.