From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C59DC3496A for ; Fri, 13 Dec 2019 20:39:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7A3E22470A for ; Fri, 13 Dec 2019 20:39:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728092AbfLMQSr (ORCPT ); Fri, 13 Dec 2019 11:18:47 -0500 Received: from sauhun.de ([88.99.104.3]:47994 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728096AbfLMQSq (ORCPT ); Fri, 13 Dec 2019 11:18:46 -0500 Received: from localhost (p54B3318D.dip0.t-ipconnect.de [84.179.49.141]) by pokefinder.org (Postfix) with ESMTPSA id CB5522C04D3; Fri, 13 Dec 2019 17:18:44 +0100 (CET) Date: Fri, 13 Dec 2019 17:18:41 +0100 From: Wolfram Sang To: Geert Uytterhoeven Cc: Wolfram Sang , Linux MMC List , Linux-Renesas , Yoshihiro Shimoda , Takeshi Saito Subject: Re: [RFC PATCH 1/2] mmc: renesas_sdhi: Add manual correction Message-ID: <20191213161841.GA1208@ninjato> References: <20191203203301.2202-1-wsa+renesas@sang-engineering.com> <20191203203301.2202-2-wsa+renesas@sang-engineering.com> <20191210222844.GD8683@kunai> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GvXjxJ+pjyke8COw" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org --GvXjxJ+pjyke8COw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Geert, > > > BTW, why is tap_set unsigned long instead of unsigned int? > > > > Because we use bitmap functions on it, and those have all unsigned long > > as arguments. >=20 > Do we? I only see bitops on host->taps? Point taken on this one... >=20 > > > And perhaps it should be moved from host to priv? > > > > That would be great, but other tap_* variables are still used in > > tmio_mmc_core.c. We maybe can refactor all tap handling into > > renesas_sdhi_core.c meanwhile, but this is a seperate issue. >=20 > tap_num is shared by the Renesas and TMIO code. > tap_set is Renesas-specific. =2E.. here however, I think we should keep all tap_* related variables close together. The driver is messy enough as is. Investigation if all of that code could be moved to renesas_sdhi_core, though, seems very useful. Thanks for the comments! Wolfram --GvXjxJ+pjyke8COw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl3zud4ACgkQFA3kzBSg KbbVbw/+P7nyvi+BkOHUztBGJxNsQNmcbTahuYyAAuF3MJAeFc1SPEDdwNcxmLww owyJRFWrlCuEpG4RqugMpEOvPaW7C5ueNSp6ShKe6Mu0HrZAlXBiVDoWPKkhSKNr aM2MGQ9wEpl6PyqcQrYAaneXhNm1cf/WBPzsK9YJR4JHApjSl9Tpy1t0BuLMqVnV jLpwybRn/Hys+Mhv7FCzE/KXlHxAo88Qamme3maQ3MWLd/nsD4xgtULNu4p1D0aQ WvKD9sPDoyC2DWZZ1NmsDn7qMUzqROBxr0Gif5gxi1ETJCAYZwVODsUtf9N/vTdM CYuUmw0RmadFcfCvMyk0Qru7x2fKFRBsRdqsFevmpJ1ZvZTxsB4Sl65vUEPeySYM AG5GU5dJNnEumduHFMO28RfTyX2l412AIMj8Hu9LO71DWVEspSzPI9dTo0/XBd5J T6HPHUIl+rVReeg+yKBvr3twBO0dUr+BdL/HtkqCBjlWKcF7lnfTqVQbxesszrWa /1/l/L78ggMM/j4wSRstJvBAVGiK7PAgTaH1L2mxUMvhjRYCZVpF+hbvIwkoZ0kn 0BPmxaIYM2g7yAT0V3APCNUB9bmmrZrQf+has5zFf9kIP0JIQG3CsvDJUo6c7Kpg qfKaYBZxzJouPxtKtoy9dK8ZKwpuoIu4YlSOtgfnAcJiYYqjiX4= =/t5q -----END PGP SIGNATURE----- --GvXjxJ+pjyke8COw--