From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Vandita Kulkarni <vandita.kulkarni@intel.com>
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix WARN_ON condition for cursor plane ddb allocation
Date: Fri, 13 Dec 2019 19:03:20 +0200 [thread overview]
Message-ID: <20191213170320.GA1208@intel.com> (raw)
In-Reply-To: <20191213154515.12121-1-vandita.kulkarni@intel.com>
On Fri, Dec 13, 2019 at 09:15:15PM +0530, Vandita Kulkarni wrote:
> In some cases min_ddb_alloc can be U16_MAX, exclude it
> from the WARN_ON.
The two cases I think are:
latency[level]==0 or wm[level].res_lines>31
You said you hit the latter case.
May want to mention those in the commit message.
>
> Fixes: 10a7e07b68b9 ("drm/i915: Make sure cursor has enough ddb for the selected wm level")
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
> ---
> drivers/gpu/drm/i915/intel_pm.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index ccbbdf4a6aab..cec4fa79422c 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -4312,8 +4312,10 @@ skl_allocate_pipe_ddb(struct intel_crtc_state *crtc_state,
> &crtc_state->wm.skl.optimal.planes[plane_id];
>
> if (plane_id == PLANE_CURSOR) {
> - if (WARN_ON(wm->wm[level].min_ddb_alloc >
> - total[PLANE_CURSOR])) {
> + if (wm->wm[level].min_ddb_alloc >
> + total[PLANE_CURSOR]) {
> + WARN_ON(wm->wm[level].min_ddb_alloc !=
> + U16_MAX);
> blocks = U32_MAX;
The line wraps make this look rather ugly. Might be better to just
ignore the 80col limit here.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> break;
> }
> --
> 2.21.0.5.gaeb582a
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-13 20:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 15:45 [Intel-gfx] [PATCH] drm/i915: Fix WARN_ON condition for cursor plane ddb allocation Vandita Kulkarni
2019-12-13 17:03 ` Ville Syrjälä [this message]
2019-12-13 22:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2019-12-14 20:14 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2019-12-16 8:06 [Intel-gfx] [PATCH] " Vandita Kulkarni
2019-12-16 21:23 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213170320.GA1208@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=vandita.kulkarni@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.