From: Sean Paul <sean@poorly.run>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: David Airlie <airlied@linux.ie>, Sean Paul <sean@poorly.run>,
dri-devel@lists.freedesktop.org, Ingo Molnar <mingo@redhat.com>,
Sean Paul <seanpaul@chromium.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH v3] drm: Funnel drm logs to tracepoints
Date: Fri, 13 Dec 2019 13:49:25 -0500 [thread overview]
Message-ID: <20191213184925.GD41609@art_vandelay> (raw)
In-Reply-To: <20191213115436.4e14a8ae@gandalf.local.home>
On Fri, Dec 13, 2019 at 11:54:36AM -0500, Steven Rostedt wrote:
> On Fri, 13 Dec 2019 11:47:03 -0500
> Sean Paul <sean@poorly.run> wrote:
>
> > > Why is there a separate trace event for each of these?
> > >
> >
> > To make it easier on userspace to enable just a single drm category.
> >
>
> But trace events can easily be filtered. Say you have a field called
> category, you could then just set in the trace event filter:
>
> echo 'category == 1 || category == 5 || (category > 8 && category < 12)' > /sys/kernel/tracing/drm_print/drm_category_log/filter
> echo 1 > /sys/kernel/tracing/drm_print/drm_category_log/enable
Hmm, true. I suppose the only downside would be that this would cause all logs
to be processed/assigned as trace events before the filter is applied. That's a
lot of extra work each frame.
Sean
>
> -- Steve
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-12-13 20:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 20:32 [PATCH v3] drm: Funnel drm logs to tracepoints Sean Paul
2019-12-13 3:20 ` Steven Rostedt
2019-12-13 16:47 ` Sean Paul
2019-12-13 16:54 ` Steven Rostedt
2019-12-13 18:49 ` Sean Paul [this message]
2019-12-13 11:34 ` Pekka Paalanen
2019-12-13 14:55 ` Steven Rostedt
2019-12-13 16:54 ` Sean Paul
2019-12-16 8:55 ` Pekka Paalanen
2019-12-13 15:34 ` Jani Nikula
2019-12-13 15:48 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213184925.GD41609@art_vandelay \
--to=sean@poorly.run \
--cc=airlied@linux.ie \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=seanpaul@chromium.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.