All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mackerras <paulus@ozlabs.org>
To: Eric Huber via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Eric Huber <echuber2@illinois.edu>
Subject: Re: [PATCH 1/1] gitk: Preserve window dimensions on exit when not using ttk themes
Date: Sun, 15 Dec 2019 16:33:04 +1100	[thread overview]
Message-ID: <20191215053304.GF12512@blackberry> (raw)
In-Reply-To: <364976a833e33696e983bbdd9c1e7974480c1397.1571098396.git.gitgitgadget@gmail.com>

On Tue, Oct 15, 2019 at 12:13:16AM +0000, Eric Huber via GitGitGadget wrote:
> From: Eric Huber <echuber2@illinois.edu>
> 
> Bug was: gitk would overwrite the botwidth setting in .gitk with
> a nonsense value when not using tk themes. I'm not sure if this
> is the right fix or not but it seems to work. Moving the affected
> line within the conditional results in the expected behavior.
> 
> Signed-off-by: Eric Huber <echuber2@illinois.edu>

Thanks, patch applied.

Paul.

      reply	other threads:[~2019-12-15  5:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15  0:13 [PATCH 0/1] gitk: Preserve window dimensions on exit when not using ttk themes Eric Huber via GitGitGadget
2019-10-15  0:13 ` [PATCH 1/1] " Eric Huber via GitGitGadget
2019-12-15  5:33   ` Paul Mackerras [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191215053304.GF12512@blackberry \
    --to=paulus@ozlabs.org \
    --cc=echuber2@illinois.edu \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.