From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B4FBC43603 for ; Sun, 15 Dec 2019 09:40:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 325692253D for ; Sun, 15 Dec 2019 09:40:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726052AbfLOJkW (ORCPT ); Sun, 15 Dec 2019 04:40:22 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:56888 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726050AbfLOJkW (ORCPT ); Sun, 15 Dec 2019 04:40:22 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 8A4612006F; Sun, 15 Dec 2019 10:40:19 +0100 (CET) Date: Sun, 15 Dec 2019 10:40:18 +0100 From: Sam Ravnborg To: Heiko Stuebner Cc: thierry.reding@gmail.com, mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, christoph.muellner@theobroma-systems.com Subject: Re: [PATCH 3/3] drm/panel: add panel driver for Xinpeng XPP055C272 panels Message-ID: <20191215094018.GA27552@ravnborg.org> References: <20191209144208.4863-1-heiko@sntech.de> <2272108.TFxdGdtKl4@diego> <20191215082916.GA25772@ravnborg.org> <1744285.zQlJhejOUX@phil> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1744285.zQlJhejOUX@phil> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=cWZPjuQPZkZKr6VumlEA:9 a=CjuIK1q_8ugA:10 a=pHzHmUro8NiASowvMSCR:22 a=6VlIyEUom7LUIeUMNQJH:22 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Heiko. > > The idea was that if a write returned an error then do not even attempt > > more writes. So if a write fails we do not loose the original error > > code, assuming subsequent write would also fail. > > Shouldn't the code above do exactly that? ... Because it's like > > ret = dcs_write(...) > if (ret <0) > return ret; > > So if any of the dcs_writes goes wrong it should just return the > error code from that write from the function and not try any more > writes. (or I'm blind and do not see something ;-) ) You are right, the code does it already. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC30BC2D0C8 for ; Sun, 15 Dec 2019 09:40:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ABE5F2072B for ; Sun, 15 Dec 2019 09:40:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ABE5F2072B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1F59C6E092; Sun, 15 Dec 2019 09:40:23 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id C0D916E092 for ; Sun, 15 Dec 2019 09:40:21 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 8A4612006F; Sun, 15 Dec 2019 10:40:19 +0100 (CET) Date: Sun, 15 Dec 2019 10:40:18 +0100 From: Sam Ravnborg To: Heiko Stuebner Subject: Re: [PATCH 3/3] drm/panel: add panel driver for Xinpeng XPP055C272 panels Message-ID: <20191215094018.GA27552@ravnborg.org> References: <20191209144208.4863-1-heiko@sntech.de> <2272108.TFxdGdtKl4@diego> <20191215082916.GA25772@ravnborg.org> <1744285.zQlJhejOUX@phil> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1744285.zQlJhejOUX@phil> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=cWZPjuQPZkZKr6VumlEA:9 a=CjuIK1q_8ugA:10 a=pHzHmUro8NiASowvMSCR:22 a=6VlIyEUom7LUIeUMNQJH:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, thierry.reding@gmail.com, christoph.muellner@theobroma-systems.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Heiko. > > The idea was that if a write returned an error then do not even attempt > > more writes. So if a write fails we do not loose the original error > > code, assuming subsequent write would also fail. > > Shouldn't the code above do exactly that? ... Because it's like > > ret = dcs_write(...) > if (ret <0) > return ret; > > So if any of the dcs_writes goes wrong it should just return the > error code from that write from the function and not try any more > writes. (or I'm blind and do not see something ;-) ) You are right, the code does it already. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel