* [PATCH] cpuidle: clps711x: convert to devm_platform_ioremap_resource
@ 2019-12-15 13:02 ` Yangtao Li
0 siblings, 0 replies; 18+ messages in thread
From: Yangtao Li @ 2019-12-15 13:02 UTC (permalink / raw)
To: rjw, daniel.lezcano, shc_work
Cc: Yangtao Li, linux-kernel, linux-arm-kernel, linux-pm
Use devm_platform_ioremap_resource() to simplify code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/cpuidle/cpuidle-clps711x.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/cpuidle/cpuidle-clps711x.c b/drivers/cpuidle/cpuidle-clps711x.c
index 6e36740f5719..fc22c59b6c73 100644
--- a/drivers/cpuidle/cpuidle-clps711x.c
+++ b/drivers/cpuidle/cpuidle-clps711x.c
@@ -37,10 +37,7 @@ static struct cpuidle_driver clps711x_idle_driver = {
static int __init clps711x_cpuidle_probe(struct platform_device *pdev)
{
- struct resource *res;
-
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- clps711x_halt = devm_ioremap_resource(&pdev->dev, res);
+ clps711x_halt = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(clps711x_halt))
return PTR_ERR(clps711x_halt);
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource
2019-12-15 13:02 ` Yangtao Li
@ 2019-12-15 13:02 ` Yangtao Li
-1 siblings, 0 replies; 18+ messages in thread
From: Yangtao Li @ 2019-12-15 13:02 UTC (permalink / raw)
To: rjw, daniel.lezcano, shc_work
Cc: linux-pm, linux-arm-kernel, linux-kernel, Yangtao Li
Use devm_platform_ioremap_resource() to simplify code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/cpuidle/cpuidle-kirkwood.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c
index d23d8f468c12..511c4f46027a 100644
--- a/drivers/cpuidle/cpuidle-kirkwood.c
+++ b/drivers/cpuidle/cpuidle-kirkwood.c
@@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = {
/* Initialize CPU idle by registering the idle states */
static int kirkwood_cpuidle_probe(struct platform_device *pdev)
{
- struct resource *res;
-
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- ddr_operation_base = devm_ioremap_resource(&pdev->dev, res);
+ ddr_operation_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(ddr_operation_base))
return PTR_ERR(ddr_operation_base);
--
2.17.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource
@ 2019-12-15 13:02 ` Yangtao Li
0 siblings, 0 replies; 18+ messages in thread
From: Yangtao Li @ 2019-12-15 13:02 UTC (permalink / raw)
To: rjw, daniel.lezcano, shc_work
Cc: Yangtao Li, linux-kernel, linux-arm-kernel, linux-pm
Use devm_platform_ioremap_resource() to simplify code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/cpuidle/cpuidle-kirkwood.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c
index d23d8f468c12..511c4f46027a 100644
--- a/drivers/cpuidle/cpuidle-kirkwood.c
+++ b/drivers/cpuidle/cpuidle-kirkwood.c
@@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = {
/* Initialize CPU idle by registering the idle states */
static int kirkwood_cpuidle_probe(struct platform_device *pdev)
{
- struct resource *res;
-
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- ddr_operation_base = devm_ioremap_resource(&pdev->dev, res);
+ ddr_operation_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(ddr_operation_base))
return PTR_ERR(ddr_operation_base);
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource
2019-12-15 13:02 ` Yangtao Li
@ 2019-12-15 15:01 ` Andrew Lunn
-1 siblings, 0 replies; 18+ messages in thread
From: Andrew Lunn @ 2019-12-15 15:01 UTC (permalink / raw)
To: Yangtao Li
Cc: rjw, daniel.lezcano, shc_work, linux-kernel, linux-arm-kernel,
linux-pm
On Sun, Dec 15, 2019 at 01:02:06PM +0000, Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource
2019-12-15 13:02 ` Yangtao Li
@ 2019-12-16 11:21 ` Rafael J. Wysocki
-1 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2019-12-16 11:21 UTC (permalink / raw)
To: Yangtao Li
Cc: daniel.lezcano, shc_work, linux-pm, linux-arm-kernel,
linux-kernel
On Sunday, December 15, 2019 2:02:06 PM CET Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/cpuidle/cpuidle-kirkwood.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c
> index d23d8f468c12..511c4f46027a 100644
> --- a/drivers/cpuidle/cpuidle-kirkwood.c
> +++ b/drivers/cpuidle/cpuidle-kirkwood.c
> @@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = {
> /* Initialize CPU idle by registering the idle states */
> static int kirkwood_cpuidle_probe(struct platform_device *pdev)
> {
> - struct resource *res;
> -
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ddr_operation_base = devm_ioremap_resource(&pdev->dev, res);
> + ddr_operation_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(ddr_operation_base))
> return PTR_ERR(ddr_operation_base);
>
>
Daniel, any concerns here?
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource
@ 2019-12-16 11:21 ` Rafael J. Wysocki
0 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2019-12-16 11:21 UTC (permalink / raw)
To: Yangtao Li
Cc: linux-kernel, daniel.lezcano, linux-arm-kernel, shc_work,
linux-pm
On Sunday, December 15, 2019 2:02:06 PM CET Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/cpuidle/cpuidle-kirkwood.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c
> index d23d8f468c12..511c4f46027a 100644
> --- a/drivers/cpuidle/cpuidle-kirkwood.c
> +++ b/drivers/cpuidle/cpuidle-kirkwood.c
> @@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = {
> /* Initialize CPU idle by registering the idle states */
> static int kirkwood_cpuidle_probe(struct platform_device *pdev)
> {
> - struct resource *res;
> -
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ddr_operation_base = devm_ioremap_resource(&pdev->dev, res);
> + ddr_operation_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(ddr_operation_base))
> return PTR_ERR(ddr_operation_base);
>
>
Daniel, any concerns here?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource
2019-12-16 11:21 ` Rafael J. Wysocki
@ 2019-12-16 15:45 ` Daniel Lezcano
-1 siblings, 0 replies; 18+ messages in thread
From: Daniel Lezcano @ 2019-12-16 15:45 UTC (permalink / raw)
To: Rafael J. Wysocki, Yangtao Li
Cc: shc_work, linux-pm, linux-arm-kernel, linux-kernel
On 16/12/2019 12:21, Rafael J. Wysocki wrote:
> On Sunday, December 15, 2019 2:02:06 PM CET Yangtao Li wrote:
>> Use devm_platform_ioremap_resource() to simplify code.
>>
>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>> ---
>> drivers/cpuidle/cpuidle-kirkwood.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c
>> index d23d8f468c12..511c4f46027a 100644
>> --- a/drivers/cpuidle/cpuidle-kirkwood.c
>> +++ b/drivers/cpuidle/cpuidle-kirkwood.c
>> @@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = {
>> /* Initialize CPU idle by registering the idle states */
>> static int kirkwood_cpuidle_probe(struct platform_device *pdev)
>> {
>> - struct resource *res;
>> -
>> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - ddr_operation_base = devm_ioremap_resource(&pdev->dev, res);
>> + ddr_operation_base = devm_platform_ioremap_resource(pdev, 0);
>> if (IS_ERR(ddr_operation_base))
>> return PTR_ERR(ddr_operation_base);
>>
>>
>
> Daniel, any concerns here?
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource
@ 2019-12-16 15:45 ` Daniel Lezcano
0 siblings, 0 replies; 18+ messages in thread
From: Daniel Lezcano @ 2019-12-16 15:45 UTC (permalink / raw)
To: Rafael J. Wysocki, Yangtao Li
Cc: linux-kernel, linux-arm-kernel, shc_work, linux-pm
On 16/12/2019 12:21, Rafael J. Wysocki wrote:
> On Sunday, December 15, 2019 2:02:06 PM CET Yangtao Li wrote:
>> Use devm_platform_ioremap_resource() to simplify code.
>>
>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>> ---
>> drivers/cpuidle/cpuidle-kirkwood.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c
>> index d23d8f468c12..511c4f46027a 100644
>> --- a/drivers/cpuidle/cpuidle-kirkwood.c
>> +++ b/drivers/cpuidle/cpuidle-kirkwood.c
>> @@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = {
>> /* Initialize CPU idle by registering the idle states */
>> static int kirkwood_cpuidle_probe(struct platform_device *pdev)
>> {
>> - struct resource *res;
>> -
>> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - ddr_operation_base = devm_ioremap_resource(&pdev->dev, res);
>> + ddr_operation_base = devm_platform_ioremap_resource(pdev, 0);
>> if (IS_ERR(ddr_operation_base))
>> return PTR_ERR(ddr_operation_base);
>>
>>
>
> Daniel, any concerns here?
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource
2019-12-15 13:02 ` Yangtao Li
@ 2019-12-20 9:16 ` Rafael J. Wysocki
-1 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2019-12-20 9:16 UTC (permalink / raw)
To: Yangtao Li
Cc: daniel.lezcano, shc_work, linux-pm, linux-arm-kernel,
linux-kernel
On Sunday, December 15, 2019 2:02:06 PM CET Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/cpuidle/cpuidle-kirkwood.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c
> index d23d8f468c12..511c4f46027a 100644
> --- a/drivers/cpuidle/cpuidle-kirkwood.c
> +++ b/drivers/cpuidle/cpuidle-kirkwood.c
> @@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = {
> /* Initialize CPU idle by registering the idle states */
> static int kirkwood_cpuidle_probe(struct platform_device *pdev)
> {
> - struct resource *res;
> -
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ddr_operation_base = devm_ioremap_resource(&pdev->dev, res);
> + ddr_operation_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(ddr_operation_base))
> return PTR_ERR(ddr_operation_base);
>
>
Applied as 5.6 material, thanks!
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 1/2] cpuidle: kirkwood: convert to devm_platform_ioremap_resource
@ 2019-12-20 9:16 ` Rafael J. Wysocki
0 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2019-12-20 9:16 UTC (permalink / raw)
To: Yangtao Li
Cc: linux-kernel, daniel.lezcano, linux-arm-kernel, shc_work,
linux-pm
On Sunday, December 15, 2019 2:02:06 PM CET Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/cpuidle/cpuidle-kirkwood.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-kirkwood.c b/drivers/cpuidle/cpuidle-kirkwood.c
> index d23d8f468c12..511c4f46027a 100644
> --- a/drivers/cpuidle/cpuidle-kirkwood.c
> +++ b/drivers/cpuidle/cpuidle-kirkwood.c
> @@ -55,10 +55,7 @@ static struct cpuidle_driver kirkwood_idle_driver = {
> /* Initialize CPU idle by registering the idle states */
> static int kirkwood_cpuidle_probe(struct platform_device *pdev)
> {
> - struct resource *res;
> -
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ddr_operation_base = devm_ioremap_resource(&pdev->dev, res);
> + ddr_operation_base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(ddr_operation_base))
> return PTR_ERR(ddr_operation_base);
>
>
Applied as 5.6 material, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] cpuidle: clps711x: convert to devm_platform_ioremap_resource
2019-12-15 13:02 ` Yangtao Li
@ 2019-12-16 11:20 ` Rafael J. Wysocki
-1 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2019-12-16 11:20 UTC (permalink / raw)
To: Yangtao Li, daniel.lezcano
Cc: shc_work, linux-pm, linux-arm-kernel, linux-kernel
On Sunday, December 15, 2019 2:02:05 PM CET Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/cpuidle/cpuidle-clps711x.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-clps711x.c b/drivers/cpuidle/cpuidle-clps711x.c
> index 6e36740f5719..fc22c59b6c73 100644
> --- a/drivers/cpuidle/cpuidle-clps711x.c
> +++ b/drivers/cpuidle/cpuidle-clps711x.c
> @@ -37,10 +37,7 @@ static struct cpuidle_driver clps711x_idle_driver = {
>
> static int __init clps711x_cpuidle_probe(struct platform_device *pdev)
> {
> - struct resource *res;
> -
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - clps711x_halt = devm_ioremap_resource(&pdev->dev, res);
> + clps711x_halt = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(clps711x_halt))
> return PTR_ERR(clps711x_halt);
>
>
Daniel, any concerns here?
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH] cpuidle: clps711x: convert to devm_platform_ioremap_resource
@ 2019-12-16 11:20 ` Rafael J. Wysocki
0 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2019-12-16 11:20 UTC (permalink / raw)
To: Yangtao Li, daniel.lezcano
Cc: linux-kernel, linux-arm-kernel, shc_work, linux-pm
On Sunday, December 15, 2019 2:02:05 PM CET Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/cpuidle/cpuidle-clps711x.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-clps711x.c b/drivers/cpuidle/cpuidle-clps711x.c
> index 6e36740f5719..fc22c59b6c73 100644
> --- a/drivers/cpuidle/cpuidle-clps711x.c
> +++ b/drivers/cpuidle/cpuidle-clps711x.c
> @@ -37,10 +37,7 @@ static struct cpuidle_driver clps711x_idle_driver = {
>
> static int __init clps711x_cpuidle_probe(struct platform_device *pdev)
> {
> - struct resource *res;
> -
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - clps711x_halt = devm_ioremap_resource(&pdev->dev, res);
> + clps711x_halt = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(clps711x_halt))
> return PTR_ERR(clps711x_halt);
>
>
Daniel, any concerns here?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH] cpuidle: clps711x: convert to devm_platform_ioremap_resource
2019-12-16 11:20 ` Rafael J. Wysocki
@ 2019-12-16 15:44 ` Daniel Lezcano
-1 siblings, 0 replies; 18+ messages in thread
From: Daniel Lezcano @ 2019-12-16 15:44 UTC (permalink / raw)
To: Rafael J. Wysocki, Yangtao Li
Cc: shc_work, linux-pm, linux-arm-kernel, linux-kernel
On 16/12/2019 12:20, Rafael J. Wysocki wrote:
> On Sunday, December 15, 2019 2:02:05 PM CET Yangtao Li wrote:
>> Use devm_platform_ioremap_resource() to simplify code.
>>
>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>> ---
>> drivers/cpuidle/cpuidle-clps711x.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/cpuidle/cpuidle-clps711x.c b/drivers/cpuidle/cpuidle-clps711x.c
>> index 6e36740f5719..fc22c59b6c73 100644
>> --- a/drivers/cpuidle/cpuidle-clps711x.c
>> +++ b/drivers/cpuidle/cpuidle-clps711x.c
>> @@ -37,10 +37,7 @@ static struct cpuidle_driver clps711x_idle_driver = {
>>
>> static int __init clps711x_cpuidle_probe(struct platform_device *pdev)
>> {
>> - struct resource *res;
>> -
>> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - clps711x_halt = devm_ioremap_resource(&pdev->dev, res);
>> + clps711x_halt = devm_platform_ioremap_resource(pdev, 0);
>> if (IS_ERR(clps711x_halt))
>> return PTR_ERR(clps711x_halt);
>>
>>
>
> Daniel, any concerns here?
I'm fine with those changes also. Maybe a bit more elaborated changelog,
but not sure it is worth to resend a new patch for that. May be you can
just update it with an answer and Rafael can take it into account.
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH] cpuidle: clps711x: convert to devm_platform_ioremap_resource
@ 2019-12-16 15:44 ` Daniel Lezcano
0 siblings, 0 replies; 18+ messages in thread
From: Daniel Lezcano @ 2019-12-16 15:44 UTC (permalink / raw)
To: Rafael J. Wysocki, Yangtao Li
Cc: linux-kernel, linux-arm-kernel, shc_work, linux-pm
On 16/12/2019 12:20, Rafael J. Wysocki wrote:
> On Sunday, December 15, 2019 2:02:05 PM CET Yangtao Li wrote:
>> Use devm_platform_ioremap_resource() to simplify code.
>>
>> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
>> ---
>> drivers/cpuidle/cpuidle-clps711x.c | 5 +----
>> 1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/cpuidle/cpuidle-clps711x.c b/drivers/cpuidle/cpuidle-clps711x.c
>> index 6e36740f5719..fc22c59b6c73 100644
>> --- a/drivers/cpuidle/cpuidle-clps711x.c
>> +++ b/drivers/cpuidle/cpuidle-clps711x.c
>> @@ -37,10 +37,7 @@ static struct cpuidle_driver clps711x_idle_driver = {
>>
>> static int __init clps711x_cpuidle_probe(struct platform_device *pdev)
>> {
>> - struct resource *res;
>> -
>> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - clps711x_halt = devm_ioremap_resource(&pdev->dev, res);
>> + clps711x_halt = devm_platform_ioremap_resource(pdev, 0);
>> if (IS_ERR(clps711x_halt))
>> return PTR_ERR(clps711x_halt);
>>
>>
>
> Daniel, any concerns here?
I'm fine with those changes also. Maybe a bit more elaborated changelog,
but not sure it is worth to resend a new patch for that. May be you can
just update it with an answer and Rafael can take it into account.
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] cpuidle: clps711x: convert to devm_platform_ioremap_resource
2019-12-15 13:02 ` Yangtao Li
@ 2019-12-20 9:17 ` Rafael J. Wysocki
-1 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2019-12-20 9:17 UTC (permalink / raw)
To: Yangtao Li
Cc: daniel.lezcano, shc_work, linux-pm, linux-arm-kernel,
linux-kernel
On Sunday, December 15, 2019 2:02:05 PM CET Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/cpuidle/cpuidle-clps711x.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-clps711x.c b/drivers/cpuidle/cpuidle-clps711x.c
> index 6e36740f5719..fc22c59b6c73 100644
> --- a/drivers/cpuidle/cpuidle-clps711x.c
> +++ b/drivers/cpuidle/cpuidle-clps711x.c
> @@ -37,10 +37,7 @@ static struct cpuidle_driver clps711x_idle_driver = {
>
> static int __init clps711x_cpuidle_probe(struct platform_device *pdev)
> {
> - struct resource *res;
> -
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - clps711x_halt = devm_ioremap_resource(&pdev->dev, res);
> + clps711x_halt = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(clps711x_halt))
> return PTR_ERR(clps711x_halt);
>
>
Applied as 5.6 material, thanks!
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH] cpuidle: clps711x: convert to devm_platform_ioremap_resource
@ 2019-12-20 9:17 ` Rafael J. Wysocki
0 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2019-12-20 9:17 UTC (permalink / raw)
To: Yangtao Li
Cc: linux-kernel, daniel.lezcano, linux-arm-kernel, shc_work,
linux-pm
On Sunday, December 15, 2019 2:02:05 PM CET Yangtao Li wrote:
> Use devm_platform_ioremap_resource() to simplify code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/cpuidle/cpuidle-clps711x.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/cpuidle/cpuidle-clps711x.c b/drivers/cpuidle/cpuidle-clps711x.c
> index 6e36740f5719..fc22c59b6c73 100644
> --- a/drivers/cpuidle/cpuidle-clps711x.c
> +++ b/drivers/cpuidle/cpuidle-clps711x.c
> @@ -37,10 +37,7 @@ static struct cpuidle_driver clps711x_idle_driver = {
>
> static int __init clps711x_cpuidle_probe(struct platform_device *pdev)
> {
> - struct resource *res;
> -
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - clps711x_halt = devm_ioremap_resource(&pdev->dev, res);
> + clps711x_halt = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(clps711x_halt))
> return PTR_ERR(clps711x_halt);
>
>
Applied as 5.6 material, thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 18+ messages in thread