All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: gregkh@linuxfoundation.org
Cc: natechancellor@gmail.com, mpe@ellerman.id.au,
	ndesaulniers@google.com, segher@kernel.crashing.org,
	stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] powerpc: Avoid clang warnings around setjmp and longjmp" failed to apply to 5.4-stable tree
Date: Sun, 15 Dec 2019 20:57:44 -0500	[thread overview]
Message-ID: <20191216015744.GA17708@sasha-vm> (raw)
In-Reply-To: <1576429888117116@kroah.com>

On Sun, Dec 15, 2019 at 06:11:28PM +0100, gregkh@linuxfoundation.org wrote:
>
>The patch below does not apply to the 5.4-stable tree.
>If someone wants it applied there, or to any other stable or longterm
>tree, then please email the backport, including the original git commit
>id to <stable@vger.kernel.org>.
>
>thanks,
>
>greg k-h
>
>------------------ original commit in Linus's tree ------------------
>
>From c9029ef9c95765e7b63c4d9aa780674447db1ec0 Mon Sep 17 00:00:00 2001
>From: Nathan Chancellor <natechancellor@gmail.com>
>Date: Mon, 18 Nov 2019 21:57:11 -0700
>Subject: [PATCH] powerpc: Avoid clang warnings around setjmp and longjmp
>
>Commit aea447141c7e ("powerpc: Disable -Wbuiltin-requires-header when
>setjmp is used") disabled -Wbuiltin-requires-header because of a
>warning about the setjmp and longjmp declarations.
>
>r367387 in clang added another diagnostic around this, complaining
>that there is no jmp_buf declaration.
>
>  In file included from ../arch/powerpc/xmon/xmon.c:47:
>  ../arch/powerpc/include/asm/setjmp.h:10:13: error: declaration of
>  built-in function 'setjmp' requires the declaration of the 'jmp_buf'
>  type, commonly provided in the header <setjmp.h>.
>  [-Werror,-Wincomplete-setjmp-declaration]
>  extern long setjmp(long *);
>              ^
>  ../arch/powerpc/include/asm/setjmp.h:11:13: error: declaration of
>  built-in function 'longjmp' requires the declaration of the 'jmp_buf'
>  type, commonly provided in the header <setjmp.h>.
>  [-Werror,-Wincomplete-setjmp-declaration]
>  extern void longjmp(long *, long);
>              ^
>  2 errors generated.
>
>We are not using the standard library's longjmp/setjmp implementations
>for obvious reasons; make this clear to clang by using -ffreestanding
>on these files.
>
>Cc: stable@vger.kernel.org # 4.14+
>Suggested-by: Segher Boessenkool <segher@kernel.crashing.org>
>Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
>Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>Link: https://lore.kernel.org/r/20191119045712.39633-3-natechancellor@gmail.com

Adjusted for code movement in 793b08e2efff ("powerpc/kexec: Move kexec
files into a dedicated subdir.") and queued for 5.4-4.14.

-- 
Thanks,
Sasha

      reply	other threads:[~2019-12-16  1:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-15 17:11 FAILED: patch "[PATCH] powerpc: Avoid clang warnings around setjmp and longjmp" failed to apply to 5.4-stable tree gregkh
2019-12-16  1:57 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191216015744.GA17708@sasha-vm \
    --to=sashal@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=mpe@ellerman.id.au \
    --cc=natechancellor@gmail.com \
    --cc=ndesaulniers@google.com \
    --cc=segher@kernel.crashing.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.