From: Leon Romanovsky <leon@kernel.org>
To: David Miller <davem@davemloft.net>
Cc: info@metux.net, linux-kernel@vger.kernel.org,
jchapman@katalix.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: l2tp: remove unneeded MODULE_VERSION() usage
Date: Mon, 16 Dec 2019 11:04:26 +0200 [thread overview]
Message-ID: <20191216090426.GA66555@unreal> (raw)
In-Reply-To: <20191212.110354.354662228217900367.davem@davemloft.net>
On Thu, Dec 12, 2019 at 11:03:54AM -0800, David Miller wrote:
> From: "Enrico Weigelt, metux IT consult" <info@metux.net>
> Date: Thu, 12 Dec 2019 14:36:13 +0100
>
> > Remove MODULE_VERSION(), as it isn't needed at all: the only version
> > making sense is the kernel version.
> >
> > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
>
> Is there a plan to remove MODULE_VERSION across the entire kernel tree?
>
> Where is that documented?
>
> Otherwise what gave you the reason to make this change in the first place?
Dave, see this conversation which I had two years ago with positive
responses from many respectable developers.
https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2017-June/004421.html
Greg's response:
https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2017-June/004441.html
Linus's response:
https://lists.linuxfoundation.org/pipermail/ksummit-discuss/2017-June/004426.html
Thanks
>
> No context, no high level explanation of what's going on, so it's hard
> to review and decide whether to accept your change sorry.
>
> At the least, you will have to write a more complete commit log message.
prev parent reply other threads:[~2019-12-16 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 13:36 [PATCH] net: l2tp: remove unneeded MODULE_VERSION() usage Enrico Weigelt, metux IT consult
2019-12-12 19:03 ` David Miller
2019-12-16 8:38 ` Enrico Weigelt, metux IT consult
2019-12-16 9:04 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216090426.GA66555@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=info@metux.net \
--cc=jchapman@katalix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.