All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/3] package/mariadb: bump version to 10.4.11
Date: Mon, 16 Dec 2019 09:33:59 +0100	[thread overview]
Message-ID: <20191216093359.7b3307eb@windsurf.home> (raw)
In-Reply-To: <20191215213326.10863-1-bluemrp9@gmail.com>

Hello Ryan,

Thanks for the update. A few questions below.

On Sun, 15 Dec 2019 13:33:24 -0800
Ryan Coe <bluemrp9@gmail.com> wrote:

> diff --git a/package/mariadb/S97mysqld b/package/mariadb/S97mysqld
> index 62357fa8c4..270eea51dd 100644
> --- a/package/mariadb/S97mysqld
> +++ b/package/mariadb/S97mysqld
> @@ -23,12 +23,13 @@ wait_for_ready() {
>  start() {
>  	if [ `ls -1 $MYSQL_LIB | wc -l` = 0 ] ; then
>  		printf "Creating mysql system tables ... "
> -		$MYSQL_BIN/mysql_install_db --basedir=/usr --user=mysql \
> +		$MYSQL_BIN/mysql_install_db --basedir=/usr \
>  			--datadir=$MYSQL_LIB > /dev/null 2>&1
>  		if [ $? != 0 ]; then
>  			echo "FAIL"
>  			exit 1
>  		fi
> +		chown -R mysql:mysql /var/lib/mysql

Is this change related to the version bump ?

> diff --git a/package/mariadb/mysqld.service b/package/mariadb/mysqld.service
> index cd308310c6..3eaef173e1 100644
> --- a/package/mariadb/mysqld.service
> +++ b/package/mariadb/mysqld.service
> @@ -2,7 +2,7 @@
>  Description=MySQL database server
>  
>  [Service]
> -ExecStartPre=/bin/sh -c 'test "`ls -1 /var/lib/mysql | wc -l`" != "0" || mysql_install_db --basedir=/usr --datadir=/var/lib/mysql'
> +ExecStartPre=/bin/sh -c 'test "`ls -1 /var/lib/mysql | wc -l`" != "0" || mysql_install_db --basedir=/usr --datadir=/var/lib/mysql && chown -R mysql:mysql /var/lib/mysql'

So before this, the database files were owned by root? How could have
the mysqld daemon, which runs as the mysql user, use them? Isn't this
change a bug fix, that is completely independent of the version bump,
and should come before the version bump, and even be backported to
stable versions of Buildroot ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2019-12-16  8:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-15 21:33 [Buildroot] [PATCH v2 1/3] package/mariadb: bump version to 10.4.11 Ryan Coe
2019-12-15 21:33 ` [Buildroot] [PATCH v2 2/3] package/mariadb: update startup scripts Ryan Coe
2019-12-16  8:35   ` Thomas Petazzoni
2019-12-17  0:03     ` Ryan Coe
2019-12-15 21:33 ` [Buildroot] [PATCH v2 3/3] package/mariadb: prefix sysroot in mariadb_config Ryan Coe
2019-12-17  0:38   ` Ryan Coe
2019-12-17  7:58     ` Thomas Petazzoni
2019-12-16  8:33 ` Thomas Petazzoni [this message]
2019-12-17  0:12   ` [Buildroot] [PATCH v2 1/3] package/mariadb: bump version to 10.4.11 Ryan Coe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191216093359.7b3307eb@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.