From: Johan Hovold <johan@kernel.org>
To: Daniele Palmas <dnlplm@gmail.com>
Cc: Johan Hovold <johan@kernel.org>, linux-usb <linux-usb@vger.kernel.org>
Subject: Re: [PATCH RESEND 1/1] usb: serial: option: add ZLP support for 0x1bc7/0x9010
Date: Mon, 16 Dec 2019 13:01:01 +0100 [thread overview]
Message-ID: <20191216120101.GC22665@localhost> (raw)
In-Reply-To: <CAGRyCJGt1dsiRRgEJ9Yj2YrVW2OGVQ-6zFOh4P75Dbq0+sH5eA@mail.gmail.com>
On Fri, Dec 06, 2019 at 04:56:52PM +0100, Daniele Palmas wrote:
> Il giorno ven 6 dic 2019 alle ore 16:43 Johan Hovold
> <johan@kernel.org> ha scritto:
> >
> > >
> > > > I wonder whether using option is the right thing to do here. We're just
> > > > currently throwing everything modem related in here it seems. :)
> > > >
> > >
> > > I understand your concern. At first, in fact, I tried to add support
> > > for this in usb-serial-simple, but the change seemed to me more
> > > impacting than the one I had to do for adding support in option.
> > >
> > > Let me know if you want me to continue investigating the
> > > usb-serial-simple way or you have another advice.
> >
> > Yeah, I was thinking along those lines as well. Let me get me get back
> > to you on that.
> >
>
> Ok, thanks, I'll wait for your thoughts on that before submitting V3
> for the current patch.
Sorry about the delay here.
I think adding this to option/usb_wwan makes sense (e.g. only one driver
needs to be enabled) so just move the flag handling to port_probe as we
discussed in v2.
Johan
prev parent reply other threads:[~2019-12-16 12:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 13:32 [PATCH RESEND 1/1] usb: serial: option: add ZLP support for 0x1bc7/0x9010 Daniele Palmas
2019-11-28 18:12 ` Daniele Palmas
2019-11-28 18:18 ` Johan Hovold
2019-12-05 14:57 ` Johan Hovold
2019-12-05 16:06 ` Daniele Palmas
2019-12-06 15:43 ` Johan Hovold
2019-12-06 15:56 ` Daniele Palmas
2019-12-16 12:01 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216120101.GC22665@localhost \
--to=johan@kernel.org \
--cc=dnlplm@gmail.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.