From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1igpd0-0003b0-9P for mharc-grub-devel@gnu.org; Mon, 16 Dec 2019 07:37:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:57293) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1igpcx-0003V3-18 for grub-devel@gnu.org; Mon, 16 Dec 2019 07:37:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1igpcv-0004va-VY for grub-devel@gnu.org; Mon, 16 Dec 2019 07:37:30 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:36473) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1igpcv-0004kA-DP for grub-devel@gnu.org; Mon, 16 Dec 2019 07:37:29 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id DED6873D; Mon, 16 Dec 2019 07:37:26 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 16 Dec 2019 07:37:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=iI6pv5trc6exwmZvZvd7LVHPeA6 1sGLw0M/y3JtaHiI=; b=xTfvBaWkxEib21dPH37xSQ5Nm5ID3Dzxm3fYLR7c8MK sfJl3kg6cUCHUAQkZ7iYdTVXudHkLBlmlgu9C+CiwivHflDbK4wqIfQyt3GYRWkf 9Kx7Y0H0oCUsG7CIfQpH3gJZ1Y7nQZ9sUJYustvgVDw4IuYvbEqTx+kNfU39lAkb e6BOJAkpR++wCdQa8nX2MXtLjcYqrhA6Z+SQkIQQGPgI9tENjaaWsNVPQqAaJWLi JIofOhKvf9hkAkjTl3sINgxPEtjHn9ctNXM9zGcFZM3+LJJXLczOU3lSi4C36Hc5 yNEw9Hssq0Yr3xmBES1QBqBQA202CcPud+3RmNmMlug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=iI6pv5 trc6exwmZvZvd7LVHPeA61sGLw0M/y3JtaHiI=; b=vKHG41vajxQvoxx8PnFJgG n7Ji1YeLrgehNLyG+/P+LOZtau6p1Q9ZUYLmJq3Q6GuOiHjMGH+/NToVwZFblUli +ug2Xmxucng48twbe9DaPUNCyCRKua2kgx+nh98gXKyN08OWXbb1/TBr3Yi7ZgFL ezT9ZBWEGHofFIcXrmsFs++nPc1YJhYBWThMZZCS9snkqrZrBrpcCUZAq5jCMhQr am9tACfrcZVNI7KVvVlSmieW+8i1yuka6CqDyK6rfwSG9li7Ref/UM8B/TBxwWCH l1CxrEuALb3ZWCAZaFOlHAIqZsPC98HWfTrVSNMd2uZzilAysu9rbVTMF7W9Wzsw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrvddthedggeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucfkphepjeejrdduke efrdegvddrvddvgeenucfrrghrrghmpehmrghilhhfrhhomhepphhssehpkhhsrdhimhen ucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from vm-mail (x4db72ae0.dyn.telefonica.de [77.183.42.224]) by mail.messagingengine.com (Postfix) with ESMTPA id 5D5608005A; Mon, 16 Dec 2019 07:37:25 -0500 (EST) Received: from localhost ( [10.192.0.11]) by vm-mail (OpenSMTPD) with ESMTPSA id 64265c68 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 16 Dec 2019 12:37:22 +0000 (UTC) Date: Mon, 16 Dec 2019 13:37:33 +0100 From: Patrick Steinhardt To: Daniel Kiper Cc: grub-devel@gnu.org, Max Tottenham Subject: Re: [PATCH v6 6/6] disk: Implement support for LUKS2 Message-ID: <20191216123733.GA5832@ncase> References: <20191216122501.kt4f2jzjk3h4r3la@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" Content-Disposition: inline In-Reply-To: <20191216122501.kt4f2jzjk3h4r3la@tomti.i.net-space.pl> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 64.147.123.21 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Dec 2019 12:37:32 -0000 --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 16, 2019 at 01:25:01PM +0100, Daniel Kiper wrote: > On Tue, Dec 10, 2019 at 10:26:21AM +0100, Patrick Steinhardt wrote: [snip] > > + /* Get the passphrase from the user. */ > > + if (disk->partition) > > + part =3D grub_partition_get_name (disk->partition); > > + grub_printf_ (N_("Enter passphrase for %s%s%s (%s): "), disk->name, > > + disk->partition ? "," : "", part ? : "", > > + crypt->uuid); >=20 > Why do you use grub_printf() instead of grub_printf()? I guess you mean grub_printf_() instead of grub_printf(). The answer to that is simple: I copied it from "luks.c", and I saw it being used in various other modules for output that is user-facing and should thus be translated. Is there are more modern alternative that should be used instead? If so then I'm happy to use it instead. Patrick --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEtmscHsieVjl9VyNUEXxntp6r8SwFAl33eosACgkQEXxntp6r 8Sxhjw/9Fs2zk3zDzDBPq57HtlUp0tsFo/R07d/Z5c0AsQQnxbc115RXCRnIMW88 MUPEwV/kw7JrApsKfJXVrH5vi4QvPEzzrULWPp1Cow4dat/qX4AbEirnaSJegoJy AJNm1MJwbjTpjbpr3OC9e4YKAdHSLUCDFA1OQvoynOOb8OQuMEW2JU5xlPtrRZHv P2/QyTC0teZM0dNUCALFM5l2A9F50PmenasZMWCJSuVIwFW6fwP2JGD25if/EQVA sJmM4I7QoUC4lE7kFUqk1VsjCFlxIVvI5ap6CWeZu5ayt3xi+sXzVoMHyPiF78zp sbZi4QmBKcrEAYzZ3Ez/dW9aigjZXam70sDthshngNJG40Jwn8IltaPkQKFpqdOP Rq8nC+Cs5G3pDFbyeKeR4yVUu+JcJQPlUIFZT1GPDrre+yuXaVVf9iv7P1d3A9cV ZHidfW+b2RIGdBFaBHB+Ad9uGyclU2aUjDHIQ/ZNOo+bv81Y4K8OWcYFlma8fO3u GhUU1aUTkOLVhS0lJ/NFmnSf1cuohaAwzrevia0xcr/Ist5NRczoZ4UV4AZywWvB PTYu6IVEIy55zV8mR2a7PbWjQhnaSHycC1x700DIfoecbjgogIUpOuGzMN5fs0mZ riKMLvSJvjMKO5KNNTj/uzWgoPPBChzptKsgOAXpxCp+1hZ7t4U= =hPba -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK--