From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF8D0C2D0C3 for ; Mon, 16 Dec 2019 12:47:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3A39206D3 for ; Mon, 16 Dec 2019 12:47:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727741AbfLPMrv (ORCPT ); Mon, 16 Dec 2019 07:47:51 -0500 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:49808 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727720AbfLPMrv (ORCPT ); Mon, 16 Dec 2019 07:47:51 -0500 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1igpmv-0004bK-JC; Mon, 16 Dec 2019 13:47:49 +0100 Date: Mon, 16 Dec 2019 13:47:49 +0100 From: Florian Westphal To: Pablo Neira Ayuso Cc: netfilter-devel@vger.kernel.org, fw@strlen.de Subject: Re: [PATCH nft 0/3] typeof incremental enhancements Message-ID: <20191216124749.GR795@breakpoint.cc> References: <20191216124222.356618-1-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191216124222.356618-1-pablo@netfilter.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Pablo Neira Ayuso wrote: > Hi Florian, > > This patchset removes the need to self invoke the parser and the > evaluation to fetch the datatype. Instead, the expression type and > the expression description are stored into the userdata area. > > This patch only supports for the payload expression, but it should be > relatively easy to extend it to support for other existing expressions > types. > > This patch could be squashed into 06/11 src: add "typeof" print support > of your patch series, which is actually not just adding support for > printing but also for building the userdata. I had considered that but found that storing netlink data needs more space in the udata area compared to text and it needs more/extra parsing for serialize/deserialize, so I abandoned this idea. If you think its the way to go, then ok, I can rework it but I will be unable to add the extra steps for other expression types for some time I fear.