All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Florian Westphal <fw@strlen.de>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft 0/3] typeof incremental enhancements
Date: Mon, 16 Dec 2019 15:03:36 +0100	[thread overview]
Message-ID: <20191216140336.GS795@breakpoint.cc> (raw)
In-Reply-To: <20191216130034.256a44juaeey7umf@salvia>

Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> The listing path should be easier, since it's just parsing the TLVs
> instead of invoking the nft parsing and evaluation phases.
> 
> > If you think its the way to go, then ok, I can rework it but
> > I will be unable to add the extra steps for other expression types
> > for some time I fear.
> 
> If you send a v3 including this work, I'll finishing the remaining
> expressions.

Ok, will respin.

> One more thing regarding your patchset is:
> 
>         integer,128
> 
> If the typeof works for all of the existing selectors, then I think
> there is not need to expose this raw type, right?

How would you handle the 'udate missing' case?

If its not a problem to display a non-restoreable ruleset
(e.g. unspecific 'type integer' shown as set keys) in that case
then the interger,width part can be omitted indeed.

Let me know.  For concatenations, we will be unable to show
a proper ruleset without the udata info anyway (concatentations
do not work at the moment for non-specific types anyway though).

  reply	other threads:[~2019-12-16 14:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16 12:42 [PATCH nft 0/3] typeof incremental enhancements Pablo Neira Ayuso
2019-12-16 12:42 ` [PATCH nft 1/3] proto: add proto_desc_id enumeration Pablo Neira Ayuso
2019-12-16 12:42 ` [PATCH nft 2/3] expr: add expr_ops_by_type() Pablo Neira Ayuso
2019-12-16 12:42 ` [PATCH nft 3/3] expr: add parse and build userdata interface Pablo Neira Ayuso
2019-12-16 12:47 ` [PATCH nft 0/3] typeof incremental enhancements Florian Westphal
2019-12-16 13:00   ` Pablo Neira Ayuso
2019-12-16 14:03     ` Florian Westphal [this message]
2019-12-16 15:01       ` Pablo Neira Ayuso
2019-12-16 15:48         ` Florian Westphal
2019-12-16 17:37           ` Pablo Neira Ayuso
2019-12-16 18:59             ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191216140336.GS795@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.