From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9B84C43603 for ; Tue, 17 Dec 2019 10:32:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C892D206B7 for ; Tue, 17 Dec 2019 10:32:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C892D206B7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2672C6E98C; Tue, 17 Dec 2019 10:32:00 +0000 (UTC) Received: from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net [217.70.183.198]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2BD646E560 for ; Mon, 16 Dec 2019 13:48:15 +0000 (UTC) X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 351A2C0003; Mon, 16 Dec 2019 13:48:11 +0000 (UTC) Date: Mon, 16 Dec 2019 14:48:10 +0100 From: Miquel Raynal To: Maxime Ripard Subject: Re: [PATCH] drm/panel: simple: Support reset GPIOs Message-ID: <20191216144810.18710ed3@xps13> In-Reply-To: <20191216132732.mmqivmpnq4mio6oo@gilmour.lan> References: <20191213181325.26228-1-miquel.raynal@bootlin.com> <20191216130615.qs6ub7bwqofwvhr7@gilmour.lan> <20191216141036.24c22899@xps13> <20191216132732.mmqivmpnq4mio6oo@gilmour.lan> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 17 Dec 2019 10:31:56 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Petazzoni , David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Maxime Chevallier , Paul Kocialkowski , Thierry Reding , Sam Ravnborg Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgU2FtLAoKTWF4aW1lIFJpcGFyZCA8bWF4aW1lQGNlcm5vLnRlY2g+IHdyb3RlIG9uIE1vbiwg MTYgRGVjIDIwMTkgMTQ6Mjc6MzIKKzAxMDA6Cgo+IE9uIE1vbiwgRGVjIDE2LCAyMDE5IGF0IDAy OjEwOjM2UE0gKzAxMDAsIE1pcXVlbCBSYXluYWwgd3JvdGU6Cj4gPiA+ID4gIGRyaXZlcnMvZ3B1 L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYyB8IDEyICsrKysrKysrKysrLQo+ID4gPiA+ICAxIGZp bGUgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQo+ID4gPiA+Cj4gPiA+ ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYyBiL2Ry aXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1zaW1wbGUuYwo+ID4gPiA+IGluZGV4IDVkNDg3Njg2 ZDI1Yy4uMTVkZDQ5NWMzNDdkIDEwMDY0NAo+ID4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9w YW5lbC9wYW5lbC1zaW1wbGUuYwo+ID4gPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9wYW5lbC9w YW5lbC1zaW1wbGUuYwo+ID4gPiA+IEBAIC0xMTAsNiArMTEwLDcgQEAgc3RydWN0IHBhbmVsX3Np bXBsZSB7Cj4gPiA+ID4gIAlzdHJ1Y3QgaTJjX2FkYXB0ZXIgKmRkYzsKPiA+ID4gPgo+ID4gPiA+ ICAJc3RydWN0IGdwaW9fZGVzYyAqZW5hYmxlX2dwaW87Cj4gPiA+ID4gKwlzdHJ1Y3QgZ3Bpb19k ZXNjICpyZXNldF9ncGlvOwo+ID4gPiA+Cj4gPiA+ID4gIAlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9k ZSBvdmVycmlkZV9tb2RlOwo+ID4gPiA+ICB9Owo+ID4gPiA+IEBAIC00MzMsMTIgKzQzNCwyMSBA QCBzdGF0aWMgaW50IHBhbmVsX3NpbXBsZV9wcm9iZShzdHJ1Y3QgZGV2aWNlICpkZXYsIGNvbnN0 IHN0cnVjdCBwYW5lbF9kZXNjICpkZXNjKQo+ID4gPiA+ICAJaWYgKElTX0VSUihwYW5lbC0+c3Vw cGx5KSkKPiA+ID4gPiAgCQlyZXR1cm4gUFRSX0VSUihwYW5lbC0+c3VwcGx5KTsKPiA+ID4gPgo+ ID4gPiA+ICsJcGFuZWwtPnJlc2V0X2dwaW8gPSBkZXZtX2dwaW9kX2dldF9vcHRpb25hbChkZXYs ICJyZXNldCIsCj4gPiA+ID4gKwkJCQkJCSAgICBHUElPRF9PVVRfTE9XKTsKPiA+ID4gPiArCWlm IChJU19FUlIocGFuZWwtPnJlc2V0X2dwaW8pKSB7Cj4gPiA+ID4gKwkJZXJyID0gUFRSX0VSUihw YW5lbC0+cmVzZXRfZ3Bpbyk7Cj4gPiA+ID4gKwkJaWYgKGVyciAhPSAtRVBST0JFX0RFRkVSKQo+ ID4gPiA+ICsJCQlkZXZfZXJyKGRldiwgImZhaWxlZCB0byByZXF1ZXN0IHJlc2V0IHBpbjogJWRc biIsIGVycik7Cj4gPiA+ID4gKwkJcmV0dXJuIGVycjsKPiA+ID4gPiArCX0KPiA+ID4gPiArICAK PiA+ID4KPiA+ID4gSG93ZXZlciwgSSdtIHdvbmRlcmluZyBpZiBpdCB3b3VsZG4ndCBiZSBiZXR0 ZXIgdG8ganVzdCBoYXZlIHRoZQo+ID4gPiBkZXZpY2UgbWFpbnRhaW5lZCBpbiByZXNldCBhdCBw cm9iZSAoc28gT1VUX0hJR0gpIGFuZCBtb3ZlZCBvdXQgb2YKPiA+ID4gcmVzZXQgZHVyaW5nIGVp dGhlciB0aGUgcHJlcGFyZSBvciBlbmFibGUgY2FsbGJhY2tzLgo+ID4gPgo+ID4gPiBUaGlzIGlz IHByZXR0eSBtdWNoIHdoYXQgaXMgaGFwcGVuaW5nIHdpdGggdGhlIGVuYWJsZS1ncGlvcyBhbHJl YWR5Lgo+ID4gPgo+ID4gPiBBbHNvLCBwYW5lbHMgdXN1YWxseSBuZWVkIHRvIHdhaXQgZm9yIGEg bWluaW11bSB0aW1lIGFmdGVyIHlvdQo+ID4gPiBkZWFzc2VydCB0aGUgcmVzZXQgbGluZS4gSG93 IGlzIHRoYXQgZGVhbHQgd2l0aD8KPiA+ID4KPiA+ID4gSSBndWVzcyBhIGdvb2Qgd2F5IHRvIGRv IHRoYXQgd291bGQgYmUgdG8gYWRkIHRoYXQgZHVyYXRpb24gdG8gdGhlCj4gPiA+IHBhbmVsIGRl c2NyaXB0aW9uLCBzaW5jZSB0aGlzIGlzIHByZXR0eSBtdWNoIGRldmljZSBzcGVjaWZpYy4gIAo+ ID4KPiA+IFdoYXQgYWJvdXQgdGhlIGNhc2Ugd2VyZSB5b3VyIEJvb3Rsb2FkZXIgZGlzcGxheXMg c29tZXRoaW5nIGFuZCB5b3UKPiA+IGRvbid0IHdhbnQgdGhlIHBhbmVsIHRvIGJsaW5rID8gIAo+ IAo+IFRoZSBCb290bG9hZGVyIHRvIExpbnV4IHRyYW5zaXRpb24gd2lsbCBtYWtlIHRoZSBwYW5l bCBibGluayBhbHJlYWR5LAo+IHNpbmNlIHRoZSBkaXNwbGF5IGVuZ2luZSBpcyBnb2luZyB0byBi ZSByZXNldCAvIHJlY29uZmlndXJlZCBkdXJpbmcKPiB0aGUgdHJhbnNpdGlvbi4KPiAKPiBUaGUg b25seSB3YXkgdG8gaW1wbGVtZW50IHRoaXMgd291bGQgYmUgdG8gaW1wbGVtZW50IHByb3Blcmx5 IHRoZQo+IHJlc2V0IGNhbGxiYWNrcyBpbiBhbGwgeW91IGRpc3BsYXkgZHJpdmVycyB0byByZWNy ZWF0ZSB0aGUgRFJNIHN0YXRlCj4gZnJvbSB0aGUgaGFyZHdhcmUgc3RhdGUsIGFuZCB0aGVuIHlv dSdsbCBiZSBhYmxlIHRvIGp1c3Qgc3dpdGNoIHRvIHRoZQo+IG5ldyBidWZmZXIuCj4gCj4gT25s eSBJbnRlbCBkb2VzIHRoaXMgYXQgdGhlIHRpbWUgdGhvdWdoLCBhbmQgdGhhdCdzIHdheSBvdXRz aWRlIG9mIHRoZQo+IHNjb3BlIG9mIHRoaXMgcGF0Y2guLi4KPiAKPiA+IFJpZ2h0IG5vdyBJIGFt IGp1c3QgZm9yY2luZyB0aGUgcmVzZXQgdG8gYmUgZGVhc3NlcnRlZC4gIAo+IAo+IC4uLiBFc3Bl Y2lhbGx5IHNpbmNlIHRoZSB2ZXJ5IG5leHQgbGluZSBhZnRlciB5b3VyIHBhdGNoIGZvcmNlcyB0 aGUKPiBwYW5lbCB0byBiZSBkaXNhYmxlZC4KPiAKCklzIHRoZSBhZGRpdGlvbiBvZiB0aGUgcmVz ZXQgc3VwcG9ydCAoYXMgcHJvcG9zZWQgYnkgTWF4aW1lKQppbnRlcmVzdGluZyBmcm9tIHlvdXIg cG9pbnQgb2Ygdmlldz8gQXMgeW91IGFuc3dlcmVkIHRoYXQgeW91IHdlcmUgbm90CnVuZGVyc3Rh bmRpbmcgdGhlIG5lZWRzIGZvciBzdWNoIGEgY2hhbmdlLCBJIHByZWZlciB0byBhc2sgYmVmb3Jl CnNwZW5kaW5nIG1vcmUgdGltZSBvbiBpdC4KCgpUaGFua3MsCk1pcXXDqGwKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 752FDC43603 for ; Mon, 16 Dec 2019 13:48:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CED620409 for ; Mon, 16 Dec 2019 13:48:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727972AbfLPNsQ convert rfc822-to-8bit (ORCPT ); Mon, 16 Dec 2019 08:48:16 -0500 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:50891 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727579AbfLPNsP (ORCPT ); Mon, 16 Dec 2019 08:48:15 -0500 X-Originating-IP: 91.224.148.103 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 351A2C0003; Mon, 16 Dec 2019 13:48:11 +0000 (UTC) Date: Mon, 16 Dec 2019 14:48:10 +0100 From: Miquel Raynal To: Maxime Ripard Cc: Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Maxime Chevallier , Paul Kocialkowski , Thomas Petazzoni Subject: Re: [PATCH] drm/panel: simple: Support reset GPIOs Message-ID: <20191216144810.18710ed3@xps13> In-Reply-To: <20191216132732.mmqivmpnq4mio6oo@gilmour.lan> References: <20191213181325.26228-1-miquel.raynal@bootlin.com> <20191216130615.qs6ub7bwqofwvhr7@gilmour.lan> <20191216141036.24c22899@xps13> <20191216132732.mmqivmpnq4mio6oo@gilmour.lan> Organization: Bootlin X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sam, Maxime Ripard wrote on Mon, 16 Dec 2019 14:27:32 +0100: > On Mon, Dec 16, 2019 at 02:10:36PM +0100, Miquel Raynal wrote: > > > > drivers/gpu/drm/panel/panel-simple.c | 12 +++++++++++- > > > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > > > index 5d487686d25c..15dd495c347d 100644 > > > > --- a/drivers/gpu/drm/panel/panel-simple.c > > > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > > > @@ -110,6 +110,7 @@ struct panel_simple { > > > > struct i2c_adapter *ddc; > > > > > > > > struct gpio_desc *enable_gpio; > > > > + struct gpio_desc *reset_gpio; > > > > > > > > struct drm_display_mode override_mode; > > > > }; > > > > @@ -433,12 +434,21 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > > > > if (IS_ERR(panel->supply)) > > > > return PTR_ERR(panel->supply); > > > > > > > > + panel->reset_gpio = devm_gpiod_get_optional(dev, "reset", > > > > + GPIOD_OUT_LOW); > > > > + if (IS_ERR(panel->reset_gpio)) { > > > > + err = PTR_ERR(panel->reset_gpio); > > > > + if (err != -EPROBE_DEFER) > > > > + dev_err(dev, "failed to request reset pin: %d\n", err); > > > > + return err; > > > > + } > > > > + > > > > > > However, I'm wondering if it wouldn't be better to just have the > > > device maintained in reset at probe (so OUT_HIGH) and moved out of > > > reset during either the prepare or enable callbacks. > > > > > > This is pretty much what is happening with the enable-gpios already. > > > > > > Also, panels usually need to wait for a minimum time after you > > > deassert the reset line. How is that dealt with? > > > > > > I guess a good way to do that would be to add that duration to the > > > panel description, since this is pretty much device specific. > > > > What about the case were your Bootloader displays something and you > > don't want the panel to blink ? > > The Bootloader to Linux transition will make the panel blink already, > since the display engine is going to be reset / reconfigured during > the transition. > > The only way to implement this would be to implement properly the > reset callbacks in all you display drivers to recreate the DRM state > from the hardware state, and then you'll be able to just switch to the > new buffer. > > Only Intel does this at the time though, and that's way outside of the > scope of this patch... > > > Right now I am just forcing the reset to be deasserted. > > ... Especially since the very next line after your patch forces the > panel to be disabled. > Is the addition of the reset support (as proposed by Maxime) interesting from your point of view? As you answered that you were not understanding the needs for such a change, I prefer to ask before spending more time on it. Thanks, Miquèl