From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FC7FC43603 for ; Mon, 16 Dec 2019 17:11:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C301206D7 for ; Mon, 16 Dec 2019 17:11:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C301206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E056C6E83E; Mon, 16 Dec 2019 17:11:25 +0000 (UTC) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7D0A06E83E for ; Mon, 16 Dec 2019 17:11:24 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Dec 2019 09:11:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,322,1571727600"; d="scan'208";a="266310685" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by FMSMGA003.fm.intel.com with SMTP; 16 Dec 2019 09:11:21 -0800 Received: by stinkbox (sSMTP sendmail emulation); Mon, 16 Dec 2019 19:11:20 +0200 Date: Mon, 16 Dec 2019 19:11:20 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Manasi Navare Message-ID: <20191216171120.GY1208@intel.com> References: <20191211211425.17821-1-manasi.d.navare@intel.com> <20191211211425.17821-2-manasi.d.navare@intel.com> <20191213200549.GD1208@intel.com> <20191214022836.GH19224@intel.com> <20191216120343.GM1208@intel.com> <20191216164023.GA17177@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191216164023.GA17177@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH 1/3] drm/i915/dp: Make sure all tiled connectors get added to the state with full modeset X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, Dec 16, 2019 at 08:40:24AM -0800, Manasi Navare wrote: > On Mon, Dec 16, 2019 at 02:03:43PM +0200, Ville Syrj=E4l=E4 wrote: > > On Fri, Dec 13, 2019 at 06:28:40PM -0800, Manasi Navare wrote: > > > On Fri, Dec 13, 2019 at 10:05:49PM +0200, Ville Syrj=E4l=E4 wrote: > > > > On Wed, Dec 11, 2019 at 01:14:23PM -0800, Manasi Navare wrote: > > > > > In case of tiled displays, all the tiles are linke dto each other > > > > > for transcoder port sync. So in intel_atomic_check() we need to m= ake > > > > > sure that we add all the tiles to the modeset and if one of the > > > > > tiles needs a full modeset then mark all other tiles for a full m= odeset. > > > > > = > > > > > Suggested-by: Ville Syrj=E4l=E4 > > > > > Cc: Ville Syrj=E4l=E4 > > > > > Cc: Jos=E9 Roberto de Souza > > > > > Bugzilla: https://gitlab.freedesktop.org/drm/intel/issues/5 > > > > > Signed-off-by: Manasi Navare > > > > > --- > > > > > drivers/gpu/drm/i915/display/intel_display.c | 78 ++++++++++++++= ++++++ > > > > > 1 file changed, 78 insertions(+) > > > > > = > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drive= rs/gpu/drm/i915/display/intel_display.c > > > > > index 803993a01ca7..7263eaa66cda 100644 > > > > > --- a/drivers/gpu/drm/i915/display/intel_display.c > > > > > +++ b/drivers/gpu/drm/i915/display/intel_display.c > > > > > @@ -14066,6 +14066,80 @@ static int intel_atomic_check_crtcs(stru= ct intel_atomic_state *state) > > > > > return 0; > > > > > } > > > > > = > > > > > +static int > > > > > +intel_dp_modeset_all_tiles(struct drm_i915_private *dev_priv, > > > > > + struct intel_atomic_state *state, int tile_grp_id) > > > > > +{ > > > > > + struct drm_connector *conn_iter; > > > > 'connector' > > > > > + struct drm_connector_list_iter conn_list_iter; > > > > > + struct drm_crtc_state *crtc_state; > > > > = > > > > crtc_state has needlessly wide scope. > > > > = > > > > > + > > > > > + drm_connector_list_iter_begin(&dev_priv->drm, &conn_list_iter); > > > > > + drm_for_each_connector_iter(conn_iter, &conn_list_iter) { > > > > > + struct drm_connector_state *conn_iter_state; > > > > = > > > > 'conn_state' is the most popular name. > > > > = > > > > > + > > > > > + if (!conn_iter->has_tile) > > > > > + continue; > > > > > + conn_iter_state =3D drm_atomic_get_connector_state(&state->bas= e, > > > > > + conn_iter); > > > > > + if (IS_ERR(conn_iter_state)) { > > > > > + drm_connector_list_iter_end(&conn_list_iter); > > > > > + return PTR_ERR(conn_iter_state); > > > > > + } > > > > > + > > > > > + if (!conn_iter_state->crtc) > > > > > + continue; > > > > > + > > > > > + if (conn_iter->tile_group->id !=3D tile_grp_id) > > > > > + continue; > > > > = > > > > The tile group check should be part of the same if with the has_tile > > > > check. > > > > = > > > > > + > > > > > + crtc_state =3D drm_atomic_get_crtc_state(&state->base, conn_it= er_state->crtc); > > > > > + if (IS_ERR(crtc_state)) { > > > > > + drm_connector_list_iter_end(&conn_list_iter); > > > > > + return PTR_ERR(conn_iter_state); > > > > > + } > > > > > + crtc_state->mode_changed =3D true; > > > > > + } > > > > > + drm_connector_list_iter_end(&conn_list_iter); > > > > > + > > > > > + return 0; > > > > > +} > > > > > + > > > > > +static int > > > > > +intel_dp_atomic_trans_port_sync_check(struct drm_i915_private *d= ev_priv, > > > > = > > > > Pointless variable. Can be extracted from the atomic state. > > > > = > > > > > + struct intel_atomic_state *state) > > > > > +{ > > > > > + struct drm_connector *connector; > > > > > + struct drm_crtc_state *crtc_state; > > > > > + struct drm_connector_state *connector_state; > > > > > + int i, ret, tile_grp_id =3D 0; > > > > = > > > > tile_grp_id is rather pointless. crtc_state and ret can move into > > > > tighter scope. And the next suggestion allows you to kill crtc_state > > > > entirely... > > > = > > > Its not clear why tile_grp_id is pointless, I am using tile_grp_id fo= r the first connector with has_tile > > > and I make sure that I dont enter into the loop to check modeset agai= n for the connector with > > > same tile_grp_id because we have already set its mode changed to true= in intel_dp_modeset_all_tiles() > > > = > > > How can I achieve this instead? > > = > > = > > Instead of = > > foo() > > { > > tile_grp_id =3D 0; > > = > > for_each() { > > tile_grp_id =3D conn->tile_grp_id; > > = > > intel_dp_modeset_all_tiles(tile_grp_id); > > } > > } > > = > > you just do > > foo() > > { > > for_each() { > > intel_dp_modeset_all_tiles(conn->tile_grp_id); > > } > > } > = > Yes I understand that we can pass the conn->tile_grp_id directly. But cur= rently I am using tile_grp_id in for_each(), to call intel_dp_modeset_all_t= iles() > only if that cnnector is from a differnt tile grp id else continue. > = > foo() > { > for_each() { > if(tile_grp_id !=3D conn->tile_grp_id) > intel_dpmodeset_all_tiles(); > else > continue; > } > } > = > calling intel_dp_modeset_all_tiles() for all tiles is kind of redundant. = How can I do this with your suggestion, or do you think > we should call intel_dp_modeset_all_tiles for each connector anyway and i= t shouldnt matter? Yes if that connector is tiled. Eg. if you have something like connector A: tile group 1 connector B: tile group 2 connector C: tile group 3 connector D: tile group 2 then your single tile_grp_id variable doesn't work anyway. You'd need track which tile groups you've already handled and skip those. But much easier to just blindly plow ahead. -- = Ville Syrj=E4l=E4 Intel _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx