From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, ioana.ciornei@nxp.com, olteanv@gmail.com,
jakub.kicinski@netronome.com, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next] net: dsa: Make PHYLINK related function static again
Date: Mon, 16 Dec 2019 18:55:30 +0000 [thread overview]
Message-ID: <20191216185530.GN25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <20191216183248.16309-1-f.fainelli@gmail.com>
On Mon, Dec 16, 2019 at 10:32:47AM -0800, Florian Fainelli wrote:
> Commit 77373d49de22 ("net: dsa: Move the phylink driver calls into
> port.c") moved and exported a bunch of symbols, but they are not used
> outside of net/dsa/port.c at the moment, so no reason to export them.
>
> Reported-by: Russell King <rmk+kernel@armlinux.org.uk>
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Thanks.
> ---
> net/dsa/dsa_priv.h | 16 ----------------
> net/dsa/port.c | 38 ++++++++++++++++----------------------
> 2 files changed, 16 insertions(+), 38 deletions(-)
>
> diff --git a/net/dsa/dsa_priv.h b/net/dsa/dsa_priv.h
> index 2dd86d9bcda9..09ea2fd78c74 100644
> --- a/net/dsa/dsa_priv.h
> +++ b/net/dsa/dsa_priv.h
> @@ -150,22 +150,6 @@ int dsa_port_vid_add(struct dsa_port *dp, u16 vid, u16 flags);
> int dsa_port_vid_del(struct dsa_port *dp, u16 vid);
> int dsa_port_link_register_of(struct dsa_port *dp);
> void dsa_port_link_unregister_of(struct dsa_port *dp);
> -void dsa_port_phylink_validate(struct phylink_config *config,
> - unsigned long *supported,
> - struct phylink_link_state *state);
> -void dsa_port_phylink_mac_pcs_get_state(struct phylink_config *config,
> - struct phylink_link_state *state);
> -void dsa_port_phylink_mac_config(struct phylink_config *config,
> - unsigned int mode,
> - const struct phylink_link_state *state);
> -void dsa_port_phylink_mac_an_restart(struct phylink_config *config);
> -void dsa_port_phylink_mac_link_down(struct phylink_config *config,
> - unsigned int mode,
> - phy_interface_t interface);
> -void dsa_port_phylink_mac_link_up(struct phylink_config *config,
> - unsigned int mode,
> - phy_interface_t interface,
> - struct phy_device *phydev);
> extern const struct phylink_mac_ops dsa_port_phylink_mac_ops;
>
> /* slave.c */
> diff --git a/net/dsa/port.c b/net/dsa/port.c
> index 46ac9ba21987..ffb5601f7ed6 100644
> --- a/net/dsa/port.c
> +++ b/net/dsa/port.c
> @@ -415,9 +415,9 @@ static struct phy_device *dsa_port_get_phy_device(struct dsa_port *dp)
> return phydev;
> }
>
> -void dsa_port_phylink_validate(struct phylink_config *config,
> - unsigned long *supported,
> - struct phylink_link_state *state)
> +static void dsa_port_phylink_validate(struct phylink_config *config,
> + unsigned long *supported,
> + struct phylink_link_state *state)
> {
> struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
> struct dsa_switch *ds = dp->ds;
> @@ -427,10 +427,9 @@ void dsa_port_phylink_validate(struct phylink_config *config,
>
> ds->ops->phylink_validate(ds, dp->index, supported, state);
> }
> -EXPORT_SYMBOL_GPL(dsa_port_phylink_validate);
>
> -void dsa_port_phylink_mac_pcs_get_state(struct phylink_config *config,
> - struct phylink_link_state *state)
> +static void dsa_port_phylink_mac_pcs_get_state(struct phylink_config *config,
> + struct phylink_link_state *state)
> {
> struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
> struct dsa_switch *ds = dp->ds;
> @@ -444,11 +443,10 @@ void dsa_port_phylink_mac_pcs_get_state(struct phylink_config *config,
> if (ds->ops->phylink_mac_link_state(ds, dp->index, state) < 0)
> state->link = 0;
> }
> -EXPORT_SYMBOL_GPL(dsa_port_phylink_mac_pcs_get_state);
>
> -void dsa_port_phylink_mac_config(struct phylink_config *config,
> - unsigned int mode,
> - const struct phylink_link_state *state)
> +static void dsa_port_phylink_mac_config(struct phylink_config *config,
> + unsigned int mode,
> + const struct phylink_link_state *state)
> {
> struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
> struct dsa_switch *ds = dp->ds;
> @@ -458,9 +456,8 @@ void dsa_port_phylink_mac_config(struct phylink_config *config,
>
> ds->ops->phylink_mac_config(ds, dp->index, mode, state);
> }
> -EXPORT_SYMBOL_GPL(dsa_port_phylink_mac_config);
>
> -void dsa_port_phylink_mac_an_restart(struct phylink_config *config)
> +static void dsa_port_phylink_mac_an_restart(struct phylink_config *config)
> {
> struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
> struct dsa_switch *ds = dp->ds;
> @@ -470,11 +467,10 @@ void dsa_port_phylink_mac_an_restart(struct phylink_config *config)
>
> ds->ops->phylink_mac_an_restart(ds, dp->index);
> }
> -EXPORT_SYMBOL_GPL(dsa_port_phylink_mac_an_restart);
>
> -void dsa_port_phylink_mac_link_down(struct phylink_config *config,
> - unsigned int mode,
> - phy_interface_t interface)
> +static void dsa_port_phylink_mac_link_down(struct phylink_config *config,
> + unsigned int mode,
> + phy_interface_t interface)
> {
> struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
> struct phy_device *phydev = NULL;
> @@ -491,12 +487,11 @@ void dsa_port_phylink_mac_link_down(struct phylink_config *config,
>
> ds->ops->phylink_mac_link_down(ds, dp->index, mode, interface);
> }
> -EXPORT_SYMBOL_GPL(dsa_port_phylink_mac_link_down);
>
> -void dsa_port_phylink_mac_link_up(struct phylink_config *config,
> - unsigned int mode,
> - phy_interface_t interface,
> - struct phy_device *phydev)
> +static void dsa_port_phylink_mac_link_up(struct phylink_config *config,
> + unsigned int mode,
> + phy_interface_t interface,
> + struct phy_device *phydev)
> {
> struct dsa_port *dp = container_of(config, struct dsa_port, pl_config);
> struct dsa_switch *ds = dp->ds;
> @@ -509,7 +504,6 @@ void dsa_port_phylink_mac_link_up(struct phylink_config *config,
>
> ds->ops->phylink_mac_link_up(ds, dp->index, mode, interface, phydev);
> }
> -EXPORT_SYMBOL_GPL(dsa_port_phylink_mac_link_up);
>
> const struct phylink_mac_ops dsa_port_phylink_mac_ops = {
> .validate = dsa_port_phylink_validate,
> --
> 2.17.1
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-12-16 18:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 18:32 [PATCH net-next] net: dsa: Make PHYLINK related function static again Florian Fainelli
2019-12-16 18:48 ` Vivien Didelot
2019-12-16 18:55 ` Russell King - ARM Linux admin [this message]
2019-12-16 21:37 ` Vladimir Oltean
2019-12-17 22:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216185530.GN25745@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=jakub.kicinski@netronome.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.