All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Cc: Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Clark Williams <williams@redhat.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	John Garry <john.garry@huawei.com>, Jiri Olsa <jolsa@redhat.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Will Deacon <will@kernel.org>
Subject: [PATCH 2/9] perf arch: Make the default get_cpuid() return compatible error
Date: Mon, 16 Dec 2019 17:47:31 -0300	[thread overview]
Message-ID: <20191216204738.12107-3-acme@kernel.org> (raw)
In-Reply-To: <20191216204738.12107-1-acme@kernel.org>

From: Arnaldo Carvalho de Melo <acme@redhat.com>

Some of the functions calling get_cpuid() propagate back the error it
returns, and all are using errno (positive) values, make the weak
default get_cpuid() function return ENOSYS to be consistent and to allow
checking if this is an arch not providing this function or if a provided
one is having trouble getting the cpuid, to decide if the warning should
be provided to the user or just a debug message should be emitted.

Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Tested-by: Mark Rutland <mark.rutland@arm.com>
Tested-by: John Garry <john.garry@huawei.com> # arm64
Acked-by: Jiri Olsa <jolsa@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Will Deacon <will@kernel.org>
Link: https://lkml.kernel.org/n/tip-lxwjr0cd2eggzx04a780ffrv@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/header.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
index becc2d109423..4d39a75551a0 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -850,7 +850,7 @@ int __weak strcmp_cpuid_str(const char *mapcpuid, const char *cpuid)
  */
 int __weak get_cpuid(char *buffer __maybe_unused, size_t sz __maybe_unused)
 {
-	return -1;
+	return ENOSYS; /* Not implemented */
 }
 
 static int write_cpuid(struct feat_fd *ff,
-- 
2.21.0

  parent reply	other threads:[~2019-12-16 20:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16 20:47 [GIT PULL 0/9] perf/urgent fixes Arnaldo Carvalho de Melo
2019-12-16 20:47 ` [PATCH 1/9] tools headers kvm: Sync linux/kvm.h with the kernel sources Arnaldo Carvalho de Melo
2019-12-16 20:47 ` Arnaldo Carvalho de Melo [this message]
2019-12-16 20:47 ` [PATCH 3/9] perf top: Do not bail out when perf_env__read_cpuid() returns ENOSYS Arnaldo Carvalho de Melo
2019-12-16 20:47 ` [PATCH 4/9] perf/x86/pmu-events: Fix Kernel_Utilization metric Arnaldo Carvalho de Melo
2019-12-16 20:47 ` [PATCH 5/9] perf metricgroup: Fix printing event names of metric group with multiple events Arnaldo Carvalho de Melo
2019-12-16 20:47 ` [PATCH 6/9] perf header: Fix false warning when there are no duplicate cache entries Arnaldo Carvalho de Melo
2019-12-16 20:47 ` [PATCH 7/9] libtraceevent: Allow custom libdir path Arnaldo Carvalho de Melo
2019-12-16 20:47 ` [PATCH 8/9] perf vendor events s390: Fix counter long description for DTLB1_GPAGE_WRITES Arnaldo Carvalho de Melo
2019-12-16 20:47 ` [PATCH 9/9] perf vendor events s390: Remove name from L1D_RO_EXCL_WRITES description Arnaldo Carvalho de Melo
2019-12-17 11:28 ` [GIT PULL 0/9] perf/urgent fixes Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191216204738.12107-3-acme@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=john.garry@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@kernel.org \
    --cc=namhyung@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=will@kernel.org \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.