Re: [PATCH iproute2 0/8] bridge vlan tunnelshow fixes

[Stephen Hemminger <stephen@networkplumber.org>]

On Mon, 16 Dec 2019 15:43:36 +0900
Benjamin Poirier <bpoirier@cumulusnetworks.com> wrote:

> Fix various problems in and around normal and json output of `bridge vlan
> tunnelshow`.
> 
> Can be tested using:
> ip link add bridge type bridge
> 
> ip link add vxlan0 type vxlan dstport 4789 external
> ip link set dev vxlan0 master bridge
> ip link set dev vxlan0 type bridge_slave vlan_tunnel on
> 
> bridge vlan add dev vxlan0 vid 1000
> bridge vlan add dev vxlan0 vid 1000 tunnel_info id 1000
> bridge vlan add dev vxlan0 vid 1010-1020
> bridge vlan add dev vxlan0 vid 1010-1020 tunnel_info id 1010-1020
> bridge vlan add dev vxlan0 vid 1030
> bridge vlan add dev vxlan0 vid 1030 tunnel_info id 65556
> 
> Benjamin Poirier (8):
>   json_print: Remove declaration without implementation
>   testsuite: Fix line count test
>   bridge: Fix typo in error messages
>   bridge: Fix src_vni argument in man page
>   bridge: Fix BRIDGE_VLAN_TUNNEL attribute sizes
>   bridge: Fix vni printing
>   bridge: Deduplicate vlan show functions
>   bridge: Fix tunnelshow json output
> 
>  bridge/vlan.c                            | 138 ++++++++---------------
>  include/json_print.h                     |   2 -
>  man/man8/bridge.8                        |   4 +-
>  testsuite/Makefile                       |   3 +-
>  testsuite/lib/generic.sh                 |   8 +-
>  testsuite/tests/bridge/vlan/tunnelshow.t |  33 ++++++
>  6 files changed, 88 insertions(+), 100 deletions(-)
>  create mode 100755 testsuite/tests/bridge/vlan/tunnelshow.t
> 

Thanks for cleaning this up. Applied