All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
	Jiri Slaby <jslaby@suse.com>,
	linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
	linux-serial@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2 0/3] tty/leds: implement a trigger for ttys
Date: Tue, 17 Dec 2019 09:32:54 +0100	[thread overview]
Message-ID: <20191217083254.GD2672708@kroah.com> (raw)
In-Reply-To: <20191217081718.23807-1-u.kleine-koenig@pengutronix.de>

On Tue, Dec 17, 2019 at 09:17:15AM +0100, Uwe Kleine-König wrote:
> Hello,
> 
> back in November last year I sent my last approach to implement an led
> trigger for UARTs (Message-Id:
> 20181106213739.29628-1-u.kleine-koenig@pengutronix.de). This was parked
> on my todo list since then somewhere far from the top.
> 
> This is a new approach. Similar to the netdev trigger the tty trigger
> introduced here periodically checks the statistics related to a given
> tty and if that changed the LED is flashed once.
> 
> I had to introduce two functions in the tty layer to be able to get my
> hands on the needed data in the first two patches, the third patch then
> adds the trigger.

I like the idea, seems sane.  Minor code nits on the implementation
though...

thanks,

greg k-h

      parent reply	other threads:[~2019-12-17  8:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17  8:17 [PATCH v2 0/3] tty/leds: implement a trigger for ttys Uwe Kleine-König
2019-12-17  8:17 ` [PATCH v2 1/3] tty: new helper function tty_kopen_shared Uwe Kleine-König
2019-12-17  8:27   ` Greg Kroah-Hartman
2019-12-17 10:51     ` Uwe Kleine-König
2019-12-17 11:05       ` Greg Kroah-Hartman
2019-12-17  8:17 ` [PATCH v2 2/3] tty: new helper function tty_get_icount() Uwe Kleine-König
2019-12-17  8:28   ` Greg Kroah-Hartman
2019-12-17  8:17 ` [PATCH v2 3/3] leds: trigger: implement a tty trigger Uwe Kleine-König
2019-12-17  8:32   ` Greg Kroah-Hartman
2019-12-17 10:58     ` Uwe Kleine-König
2019-12-17 11:07       ` Greg Kroah-Hartman
2019-12-17  8:32 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191217083254.GD2672708@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dmurphy@ti.com \
    --cc=jacek.anaszewski@gmail.com \
    --cc=jslaby@suse.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.