From: Greg KH <gregkh@linuxfoundation.org>
To: Julian Preis <julian.preis@fau.de>
Cc: devel@driverdev.osuosl.org, valdis.kletnieks@vt.edu,
Johannes Weidner <johannes.weidner@fau.de>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2] drivers/staging/exfat/exfat_super.c: Clean up ffsCamelCase function names
Date: Tue, 17 Dec 2019 14:10:07 +0100 [thread overview]
Message-ID: <20191217131007.GA3233328@kroah.com> (raw)
In-Reply-To: <20191216141623.22379-1-julian.preis@fau.de>
On Mon, Dec 16, 2019 at 03:16:23PM +0100, Julian Preis wrote:
> Rename every instance of <ffsCamelCaseExample> to <ffs_camel_case_example>
> in file exfat_super.c. Fix resulting overlong lines.
>
> Co-developed-by: Johannes Weidner <johannes.weidner@fau.de>
> Signed-off-by: Johannes Weidner <johannes.weidner@fau.de>
> Signed-off-by: Julian Preis <julian.preis@fau.de>
> ---
> Changes in v2:
> - Add email recipients according to get_maintainer.pl
> - Add patch versions
> - Use in-reply-to
>
> drivers/staging/exfat/exfat_super.c | 99 +++++++++++++++--------------
> 1 file changed, 51 insertions(+), 48 deletions(-)
>
> diff --git a/drivers/staging/exfat/exfat_super.c b/drivers/staging/exfat/exfat_super.c
> index 6e481908c59f..14ff3fce70fb 100644
> --- a/drivers/staging/exfat/exfat_super.c
> +++ b/drivers/staging/exfat/exfat_super.c
> @@ -343,7 +343,7 @@ static inline void exfat_save_attr(struct inode *inode, u32 attr)
> EXFAT_I(inode)->fid.attr = attr & (ATTR_RWMASK | ATTR_READONLY);
> }
>
> -static int ffsMountVol(struct super_block *sb)
> +static int ffs_mount_vol(struct super_block *sb)
Why do these static functions even have to have "ffs" at the front of
them anyway? There's no requirement here, right? Shouldn't this just
be "mount_vol()"?
thanks,
greg k-h
prev parent reply other threads:[~2019-12-17 13:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 14:16 [PATCH v2] drivers/staging/exfat/exfat_super.c: Clean up ffsCamelCase function names Julian Preis
2019-12-17 13:10 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217131007.GA3233328@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=johannes.weidner@fau.de \
--cc=julian.preis@fau.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.