From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED8DDC43603 for ; Tue, 17 Dec 2019 13:47:15 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 72C3620733 for ; Tue, 17 Dec 2019 13:47:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="qVHpK5E9"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XK994wVV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 72C3620733 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CD87C843; Tue, 17 Dec 2019 14:46:23 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CD87C843 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1576590433; bh=8FDadMwkx3KpxRoI2y3OLdNL7DMkJcz7hxi0r06NVto=; h=Date:From:To:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=qVHpK5E9Crqgv6p58Ro7i3h5NZvsEObIw2cWxlsluh5I+1FkSBolfmnz9LqtZb4a8 FLEyNQNyoDWD2+ciOzWwlN/VdJsVDMlP5ijC61uxXsm88dKD6S0DKji2cU1dQ7A8AR 57ZdICN4ctlO/E4UBo/TgkB/l5nMu8jZ/uk8cw+g= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 5E067F80100; Tue, 17 Dec 2019 14:46:23 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 008A9F80234; Tue, 17 Dec 2019 14:46:21 +0100 (CET) Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 217CCF80100 for ; Tue, 17 Dec 2019 14:46:18 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 217CCF80100 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XK994wVV" Received: by mail-wm1-x342.google.com with SMTP id b72so3229683wme.4 for ; Tue, 17 Dec 2019 05:46:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=kZuWd/3jkSU468vrZtKybTAjJX1Jep24XVi1Wi4q33k=; b=XK994wVVrkzFy0kYAn6YNVPCGij+VqhuMZC2yPF2zmpoSL1t182ncy8nuiNo5zng4Z WPFfdmKerYYyv2faiAywqYmjUlJWN8c8sDMRIiX2QhGVIqH9X2zcK+ROViyaRiDUZfjN MS46kihklyILLInJAkBt/mjzCwvf4dpgp0yac7AA3B1aclCBtqlsVz1qRWbAJUzDd6Wp walFi+txkCkoY1p6ZAmsmDSUtNZN4W9uvEoo1yOW0pXVuhMT3ppXifn3dvN1DFIBG6hT /2vATZu+R8Iuq8zTRgwX1otltmSndbWvbKrOSQtab37hC5Xokm6YJYdFkuILS1JKU5S4 RQMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=kZuWd/3jkSU468vrZtKybTAjJX1Jep24XVi1Wi4q33k=; b=sxyhEuh8B/A4di/fAPSbyWEPNHJO8usspenTnXeHgJLvzUrsOAsKerRyGKgh8G+AWn 2HZcw9Ke+CmaUFbMhAE3H1HSpZMNLs9b72JyQZWNa4U4cg7sIcKU5WYotcJItN2NIZir tN/+JHQMfPL8pHeDDegEftkV7oqcfG1delv053aHYyme/srIHPjdqhRIqTJMpBAX9srL 5btv5wOyEG10EZ0k+P7+VlOLRcAqZseetm0DccqDi7f3qiPt4M3XadCGFD4uzjOnyJ4b 1nkCmpkY3r01jfZbTu3mdrDl9/8WBmqRksZxo7ntz0V3K3/fq6F02mFR/N0HC2S3HANO z35w== X-Gm-Message-State: APjAAAVkgaKqxbFbiJljEtWAlV7pUtyvRMqpz9yTKVDMyFCsWWW7CGgY 1HQMOrayepCgFmJ1GMR7ZVhEnONA60k= X-Google-Smtp-Source: APXvYqyNCklkEVENRexg11/lVsAZF67JMyMSJB9/s1vxBi0hQ6lOnAJ1HSWjhfQSwKh/52Z4A1/krA== X-Received: by 2002:a1c:3d07:: with SMTP id k7mr5986321wma.79.1576590377924; Tue, 17 Dec 2019 05:46:17 -0800 (PST) Received: from dell ([2.27.35.132]) by smtp.gmail.com with ESMTPSA id r15sm2967823wmh.21.2019.12.17.05.46.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 05:46:17 -0800 (PST) Date: Tue, 17 Dec 2019 13:46:17 +0000 From: Lee Jones To: Daniel Mack Message-ID: <20191217134617.GK18955@dell> References: <20191209183511.3576038-1-daniel@zonque.org> <20191209183511.3576038-8-daniel@zonque.org> <20191217133952.GJ18955@dell> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191217133952.GJ18955@dell> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, lars@metafoo.de, sboyd@kernel.org, mturquette@baylibre.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, robh+dt@kernel.org, broonie@kernel.org, linux-i2c@vger.kernel.org, pascal.huerst@gmail.com, linux-clk@vger.kernel.org Subject: Re: [alsa-devel] [PATCH 06/10] mfd: Add core driver for AD242x A2B transceivers X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" T24gVHVlLCAxNyBEZWMgMjAxOSwgTGVlIEpvbmVzIHdyb3RlOgoKPiBPbiBNb24sIDA5IERlYyAy MDE5LCBEYW5pZWwgTWFjayB3cm90ZToKPiAKPiA+IFRoZSBjb3JlIGRyaXZlciBmb3IgdGhlc2Ug ZGV2aWNlcyBpcyBzcGxpdCBpbnRvIHNldmVyYWwgcGFydHMuCj4gPiAKPiA+IFRoZSBtYXN0ZXIg bm9kZSBkcml2ZXIgaXMgYW4gSTJDIGNsaWVudC4gSXQgaXMgcmVzcG9uc2libGUgZm9yCj4gPiBi cmluZ2luZyB1cCB0aGUgYnVzIHRvcG9sb2d5IGFuZCBkaXNjb3ZlcmluZyB0aGUgc2xhdmUgbm9k ZXMuCj4gPiBUaGlzIHByb2Nlc3MgcmVxdXJpZXMgc29tZSBrbm93bGVnZGUgb2YgdGhlIHNsYXZl IG5vZGUgY29uZmlndXJhdGlvbgo+ID4gdG8gcHJvZ3JhbSB0aGUgYnVzIHRpbWluZ3MgY29ycmVj dGx5LCBzbyB0aGUgbWFzdGVyIGRyaXZlcnMgd2Fsa3MKPiA+IHRoZSB0cmVlIG9mIG5vZGVzIGlu IHRoZSBkZXZpY2V0cmVlLiBUaGUgc2xhdmUgZHJpdmVyIGhhbmRsZXMgcGxhdGZvcm0KPiA+IGRl dmljZXMgdGhhdCBhcmUgaW5zdGFudGlhdGVkIGJ5IHRoZSBtYXN0ZXIgbm9kZSBkcml2ZXIgYWZ0 ZXIKPiA+IGRpc2NvdmVyeSBoYXMgZmluaXNoZWQuCj4gPiAKPiA+IE1hc3RlciBub2RlcyBleHBv c2UgdHdvIGFkZHJlc3NlcyBvbiB0aGUgSTJDIGJ1cywgb25lIChyZWZlcnJlZCB0byBhcwo+ID4g J0JBU0UnIGluIHRoZSBkYXRhc2hlZXQpIGZvciBhY2Nlc3NpbmcgcmVnaXN0ZXJzIG9uIHRoZSB0 cmFuc2NlaXZlcgo+ID4gbm9kZSBpdHNlbGYsIGFuZCBvbmUgKHJlZmVycmVkIHRvIGFzICdCVVMn KSBmb3IgYWNjZXNzaW5nIHJlbW90ZQo+ID4gcmVnaXN0ZXJzLCBlaXRoZXIgb24gdGhlIHJlbW90 ZSB0cmFuc2NlaXZlciBpdHNlbGYsIG9yIG9uIEkyQyBoYXJkd2FyZQo+ID4gY29ubmVjdGVkIHRv IHRoYXQgcmVtb3RlIHRyYW5zY2VpdmVyLCB3aGljaCB0aGVuIGFjdHMgYXMgYSByZW1vdGUgSTJD Cj4gPiBidXMgbWFzdGVyLgo+ID4gCj4gPiBJbiBvcmRlciB0byBhbGxvdyBNRkQgc3ViLWRldmlj ZXMgdG8gYmUgcmVnaXN0ZXJlZCBhcyBjaGlsZHJlbiBvZgo+ID4gZWl0aGVyIHRoZSBtYXN0ZXIg b3IgYW55IHNsYXZlIG5vZGUsIHRoZSBkZXRhaWxzIG9uIGhvdyB0byBhY2Nlc3MgdGhlCj4gPiBy ZWdpc3RlcnMgYXJlIGhpZGRlbiBiZWhpbmQgYSByZWdtYXAgY29uZmlnLiBBIHBvaW50ZXIgdG8g dGhlIHJlZ21hcAo+ID4gaXMgdGhlbiBleHBvc2VkIGluIHRoZSBzdHJ1Y3Qgc2hhcmVkIHdpdGgg dGhlIHN1Yi1kZXZpY2VzLgo+ID4gCj4gPiBUaGUgYWQyNDJ4LWJ1cyBkcml2ZXIgaXMgYSBzaW1w bGUgcHJveHkgdGhhdCBvY2N1cGllcyB0aGUgQlVTIEkyQwo+ID4gYWRkcmVzcyBhbmQgd2hpY2gg aXMgcmVmZXJyZWQgdG8gdGhyb3VnaCBhIGRldmljZXRyZWUgaGFuZGxlIGJ5IHRoZQo+ID4gbWFz dGVyIGRyaXZlci4KPiA+IAo+ID4gRm9yIHRoZSBkaXNjb3ZlcnkgcHJvY2VzcywgdGhlIGRyaXZl ciBoYXMgdG8gd2FpdCBmb3IgYW4gaW50ZXJydXB0Cj4gPiB0byBvY2N1ci4gSW4gY2FzZSBubyBp bnRlcnJ1cHQgaXMgY29uZmlndXJlZCBpbiBEVCwgdGhlIGRyaXZlciBmYWxscwo+ID4gYmFjayB0 byBpbnRlcnJ1cHQgcG9sbGluZy4gQWZ0ZXIgdGhlIGRpc2NvdmVyeSBwaGFzZSBpcyBjb21wbGV0 ZWQsCj4gPiBpbnRlcnJ1cHRzIGFyZSBvbmx5IG5lZWRlZCBmb3IgZXJyb3IgaGFuZGxpbmcgYW5k IEdQSU8gaGFuZGxpbmcsCj4gPiBib3RoIG9mIHdoaWNoIGlzIG5vdCBjdXJyZW50eSBpbXBsZW1l bnRlZC4KPiA+IAo+ID4gQ29kZSBjb21tb24gdG8gYm90aCB0aGUgbWFzdGVyIGFuZCB0aGUgc2xh dmUgZHJpdmVyIGxpdmVzIGluCj4gPiAnYWQyNDJ4LW5vZGUuYycuCj4gPiAKPiA+IFNpZ25lZC1v ZmYtYnk6IERhbmllbCBNYWNrIDxkYW5pZWxAem9ucXVlLm9yZz4KPiA+IAo+ID4gbWZkCj4gCj4g Pwo+IAo+ID4gLS0tCj4gPiAgZHJpdmVycy9tZmQvS2NvbmZpZyAgICAgICAgIHwgIDExICsKPiA+ ICBkcml2ZXJzL21mZC9NYWtlZmlsZSAgICAgICAgfCAgIDEgKwo+ID4gIGRyaXZlcnMvbWZkL2Fk MjQyeC1idXMuYyAgICB8ICA0MiArKysKPiA+ICBkcml2ZXJzL21mZC9hZDI0MngtbWFzdGVyLmMg fCA2MTEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPiAgZHJpdmVycy9t ZmQvYWQyNDJ4LW5vZGUuYyAgIHwgMjYyICsrKysrKysrKysrKysrKysKPiA+ICBkcml2ZXJzL21m ZC9hZDI0Mngtc2xhdmUuYyAgfCAyMzQgKysrKysrKysrKysrKysKPiA+ICBpbmNsdWRlL2xpbnV4 L21mZC9hZDI0MnguaCAgfCA0MDAgKysrKysrKysrKysrKysrKysrKysrKysKPiAKPiBUaGlzIGRl dmljZSwgb3IgYXQgbGVhc3QgdGhlIHdheSBpdCdzIGJlZW4gY29kZWQgaXMgYmF0dHkhCj4gCj4g SXQncyBnb2luZyB0byBuZWVkIGEgbG90IG9mIG1hc3NhZ2luZyBiZWZvcmUgYmVpbmcgYWNjZXB0 ZWQuCgpPbmUgdGhpbmcgSSBzaG91bGQgbWVudGlvbiB1cGZyb250OyB0aGVyZSBpcyB0b28gbXVj aCBjb2RlICJkb2luZwp0aGluZ3MiIGluIGhlcmUgZm9yIGl0IHRvIGJlIGFuIE1GRC4gIE1GRHMg ZG9uJ3QgY2FyZSBhYm91dDsgc3luY3MsCnNsb3RzLCBURE0sIGludmVydGluZyBsaW5lcywgdXBz dHJlYW1zLCBkb3duc3RyZWFtcywgZXRjIGV0YyBldGMuCkFueXRoaW5nIHJlbW90ZWx5IHRlY2hu aWNhbCBvciBmdW5jdGlvbmFsLCB0aGUgY29kZSB0aGF0ICJkb2VzIHRoaW5ncyIKc2hvdWxkIGJl IG1vdmVkIG91dCB0byB0aGUgcmVsZXZhbnQgYXJlYXMuICBJbiB0aGUgY2FzZSBvZiB0aGlzCmRl dmljZSwgdGhhdCdzIGxvb2tpbmcgbGlrZSBvbmUgb2YgdGhlIEF1ZGlvIHJlbGF0ZWQgc3Vic3lz dGVtcy4KCi0tIApMZWUgSm9uZXMgW+adjueQvOaWr10KTGluYXJvIFNlcnZpY2VzIFRlY2huaWNh bCBMZWFkCkxpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3YXJlIGZvciBBUk0gU29DcwpG b2xsb3cgTGluYXJvOiBGYWNlYm9vayB8IFR3aXR0ZXIgfCBCbG9nCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkFsc2EtZGV2ZWwgbWFpbGluZyBsaXN0CkFs c2EtZGV2ZWxAYWxzYS1wcm9qZWN0Lm9yZwpodHRwczovL21haWxtYW4uYWxzYS1wcm9qZWN0Lm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2Fsc2EtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA33AC2D0C8 for ; Tue, 17 Dec 2019 13:46:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9042321739 for ; Tue, 17 Dec 2019 13:46:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="XK994wVV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728554AbfLQNqU (ORCPT ); Tue, 17 Dec 2019 08:46:20 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:36022 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728557AbfLQNqU (ORCPT ); Tue, 17 Dec 2019 08:46:20 -0500 Received: by mail-wm1-f68.google.com with SMTP id p17so3248562wma.1 for ; Tue, 17 Dec 2019 05:46:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=kZuWd/3jkSU468vrZtKybTAjJX1Jep24XVi1Wi4q33k=; b=XK994wVVrkzFy0kYAn6YNVPCGij+VqhuMZC2yPF2zmpoSL1t182ncy8nuiNo5zng4Z WPFfdmKerYYyv2faiAywqYmjUlJWN8c8sDMRIiX2QhGVIqH9X2zcK+ROViyaRiDUZfjN MS46kihklyILLInJAkBt/mjzCwvf4dpgp0yac7AA3B1aclCBtqlsVz1qRWbAJUzDd6Wp walFi+txkCkoY1p6ZAmsmDSUtNZN4W9uvEoo1yOW0pXVuhMT3ppXifn3dvN1DFIBG6hT /2vATZu+R8Iuq8zTRgwX1otltmSndbWvbKrOSQtab37hC5Xokm6YJYdFkuILS1JKU5S4 RQMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=kZuWd/3jkSU468vrZtKybTAjJX1Jep24XVi1Wi4q33k=; b=GcrbSBOUDOR6jd7v+8Wctaxb/I5gORctXUuJI4wdx0B7qtm538qcDwhMqnp+wGxnHm 8jCw04NeZTqKS+oJ+iqXBD+g9zarMmeWBlVHOrBInJXgcW8rVBYwSoiXJ7/qrlIzBQEU U+U43TwDHfbcZRSOhs8pibPkFXAmcBJkytNBYI2BwNJ91o6uGCTY2Gw7iSW8eiOVCTYe g/CJhgXTxV6eGKD6EzNCVFBFyzVB22hcz4lGEsBjh4BjE8NMEsX7x+/9A0lkhxKfn9RN ghnAYr3klQjcwG6nBw9v78Ao0Pez6zXba17j1i51phx2d3z7758xygyiuw/89iNg5l2Y e3IQ== X-Gm-Message-State: APjAAAXOhvY9YltGhlFPpitpxmwCPmmwAQfytirvJy1jqmXsCKNE21nm qfE5EfZKw1h7Z5bBV9GLCNcaow== X-Google-Smtp-Source: APXvYqyNCklkEVENRexg11/lVsAZF67JMyMSJB9/s1vxBi0hQ6lOnAJ1HSWjhfQSwKh/52Z4A1/krA== X-Received: by 2002:a1c:3d07:: with SMTP id k7mr5986321wma.79.1576590377924; Tue, 17 Dec 2019 05:46:17 -0800 (PST) Received: from dell ([2.27.35.132]) by smtp.gmail.com with ESMTPSA id r15sm2967823wmh.21.2019.12.17.05.46.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 05:46:17 -0800 (PST) Date: Tue, 17 Dec 2019 13:46:17 +0000 From: Lee Jones To: Daniel Mack Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, broonie@kernel.org, lars@metafoo.de, pascal.huerst@gmail.com Subject: Re: [PATCH 06/10] mfd: Add core driver for AD242x A2B transceivers Message-ID: <20191217134617.GK18955@dell> References: <20191209183511.3576038-1-daniel@zonque.org> <20191209183511.3576038-8-daniel@zonque.org> <20191217133952.GJ18955@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191217133952.GJ18955@dell> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Tue, 17 Dec 2019, Lee Jones wrote: > On Mon, 09 Dec 2019, Daniel Mack wrote: > > > The core driver for these devices is split into several parts. > > > > The master node driver is an I2C client. It is responsible for > > bringing up the bus topology and discovering the slave nodes. > > This process requries some knowlegde of the slave node configuration > > to program the bus timings correctly, so the master drivers walks > > the tree of nodes in the devicetree. The slave driver handles platform > > devices that are instantiated by the master node driver after > > discovery has finished. > > > > Master nodes expose two addresses on the I2C bus, one (referred to as > > 'BASE' in the datasheet) for accessing registers on the transceiver > > node itself, and one (referred to as 'BUS') for accessing remote > > registers, either on the remote transceiver itself, or on I2C hardware > > connected to that remote transceiver, which then acts as a remote I2C > > bus master. > > > > In order to allow MFD sub-devices to be registered as children of > > either the master or any slave node, the details on how to access the > > registers are hidden behind a regmap config. A pointer to the regmap > > is then exposed in the struct shared with the sub-devices. > > > > The ad242x-bus driver is a simple proxy that occupies the BUS I2C > > address and which is referred to through a devicetree handle by the > > master driver. > > > > For the discovery process, the driver has to wait for an interrupt > > to occur. In case no interrupt is configured in DT, the driver falls > > back to interrupt polling. After the discovery phase is completed, > > interrupts are only needed for error handling and GPIO handling, > > both of which is not currenty implemented. > > > > Code common to both the master and the slave driver lives in > > 'ad242x-node.c'. > > > > Signed-off-by: Daniel Mack > > > > mfd > > ? > > > --- > > drivers/mfd/Kconfig | 11 + > > drivers/mfd/Makefile | 1 + > > drivers/mfd/ad242x-bus.c | 42 +++ > > drivers/mfd/ad242x-master.c | 611 ++++++++++++++++++++++++++++++++++++ > > drivers/mfd/ad242x-node.c | 262 ++++++++++++++++ > > drivers/mfd/ad242x-slave.c | 234 ++++++++++++++ > > include/linux/mfd/ad242x.h | 400 +++++++++++++++++++++++ > > This device, or at least the way it's been coded is batty! > > It's going to need a lot of massaging before being accepted. One thing I should mention upfront; there is too much code "doing things" in here for it to be an MFD. MFDs don't care about; syncs, slots, TDM, inverting lines, upstreams, downstreams, etc etc etc. Anything remotely technical or functional, the code that "does things" should be moved out to the relevant areas. In the case of this device, that's looking like one of the Audio related subsystems. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog