All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Crowe <mac@mcrowe.com>
To: ChenQi <Qi.Chen@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] multilib.conf: Ensure that RECIPE_SYSROOT is unchanged for native
Date: Tue, 17 Dec 2019 13:55:48 +0000	[thread overview]
Message-ID: <20191217135548.GA1639@mcrowe.com> (raw)
In-Reply-To: <0cfbd853-0ad2-e010-5ee6-6277be55db9b@windriver.com>

On Tuesday 17 December 2019 at 16:56:11 +0800, ChenQi wrote:
> On 12/17/2019 04:02 PM, Mike Crowe via Openembedded-core wrote:
> > Ensure that RECIPE_SYSROOT is the same for -native recipes whether
> > multilib.conf is included or not.
> > 
> > Without this change task signatures for -native recipes change when
> > switching between MACHINEs that require multilib.conf and those that
> > don't.
> > 
> > This fix was one of the ones suggested by Khem Raj in
> > http://lists.openembedded.org/pipermail/openembedded-core/2019-December/290303.html
> > 
> > Add test_sstate_multilib_or_not_native_samesigs test case to
> > sstatetests.py to ensure that this stays fixed.
> > 
> > Signed-off-by: Mike Crowe <mac@mcrowe.com>
> > ---
> >   meta/conf/multilib.conf                     |  1 +
> >   meta/lib/oeqa/selftest/cases/sstatetests.py | 40 +++++++++++++++++++++
> >   2 files changed, 41 insertions(+)
> > 
> > diff --git a/meta/conf/multilib.conf b/meta/conf/multilib.conf
> > index cfed3fbbd0..58f2ac5c86 100644
> > --- a/meta/conf/multilib.conf
> > +++ b/meta/conf/multilib.conf
> > @@ -9,6 +9,7 @@ MULTILIBS ??= "multilib:lib32"
> >   STAGING_DIR_HOST = "${WORKDIR}/${MLPREFIX}recipe-sysroot"
> >   STAGING_DIR_TARGET = "${WORKDIR}/${MLPREFIX}recipe-sysroot"
> >   RECIPE_SYSROOT = "${WORKDIR}/${MLPREFIX}recipe-sysroot"
> > +RECIPE_SYSROOT_class-native = "${WORKDIR}/recipe-sysroot"
> 
> How about just removing MLPREFIX?

I'm afraid that I don't understand what you are suggesting. The above
change does remove MLPREFIX for -native only.

Thanks.

Mike.


  reply	other threads:[~2019-12-17 13:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17  8:02 [PATCH] multilib.conf: Ensure that RECIPE_SYSROOT is unchanged for native Mike Crowe
2019-12-17  8:56 ` ChenQi
2019-12-17 13:55   ` Mike Crowe [this message]
2019-12-18  1:19     ` ChenQi
2019-12-18 11:43       ` Mike Crowe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191217135548.GA1639@mcrowe.com \
    --to=mac@mcrowe.com \
    --cc=Qi.Chen@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.