From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF9A6C2D0CD for ; Tue, 17 Dec 2019 18:46:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DDDD2082E for ; Tue, 17 Dec 2019 18:46:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576608372; bh=8cTPAJdBPTsQ48Rtaj+AtGz744Volp3zu/XplimkmTE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1M1BJknbFxX2HDR4q6WO9LZzM9W0haUhX9EFq4i7qUWOhakkFK2Ip0qRpsTBRXrs+ sZxiAt5px2MwHjt+Hxn6zkcf/geG0QTig3XBo0eIbFTwc+gqYyoRjv8iqKLVWxUr3l 3nu9lkut0mFf6DWkZg2e9Kntk797XR+YsnFK864g= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727869AbfLQSqM (ORCPT ); Tue, 17 Dec 2019 13:46:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:38606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726742AbfLQSqL (ORCPT ); Tue, 17 Dec 2019 13:46:11 -0500 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C688F20733; Tue, 17 Dec 2019 18:46:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576608371; bh=8cTPAJdBPTsQ48Rtaj+AtGz744Volp3zu/XplimkmTE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KV14Yv630RBT6HY1Vbkz5YQvSNEqJjx93wxbveUJ7sFbdN18dlV35lX+b5kH97ipO dG9UfTRb44j+7Rn9ArllKEA02K6y/8z19yUtuUC2v0qOl2v+ZfUOO83erVE5jlZxAF 1L+Z80x5fPIq1e7MX10MhAFpr00wPi6YErtj/Fk0= Date: Tue, 17 Dec 2019 10:46:09 -0800 From: Eric Biggers To: Sasha Levin Cc: linux-mtd@lists.infradead.org, Richard Weinberger , linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, stable@vger.kernel.org, Hou Tao Subject: Re: [PATCH 1/2] ubifs: fix FS_IOC_SETFLAGS unexpectedly clearing encrypt flag Message-ID: <20191217184608.GB89165@gmail.com> References: <20191209222325.95656-2-ebiggers@kernel.org> <20191216150636.0511E2072D@mail.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191216150636.0511E2072D@mail.kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-fscrypt-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org On Mon, Dec 16, 2019 at 03:06:35PM +0000, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: d475a507457b ("ubifs: Add skeleton for fscrypto"). > > The bot has tested the following trees: v5.4.2, v5.3.15, v4.19.88, v4.14.158. > > v5.4.2: Build OK! > v5.3.15: Build OK! > v4.19.88: Build failed! Errors: > fs/ubifs/ioctl.c:130:28: error: ‘UBIFS_SUPPORTED_IOCTL_FLAGS’ undeclared (first use in this function) > > v4.14.158: Build failed! Errors: > fs/ubifs/ioctl.c:127:28: error: ‘UBIFS_SUPPORTED_IOCTL_FLAGS’ undeclared (first use in this function) > > > NOTE: The patch will not be queued to stable trees until it is upstream. > > How should we proceed with this patch? > 4.19 and 4.14 will build if you apply commit 2fe8b2d5578d ("ubifs: Reject unsupported ioctl flags explicitly") first. That was a bug fix too, so I recommend applying it. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,FSL_HELO_FAKE,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08406C43603 for ; Tue, 17 Dec 2019 18:46:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF6E72082E for ; Tue, 17 Dec 2019 18:46:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cCz22XKk"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="KV14Yv63" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF6E72082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X2lJ9TSmeUr7lbCf7qLgKp5xTEkvwRzUtt5BPMAf9FE=; b=cCz22XKkzEUZBe xVN3j9JLpN+Y0wSJsiBhCsY/YlKdJHZzWIunfpxYt40RGrwDwIqbCnpmtw7DHPmGRgUY46wBg+P49 5X/Q+FNcXbj7zGW6J2hxCy9+XChWKjIDXcX0s9yX/MsNbMmTGt6kqEmFWnkQfNKf834FkRLkhdaum wnAJDr9j4idHmb20ykyhNg4mw6sQv+v0RP26qBvvkAHMZVjrMiXMpp/R6eIlj1Lnt1UVQMvr9nc2V lTSuYc4xxCkZi6/b+nh2GbzdlKE+Pe8hrRVm/WRTKFbP+kKjIpMRRi9eunPP+tYwxl6h2EHsioWWz XArOkZzhSNGs4JWTE3yw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihHrN-0000AO-6x; Tue, 17 Dec 2019 18:46:17 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihHrK-0008Sq-NG for linux-mtd@lists.infradead.org; Tue, 17 Dec 2019 18:46:15 +0000 Received: from gmail.com (unknown [104.132.1.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C688F20733; Tue, 17 Dec 2019 18:46:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576608371; bh=8cTPAJdBPTsQ48Rtaj+AtGz744Volp3zu/XplimkmTE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KV14Yv630RBT6HY1Vbkz5YQvSNEqJjx93wxbveUJ7sFbdN18dlV35lX+b5kH97ipO dG9UfTRb44j+7Rn9ArllKEA02K6y/8z19yUtuUC2v0qOl2v+ZfUOO83erVE5jlZxAF 1L+Z80x5fPIq1e7MX10MhAFpr00wPi6YErtj/Fk0= Date: Tue, 17 Dec 2019 10:46:09 -0800 From: Eric Biggers To: Sasha Levin Subject: Re: [PATCH 1/2] ubifs: fix FS_IOC_SETFLAGS unexpectedly clearing encrypt flag Message-ID: <20191217184608.GB89165@gmail.com> References: <20191209222325.95656-2-ebiggers@kernel.org> <20191216150636.0511E2072D@mail.kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191216150636.0511E2072D@mail.kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191217_104614_780995_CBE0DB4B X-CRM114-Status: GOOD ( 12.03 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Weinberger , stable@vger.kernel.org, linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org, Hou Tao , linux-fsdevel@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gTW9uLCBEZWMgMTYsIDIwMTkgYXQgMDM6MDY6MzVQTSArMDAwMCwgU2FzaGEgTGV2aW4gd3Jv dGU6Cj4gSGksCj4gCj4gW1RoaXMgaXMgYW4gYXV0b21hdGVkIGVtYWlsXQo+IAo+IFRoaXMgY29t bWl0IGhhcyBiZWVuIHByb2Nlc3NlZCBiZWNhdXNlIGl0IGNvbnRhaW5zIGEgIkZpeGVzOiIgdGFn LAo+IGZpeGluZyBjb21taXQ6IGQ0NzVhNTA3NDU3YiAoInViaWZzOiBBZGQgc2tlbGV0b24gZm9y IGZzY3J5cHRvIikuCj4gCj4gVGhlIGJvdCBoYXMgdGVzdGVkIHRoZSBmb2xsb3dpbmcgdHJlZXM6 IHY1LjQuMiwgdjUuMy4xNSwgdjQuMTkuODgsIHY0LjE0LjE1OC4KPiAKPiB2NS40LjI6IEJ1aWxk IE9LIQo+IHY1LjMuMTU6IEJ1aWxkIE9LIQo+IHY0LjE5Ljg4OiBCdWlsZCBmYWlsZWQhIEVycm9y czoKPiAgICAgZnMvdWJpZnMvaW9jdGwuYzoxMzA6Mjg6IGVycm9yOiDigJhVQklGU19TVVBQT1JU RURfSU9DVExfRkxBR1PigJkgdW5kZWNsYXJlZCAoZmlyc3QgdXNlIGluIHRoaXMgZnVuY3Rpb24p Cj4gCj4gdjQuMTQuMTU4OiBCdWlsZCBmYWlsZWQhIEVycm9yczoKPiAgICAgZnMvdWJpZnMvaW9j dGwuYzoxMjc6Mjg6IGVycm9yOiDigJhVQklGU19TVVBQT1JURURfSU9DVExfRkxBR1PigJkgdW5k ZWNsYXJlZCAoZmlyc3QgdXNlIGluIHRoaXMgZnVuY3Rpb24pCj4gCj4gCj4gTk9URTogVGhlIHBh dGNoIHdpbGwgbm90IGJlIHF1ZXVlZCB0byBzdGFibGUgdHJlZXMgdW50aWwgaXQgaXMgdXBzdHJl YW0uCj4gCj4gSG93IHNob3VsZCB3ZSBwcm9jZWVkIHdpdGggdGhpcyBwYXRjaD8KPiAKCjQuMTkg YW5kIDQuMTQgd2lsbCBidWlsZCBpZiB5b3UgYXBwbHkgY29tbWl0IDJmZThiMmQ1NTc4ZAooInVi aWZzOiBSZWplY3QgdW5zdXBwb3J0ZWQgaW9jdGwgZmxhZ3MgZXhwbGljaXRseSIpIGZpcnN0LgpU aGF0IHdhcyBhIGJ1ZyBmaXggdG9vLCBzbyBJIHJlY29tbWVuZCBhcHBseWluZyBpdC4KCi0gRXJp YwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CkxpbnV4IE1URCBkaXNjdXNzaW9uIG1haWxpbmcgbGlzdApodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LW10ZC8K