From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 02/12] package/pkg-utils.mk: add extractor-pkg-dependency macro
Date: Tue, 17 Dec 2019 21:49:05 +0100 [thread overview]
Message-ID: <20191217204905.GA4247@scaer> (raw)
In-Reply-To: <20191214224208.3f2d382c@windsurf.home>
Thomas, Romain, All,
On 2019-12-14 22:42 +0100, Thomas Petazzoni spake thusly:
> On Sat, 14 Dec 2019 22:20:21 +0100
> Romain Naour <romain.naour@smile.fr> wrote:
>
> > > diff --git a/package/pkg-utils.mk b/package/pkg-utils.mk
> > > index 0f916d81d8..35a441e0aa 100644
> > > --- a/package/pkg-utils.mk
> > > +++ b/package/pkg-utils.mk
> > > @@ -46,6 +46,14 @@ INFLATE.tar = cat
> > > # suitable-extractor(filename): returns extractor based on suffix
> > > suitable-extractor = $(INFLATE$(suffix $(1)))
> > >
> >
> > What about gzip ?
> >
> > EXTRACTOR_PKG_DEPENDENCY.gz = $(BR2_GZIP_HOST_DEPENDENCY)
> > EXTRACTOR_PKG_DEPENDENCY.tgz = $(BR2_GZIP_HOST_DEPENDENCY)
>
> Because oddly enough, we are today not taking into account the
> dependency on gzip when extracting tarballs.
>
> We do take it into account only in:
>
> ifneq ($$(filter cvs git svn,$$($(2)_SITE_METHOD)),)
> $(2)_DOWNLOAD_DEPENDENCIES += \
> $(BR2_GZIP_HOST_DEPENDENCY) \
> $(BR2_TAR_HOST_DEPENDENCY)
> endif
>
> i.e, when we fetch from a version control system, and create our own
> tarball locally.
>
> But if we download directly from http/ftp a .tar.gz or .tgz, we don't
> rely on BR2_GZIP_HOST_DEPENDENCY, and simply assume we can use the one
> from the host machine.
>
> This should be fixed, I agree, but it's already broken today I believe.
In fact no. We need to build our own host-gzip only to create archives,
because some host have pigz instead of gzip, and this creates
non-reproducible archives.
However, decompressing with gzip or pigz is exactly the same; we do not
need our own host-gzip, and we can rely on the system-provided gzip,
whether that be gzip of pigz.
So, the current state of affairs is, AFAICS, correct.
Regards,
Yann E. MORIN.
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-12-17 20:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 21:59 [Buildroot] [PATCH 00/12] Ensure extractor dependencies are taken into account Thomas Petazzoni
2019-12-10 21:59 ` [Buildroot] [PATCH 01/12] package/pkg-utils.mk: rename extractor-dependency to extractor-system-dependency Thomas Petazzoni
2019-12-14 21:12 ` Romain Naour
2019-12-10 21:59 ` [Buildroot] [PATCH 02/12] package/pkg-utils.mk: add extractor-pkg-dependency macro Thomas Petazzoni
2019-12-14 21:20 ` Romain Naour
2019-12-14 21:42 ` Thomas Petazzoni
2019-12-17 20:49 ` Yann E. MORIN [this message]
2019-12-10 21:59 ` [Buildroot] [PATCH 03/12] package/pkg-utils.mk: rework implementation of extractor-system-dependency Thomas Petazzoni
2019-12-14 21:37 ` Romain Naour
2019-12-14 21:43 ` Thomas Petazzoni
2019-12-14 21:45 ` Yann E. MORIN
2019-12-14 21:53 ` Romain Naour
2019-12-10 21:59 ` [Buildroot] [PATCH 04/12] package/pkg-generic.mk: use extractor-pkg-dependency macro Thomas Petazzoni
2019-12-14 21:55 ` Romain Naour
2019-12-10 21:59 ` [Buildroot] [PATCH 05/12] arch/arch.mk.xtensa: fix usage of arch-xtensa-overlay-extract Thomas Petazzoni
2019-12-10 22:09 ` Max Filippov
2019-12-10 21:59 ` [Buildroot] [PATCH 06/12] package/android-tools: add missing extract dependencies Thomas Petazzoni
2019-12-10 21:59 ` [Buildroot] [PATCH 07/12] package/cargo: " Thomas Petazzoni
2019-12-10 21:59 ` [Buildroot] [PATCH 08/12] package/gettext-tiny: " Thomas Petazzoni
2019-12-10 21:59 ` [Buildroot] [PATCH 09/12] package/murata-cyw-fw: " Thomas Petazzoni
2019-12-10 21:59 ` [Buildroot] [PATCH 10/12] package/nvidia-tegra23/nvidia-tegra32-binaries: " Thomas Petazzoni
2019-12-10 21:59 ` [Buildroot] [PATCH 11/12] package/perl: " Thomas Petazzoni
2019-12-10 21:59 ` [Buildroot] [PATCH 12/12] package/rust-bin: " Thomas Petazzoni
2019-12-14 22:10 ` [Buildroot] [PATCH 00/12] Ensure extractor dependencies are taken into account Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191217204905.GA4247@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.