From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0372C2D0CD for ; Tue, 17 Dec 2019 20:57:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BD30C206D8 for ; Tue, 17 Dec 2019 20:57:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BD30C206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 22D3F6E13F; Tue, 17 Dec 2019 20:57:25 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 233BE6E139; Tue, 17 Dec 2019 20:57:23 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2019 12:57:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,326,1571727600"; d="scan'208";a="212500089" Received: from labuser-z97x-ud5h.jf.intel.com (HELO intel.com) ([10.54.75.49]) by fmsmga007.fm.intel.com with ESMTP; 17 Dec 2019 12:57:21 -0800 Date: Tue, 17 Dec 2019 12:58:53 -0800 From: Manasi Navare To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/2] drm: Handle connector tile support only for modes that match tile size Message-ID: <20191217205852.GB24921@intel.com> References: <20191211212433.18185-1-manasi.d.navare@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191211212433.18185-1-manasi.d.navare@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , Dave Airlie Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Dec 11, 2019 at 01:24:32PM -0800, Manasi Navare wrote: > DRM Fb driver expects multiple CRTCs if it sees connector->has_tile > is set, but we need to handle tile support and look for multiple CRTCs > only for the modes that match the tile size. The other modes should > be able to be displayed without tile support or uisng single CRTC. > = > This patch adds the check to match the tile size with requested mode > to handle the tile support. > = > Cc: Ville Syrj=E4l=E4 > Cc: Maarten Lankhorst > Cc: Jani Nikula > Cc: Dave Airlie > Signed-off-by: Manasi Navare Capturing Dave Airlie's r-b from IRC: Reviewed-by: Dave Airlie Manasi > --- > drivers/gpu/drm/drm_fb_helper.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_hel= per.c > index fb9bff0f4581..4978363714a9 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -1558,7 +1558,9 @@ static int drm_fb_helper_single_fb_probe(struct drm= _fb_helper *fb_helper, > for (j =3D 0; j < mode_set->num_connectors; j++) { > struct drm_connector *connector =3D mode_set->connectors[j]; > = > - if (connector->has_tile) { > + if (connector->has_tile && > + desired_mode->hdisplay =3D=3D connector->tile_h_size && > + desired_mode->vdisplay =3D=3D connector->tile_v_size) { > lasth =3D (connector->tile_h_loc =3D=3D (connector->num_h_tile - 1)); > lastv =3D (connector->tile_v_loc =3D=3D (connector->num_v_tile - 1)); > /* cloning to multiple tiles is just crazy-talk, so: */ > -- = > 2.19.1 > = _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27BF1C43603 for ; Tue, 17 Dec 2019 20:57:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01A5521582 for ; Tue, 17 Dec 2019 20:57:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01A5521582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 84D406E139; Tue, 17 Dec 2019 20:57:24 +0000 (UTC) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 233BE6E139; Tue, 17 Dec 2019 20:57:23 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Dec 2019 12:57:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,326,1571727600"; d="scan'208";a="212500089" Received: from labuser-z97x-ud5h.jf.intel.com (HELO intel.com) ([10.54.75.49]) by fmsmga007.fm.intel.com with ESMTP; 17 Dec 2019 12:57:21 -0800 Date: Tue, 17 Dec 2019 12:58:53 -0800 From: Manasi Navare To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Message-ID: <20191217205852.GB24921@intel.com> References: <20191211212433.18185-1-manasi.d.navare@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191211212433.18185-1-manasi.d.navare@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [Intel-gfx] [PATCH 1/2] drm: Handle connector tile support only for modes that match tile size X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , Dave Airlie Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Dec 11, 2019 at 01:24:32PM -0800, Manasi Navare wrote: > DRM Fb driver expects multiple CRTCs if it sees connector->has_tile > is set, but we need to handle tile support and look for multiple CRTCs > only for the modes that match the tile size. The other modes should > be able to be displayed without tile support or uisng single CRTC. > = > This patch adds the check to match the tile size with requested mode > to handle the tile support. > = > Cc: Ville Syrj=E4l=E4 > Cc: Maarten Lankhorst > Cc: Jani Nikula > Cc: Dave Airlie > Signed-off-by: Manasi Navare Capturing Dave Airlie's r-b from IRC: Reviewed-by: Dave Airlie Manasi > --- > drivers/gpu/drm/drm_fb_helper.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_hel= per.c > index fb9bff0f4581..4978363714a9 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -1558,7 +1558,9 @@ static int drm_fb_helper_single_fb_probe(struct drm= _fb_helper *fb_helper, > for (j =3D 0; j < mode_set->num_connectors; j++) { > struct drm_connector *connector =3D mode_set->connectors[j]; > = > - if (connector->has_tile) { > + if (connector->has_tile && > + desired_mode->hdisplay =3D=3D connector->tile_h_size && > + desired_mode->vdisplay =3D=3D connector->tile_v_size) { > lasth =3D (connector->tile_h_loc =3D=3D (connector->num_h_tile - 1)); > lastv =3D (connector->tile_v_loc =3D=3D (connector->num_v_tile - 1)); > /* cloning to multiple tiles is just crazy-talk, so: */ > -- = > 2.19.1 > = _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx