From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F00EFC43603 for ; Wed, 18 Dec 2019 00:03:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CD06C21835 for ; Wed, 18 Dec 2019 00:03:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726296AbfLRADT (ORCPT ); Tue, 17 Dec 2019 19:03:19 -0500 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:33526 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbfLRADT (ORCPT ); Tue, 17 Dec 2019 19:03:19 -0500 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1ihMo7-0003Wp-9q; Wed, 18 Dec 2019 01:03:15 +0100 Date: Wed, 18 Dec 2019 01:03:15 +0100 From: Florian Westphal To: Phil Sutter Cc: Pablo Neira Ayuso , netfilter-devel@vger.kernel.org, =?iso-8859-15?Q?M=E1t=E9?= Eckl Subject: Re: [nf PATCH] netfilter: nft_tproxy: Fix port selector on Big Endian Message-ID: <20191218000315.GY795@breakpoint.cc> References: <20191217235929.32555-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191217235929.32555-1-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netfilter-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Phil Sutter wrote: > On Big Endian architectures, u16 port value was extracted from the wrong > parts of u32 sreg_port, just like commit 10596608c4d62 ("netfilter: > nf_tables: fix mismatch in big-endian system") describes. I was about to debug this today, thanks for debugging/fixing this. Acked-by: Florian Westphal