From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Chenxu Di <chenxux.di@intel.com>
Cc: dev@dpdk.org, Yang Qiming <qiming.yang@intel.com>, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix port close in FreeBSD
Date: Wed, 18 Dec 2019 10:08:32 +0800 [thread overview]
Message-ID: <20191218020832.GL59123@intel.com> (raw)
In-Reply-To: <20191211090603.62152-1-chenxux.di@intel.com>
On 12/11, Chenxu Di wrote:
>FreeBSD OS doesn't support igb_uio interrupt, so it will fail when
>unregister the interrupt callback in port close. We can fix the issue by
>passing -ENOENT when check the return value of unregister interrupt
>callback function.
>
>Fixes: ac89d46096d5 ("net/i40e: release port upon close")
>Cc: stable@dpdk.org
>
>Signed-off-by: Chenxu Di <chenxux.di@intel.com>
>---
> drivers/net/i40e/i40e_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>index 5999c964b..8b2500391 100644
>--- a/drivers/net/i40e/i40e_ethdev.c
>+++ b/drivers/net/i40e/i40e_ethdev.c
>@@ -2594,7 +2594,7 @@ i40e_dev_close(struct rte_eth_dev *dev)
> do {
> ret = rte_intr_callback_unregister(intr_handle,
> i40e_dev_interrupt_handler, dev);
>- if (ret >= 0) {
>+ if (ret >= 0 || ret == -ENOENT) {
> break;
> } else if (ret != -EAGAIN) {
> PMD_INIT_LOG(ERR,
>--
>2.17.1
>
Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel, Thanks.
prev parent reply other threads:[~2019-12-18 2:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 9:06 [dpdk-dev] [PATCH] net/i40e: fix port close in FreeBSD Chenxu Di
2019-12-18 2:08 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218020832.GL59123@intel.com \
--to=xiaolong.ye@intel.com \
--cc=chenxux.di@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.