From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Andrey Zhizhikin <andrey.z@gmail.com>,
ast@kernel.org, daniel@iogearbox.net, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, andriin@fb.com,
pmladek@suse.com, wangkefeng.wang@huawei.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org,
Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH] tools lib api fs: fix gcc9 compilation error
Date: Wed, 18 Dec 2019 13:40:43 +0900 [thread overview]
Message-ID: <20191218044043.GB88635@google.com> (raw)
In-Reply-To: <20191218031019.GB419@tigerII.localdomain>
On (19/12/18 12:10), Sergey Senozhatsky wrote:
> On (19/12/11 08:01), Andrey Zhizhikin wrote:
> [..]
> > @@ -210,6 +210,7 @@ static bool fs__env_override(struct fs *fs)
> > size_t name_len = strlen(fs->name);
> > /* name + "_PATH" + '\0' */
> > char upper_name[name_len + 5 + 1];
> > +
> > memcpy(upper_name, fs->name, name_len);
> > mem_toupper(upper_name, name_len);
> > strcpy(&upper_name[name_len], "_PATH");
> > @@ -219,7 +220,8 @@ static bool fs__env_override(struct fs *fs)
> > return false;
> >
> > fs->found = true;
> > - strncpy(fs->path, override_path, sizeof(fs->path));
> > + strncpy(fs->path, override_path, sizeof(fs->path) - 1);
> > + fs->path[sizeof(fs->path) - 1] = '\0';
>
> I think the trend these days is to prefer stracpy/strscpy over
> strcpy/strlcpy/strncpy.
Scratch that. This is user-space, I should pay more attention.
-ss
next prev parent reply other threads:[~2019-12-18 4:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 8:01 [PATCH] tools lib api fs: fix gcc9 compilation error Andrey Zhizhikin
2019-12-17 21:21 ` Andrey Zhizhikin
2019-12-18 3:10 ` Sergey Senozhatsky
2019-12-18 4:40 ` Sergey Senozhatsky [this message]
2019-12-18 7:29 ` Jiri Olsa
2019-12-18 11:36 ` Petr Mladek
2019-12-18 14:33 ` Arnaldo Carvalho de Melo
2019-12-18 17:03 ` Andrey Zhizhikin
2020-01-10 17:53 ` [tip: perf/core] tools lib api fs: Fix gcc9 stringop-truncation " tip-bot2 for Andrey Zhizhikin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218044043.GB88635@google.com \
--to=sergey.senozhatsky.work@gmail.com \
--cc=acme@redhat.com \
--cc=andrey.z@gmail.com \
--cc=andrey.zhizhikin@leica-geosystems.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=songliubraving@fb.com \
--cc=wangkefeng.wang@huawei.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.