From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4A38C43603 for ; Wed, 18 Dec 2019 06:30:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99CD920717 for ; Wed, 18 Dec 2019 06:30:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eps94Qfo"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WVTTapXo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99CD920717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qbQHlojummgKhwmLQAcdIyh7Xa7nEXK/5YuYxZiAvmE=; b=eps94Qfo/RW+RT kkCeqk4B21LCEYGHnE4p8iYuFPIzBvcSnflDt0olZQvPgMBdyM6e2tfLmGEqZjto0acE0V665m/Ih nBvnHsSKbCAHaljJdaK9ssOuEBdR7lkcJBnFmmAHheEhTdqroE4dhlnfVVIpXxb2pnFFSzwbPctbK i0q+Mb+B9erejxzeHT9khZ67z+jItUOzB88raOhi+cJw1T7FJ6LfeZIuZ26YNOW4/KANDorR2l2mF +pedjZLyXGkuNQxe3tglllstyGhS2d5hxRsxDcbj+/nFOxZD4NMIWPvt1voDN9q1YpeICg5TFsGgW 57D85/fVm5xYXpSkKNYg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihSqx-00047O-T9; Wed, 18 Dec 2019 06:30:35 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihSqu-00045n-DE for linux-amlogic@lists.infradead.org; Wed, 18 Dec 2019 06:30:35 +0000 Received: by mail-pf1-x441.google.com with SMTP id h14so627206pfe.10 for ; Tue, 17 Dec 2019 22:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QUqCKPDBExCLLAwVtzgi61MYbDhx2OZCOHrZup6vycw=; b=WVTTapXo9831RocflUB0ikHKFJuh9iAvfg6my6hM4pUeSOGR+cnsYT1tCVdopTiQHg a9iyF7SBYSz9UrCG2ZhM5bNW2gpuyr4iZK+AREwohsVYFPGEm3aJRxhiJoNKRvDCWBHH 4E9e9gsfZo2EyGyj4UVSpFyMPwZKH/MGKHkN/6w3Dc+ayTlnFZSl8dy9UlJEuimtMebw hR1PyhRC8cTn/D+OJt/V/RKflu+iF9f35hC5f/4d3DJNrgZ6hbymq2gc7V/5oso7HO6F xqeBCMVDMd5B6szz4pJ9wsJuj00hJjcZf+ZH3dqw1+1/63XOgvTlvCVrQzT4/Etad3w1 4QYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QUqCKPDBExCLLAwVtzgi61MYbDhx2OZCOHrZup6vycw=; b=JdJFnd5GBMeM+UhMzWlhlFf/s1X74iPN1nvztMWf55BL7H+Hcmh3XHyOPGXTsR/GLB 5CLo1IZ9qZEgnhwQ3lu34CPdObjOm520o08VPPELsSkn7oIgyKxnMYwWOCzmFIZRARQL xtxvpo9NajchSkYfWQQw8OGBvuXEP4w4ZVnFaltuGZ+9D04pmCV3WPfEvv9vUgSAwcNE WAK7hBMfFBzb8fQzPvMhCM274biAhjjMrTaORMTAYljwyNBoRhg4hnOIuCZYVbmFHDQj pSmsO0SiQM6XeRm6+/D0ngIbELs+KGXv5YQ/9LZktUKK7uywHAq7j/X9STnwK1ZmiPjY N21Q== X-Gm-Message-State: APjAAAVCu/a70rDOU0sSHFyt0Ykj8GGfmsTWG41Y+WM/LhLtziTkXJWV cncMf8ZCFOE6YwMAYb6GbaKl4g== X-Google-Smtp-Source: APXvYqzIvX0pWBlNmYdcCxRQD7mXEfg6Upgu8h5ATMfO9O8MRrkIOt+XJa8qeUETe/PDXbEwm9iagA== X-Received: by 2002:aa7:848c:: with SMTP id u12mr1237038pfn.12.1576650631883; Tue, 17 Dec 2019 22:30:31 -0800 (PST) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id p5sm1253789pgs.28.2019.12.17.22.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 22:30:31 -0800 (PST) Date: Tue, 17 Dec 2019 22:30:28 -0800 From: Bjorn Andersson To: Yangtao Li Subject: Re: [PATCH 10/13] mmc: sdhci-msm: convert to devm_platform_ioremap_resource Message-ID: <20191218063028.GC3755841@builder> References: <20191215175120.3290-1-tiny.windzz@gmail.com> <20191215175120.3290-10-tiny.windzz@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191215175120.3290-10-tiny.windzz@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191217_223033_613250_CFAF5C30 X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kstewart@linuxfoundation.org, ulf.hansson@linaro.org, geert+renesas@glider.be, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com, khilman@baylibre.com, jh80.chung@samsung.com, wens@csie.org, agross@kernel.org, chaotian.jing@mediatek.com, linux-arm-msm@vger.kernel.org, wsa+renesas@sang-engineering.com, mripard@kernel.org, linux-mediatek@lists.infradead.org, ben-linux@fluff.org, matthias.bgg@gmail.com, linux-amlogic@lists.infradead.org, tglx@linutronix.de, allison@lohutok.net, linux-arm-kernel@lists.infradead.org, nico@fluxnic.net, gregkh@linuxfoundation.org, yoshihiro.shimoda.uh@renesas.com, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, vireshk@kernel.org, manuel.lauss@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sun 15 Dec 09:51 PST 2019, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/mmc/host/sdhci-msm.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index 3d0bb5e2e09b..6daacef4ceec 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -1746,7 +1746,6 @@ static int sdhci_msm_probe(struct platform_device *pdev) > struct sdhci_host *host; > struct sdhci_pltfm_host *pltfm_host; > struct sdhci_msm_host *msm_host; > - struct resource *core_memres; > struct clk *clk; > int ret; > u16 host_version, core_minor; > @@ -1847,9 +1846,7 @@ static int sdhci_msm_probe(struct platform_device *pdev) > } > > if (!msm_host->mci_removed) { > - core_memres = platform_get_resource(pdev, IORESOURCE_MEM, 1); > - msm_host->core_mem = devm_ioremap_resource(&pdev->dev, > - core_memres); > + msm_host->core_mem = devm_platform_ioremap_resource(pdev, 1); > This would now look better without this empty line. Reviewed-by: Bjorn Andersson Regards, Bjorn > if (IS_ERR(msm_host->core_mem)) { > ret = PTR_ERR(msm_host->core_mem); > -- > 2.17.1 > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA18BC43603 for ; Wed, 18 Dec 2019 06:30:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91A6321D7D for ; Wed, 18 Dec 2019 06:30:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WVTTapXo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726497AbfLRGac (ORCPT ); Wed, 18 Dec 2019 01:30:32 -0500 Received: from mail-pf1-f193.google.com ([209.85.210.193]:46993 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbfLRGac (ORCPT ); Wed, 18 Dec 2019 01:30:32 -0500 Received: by mail-pf1-f193.google.com with SMTP id y14so623808pfm.13 for ; Tue, 17 Dec 2019 22:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QUqCKPDBExCLLAwVtzgi61MYbDhx2OZCOHrZup6vycw=; b=WVTTapXo9831RocflUB0ikHKFJuh9iAvfg6my6hM4pUeSOGR+cnsYT1tCVdopTiQHg a9iyF7SBYSz9UrCG2ZhM5bNW2gpuyr4iZK+AREwohsVYFPGEm3aJRxhiJoNKRvDCWBHH 4E9e9gsfZo2EyGyj4UVSpFyMPwZKH/MGKHkN/6w3Dc+ayTlnFZSl8dy9UlJEuimtMebw hR1PyhRC8cTn/D+OJt/V/RKflu+iF9f35hC5f/4d3DJNrgZ6hbymq2gc7V/5oso7HO6F xqeBCMVDMd5B6szz4pJ9wsJuj00hJjcZf+ZH3dqw1+1/63XOgvTlvCVrQzT4/Etad3w1 4QYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QUqCKPDBExCLLAwVtzgi61MYbDhx2OZCOHrZup6vycw=; b=PANAKoAki+GreVHs7D9WMXnGvgU9fPD6q5SCtKaF3hvEaG7GFX41uOdt7NoDit1/A0 SjmlCuZfIataJeF7VY2++Piz8dtw7cBBBsfUHc5+kmwzrLqWzXYW2mOtwfpOeRYVLkAs 36LvruVWtDZC4aaO/W/jeMj23ZePqJicVJotLVTkR6vkrrQymr02rh9UKHOI9RZ80tM6 D12ZUkGl9SAW8EFef/oOIOHog2JSm+mqeOImKzuzhlm3agEnGEq4IByQsDLolZcVdRsl +rITtRjEW5OQWd6EF7L6teYizj9I4V9CJaBiwNXbVB5Ow0Sa8VMpKrMcjIiCj+U1AGXN pM0w== X-Gm-Message-State: APjAAAW7J2EBW8BElGN1nLQSK0/49VW6bQrz4mhpgbbc+6+Frkn8Ma3x cTv/gSx2rJ06Y4hsvJW3zl4veA== X-Google-Smtp-Source: APXvYqzIvX0pWBlNmYdcCxRQD7mXEfg6Upgu8h5ATMfO9O8MRrkIOt+XJa8qeUETe/PDXbEwm9iagA== X-Received: by 2002:aa7:848c:: with SMTP id u12mr1237038pfn.12.1576650631883; Tue, 17 Dec 2019 22:30:31 -0800 (PST) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id p5sm1253789pgs.28.2019.12.17.22.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 22:30:31 -0800 (PST) Date: Tue, 17 Dec 2019 22:30:28 -0800 From: Bjorn Andersson To: Yangtao Li Cc: manuel.lauss@gmail.com, ulf.hansson@linaro.org, khilman@baylibre.com, chaotian.jing@mediatek.com, matthias.bgg@gmail.com, nico@fluxnic.net, adrian.hunter@intel.com, agross@kernel.org, ben-linux@fluff.org, jh80.chung@samsung.com, vireshk@kernel.org, mripard@kernel.org, wens@csie.org, wsa+renesas@sang-engineering.com, gregkh@linuxfoundation.org, kstewart@linuxfoundation.org, yamada.masahiro@socionext.com, tglx@linutronix.de, allison@lohutok.net, yoshihiro.shimoda.uh@renesas.com, geert+renesas@glider.be, linus.walleij@linaro.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 10/13] mmc: sdhci-msm: convert to devm_platform_ioremap_resource Message-ID: <20191218063028.GC3755841@builder> References: <20191215175120.3290-1-tiny.windzz@gmail.com> <20191215175120.3290-10-tiny.windzz@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191215175120.3290-10-tiny.windzz@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sun 15 Dec 09:51 PST 2019, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/mmc/host/sdhci-msm.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index 3d0bb5e2e09b..6daacef4ceec 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -1746,7 +1746,6 @@ static int sdhci_msm_probe(struct platform_device *pdev) > struct sdhci_host *host; > struct sdhci_pltfm_host *pltfm_host; > struct sdhci_msm_host *msm_host; > - struct resource *core_memres; > struct clk *clk; > int ret; > u16 host_version, core_minor; > @@ -1847,9 +1846,7 @@ static int sdhci_msm_probe(struct platform_device *pdev) > } > > if (!msm_host->mci_removed) { > - core_memres = platform_get_resource(pdev, IORESOURCE_MEM, 1); > - msm_host->core_mem = devm_ioremap_resource(&pdev->dev, > - core_memres); > + msm_host->core_mem = devm_platform_ioremap_resource(pdev, 1); > This would now look better without this empty line. Reviewed-by: Bjorn Andersson Regards, Bjorn > if (IS_ERR(msm_host->core_mem)) { > ret = PTR_ERR(msm_host->core_mem); > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F16EC2D0CD for ; Wed, 18 Dec 2019 06:30:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E934220717 for ; Wed, 18 Dec 2019 06:30:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f3E3wDSc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WVTTapXo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E934220717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5Ak+6JzaXGRTasB3tiv+Rr4/JKWWU+Zc9X4a5I54yTM=; b=f3E3wDScfqgDvE O11+vEev/gVaEjMPjlhYnlED1n1O5h68AJN/ZUBzRY7hGYCCoi3OHSiHAmSIPQpvoCg97eQ79keE4 hFHs5uVSAUccZGf8jOK566D2k40D7QQLA23xoi3HRgePcsj7nQ6RNb2/PgZxrnhQygi0bEKXrlOoy WyS0a/U9+hEBGI2HxKKYzz+w3ESGYnARS8M/lie7DEneDPTwK0wFshNrLmaDAhohqX0Q88eaqa7id wL7tEq3zyfFAk8JHTZixEaH/K5nrAjSaRNn0pZRjADLKaYc8Py54AXG0EM8HrVZIsS/cMXP8RAGHQ SE7OaI4d5gKmmFXXMy1g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihSqy-000487-Hk; Wed, 18 Dec 2019 06:30:36 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihSqu-00045m-GD for linux-mediatek@lists.infradead.org; Wed, 18 Dec 2019 06:30:35 +0000 Received: by mail-pg1-x544.google.com with SMTP id k25so699036pgt.7 for ; Tue, 17 Dec 2019 22:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QUqCKPDBExCLLAwVtzgi61MYbDhx2OZCOHrZup6vycw=; b=WVTTapXo9831RocflUB0ikHKFJuh9iAvfg6my6hM4pUeSOGR+cnsYT1tCVdopTiQHg a9iyF7SBYSz9UrCG2ZhM5bNW2gpuyr4iZK+AREwohsVYFPGEm3aJRxhiJoNKRvDCWBHH 4E9e9gsfZo2EyGyj4UVSpFyMPwZKH/MGKHkN/6w3Dc+ayTlnFZSl8dy9UlJEuimtMebw hR1PyhRC8cTn/D+OJt/V/RKflu+iF9f35hC5f/4d3DJNrgZ6hbymq2gc7V/5oso7HO6F xqeBCMVDMd5B6szz4pJ9wsJuj00hJjcZf+ZH3dqw1+1/63XOgvTlvCVrQzT4/Etad3w1 4QYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QUqCKPDBExCLLAwVtzgi61MYbDhx2OZCOHrZup6vycw=; b=UfDrb6atKFXXf+ctzlFxO2MfyBggVem2+dIje7tXkEQuKbAloo4vS70CAHpGGcYefi rxxZBOQlb4AiwO7ZLYKx7cW0bK47W1UXGrBdWrF2zhxUWAC6qFE7XWgXViDb4N22M9XD bTO3BzXL4X86XQXWFdsmeg7ljsAmJVd3taj01PCMUMuGazTL8TMA42DM3xQ06V9Je47l pE3+CBRgIyGI4uASmrv1Xh16dRFdHiECZarbXseISyaujEknT3t2msKEheDsjvBctGdb pBm70m2wMPc3Po9iKItzMdzVo7T+KfaiB3NHHCzWkjdLYmNDBXH0vcnGNxh6rXrK4k/z JwxA== X-Gm-Message-State: APjAAAXROggpLVCQ8++pYGDeQnpNc6fHq3JHPnUJyxjNyK+UZ/g/g3Db Cb4pXEOKEpnHu3EwG2VNnxhGDg== X-Google-Smtp-Source: APXvYqzIvX0pWBlNmYdcCxRQD7mXEfg6Upgu8h5ATMfO9O8MRrkIOt+XJa8qeUETe/PDXbEwm9iagA== X-Received: by 2002:aa7:848c:: with SMTP id u12mr1237038pfn.12.1576650631883; Tue, 17 Dec 2019 22:30:31 -0800 (PST) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id p5sm1253789pgs.28.2019.12.17.22.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 22:30:31 -0800 (PST) Date: Tue, 17 Dec 2019 22:30:28 -0800 From: Bjorn Andersson To: Yangtao Li Subject: Re: [PATCH 10/13] mmc: sdhci-msm: convert to devm_platform_ioremap_resource Message-ID: <20191218063028.GC3755841@builder> References: <20191215175120.3290-1-tiny.windzz@gmail.com> <20191215175120.3290-10-tiny.windzz@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191215175120.3290-10-tiny.windzz@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191217_223033_613670_79C2033C X-CRM114-Status: GOOD ( 12.50 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kstewart@linuxfoundation.org, ulf.hansson@linaro.org, geert+renesas@glider.be, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com, khilman@baylibre.com, jh80.chung@samsung.com, wens@csie.org, agross@kernel.org, chaotian.jing@mediatek.com, linux-arm-msm@vger.kernel.org, wsa+renesas@sang-engineering.com, mripard@kernel.org, linux-mediatek@lists.infradead.org, ben-linux@fluff.org, matthias.bgg@gmail.com, linux-amlogic@lists.infradead.org, tglx@linutronix.de, allison@lohutok.net, linux-arm-kernel@lists.infradead.org, nico@fluxnic.net, gregkh@linuxfoundation.org, yoshihiro.shimoda.uh@renesas.com, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, vireshk@kernel.org, manuel.lauss@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Sun 15 Dec 09:51 PST 2019, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/mmc/host/sdhci-msm.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index 3d0bb5e2e09b..6daacef4ceec 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -1746,7 +1746,6 @@ static int sdhci_msm_probe(struct platform_device *pdev) > struct sdhci_host *host; > struct sdhci_pltfm_host *pltfm_host; > struct sdhci_msm_host *msm_host; > - struct resource *core_memres; > struct clk *clk; > int ret; > u16 host_version, core_minor; > @@ -1847,9 +1846,7 @@ static int sdhci_msm_probe(struct platform_device *pdev) > } > > if (!msm_host->mci_removed) { > - core_memres = platform_get_resource(pdev, IORESOURCE_MEM, 1); > - msm_host->core_mem = devm_ioremap_resource(&pdev->dev, > - core_memres); > + msm_host->core_mem = devm_platform_ioremap_resource(pdev, 1); > This would now look better without this empty line. Reviewed-by: Bjorn Andersson Regards, Bjorn > if (IS_ERR(msm_host->core_mem)) { > ret = PTR_ERR(msm_host->core_mem); > -- > 2.17.1 > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A73EC43603 for ; Wed, 18 Dec 2019 06:30:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBE4E20717 for ; Wed, 18 Dec 2019 06:30:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CuI8GouN"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WVTTapXo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBE4E20717 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S2zuxhswFltj77FNuB4Jeptal3J/BtXnckrUrHYruFA=; b=CuI8GouNaMVJhd uGEcpCJn409SQdu+B/il/yjUvXVVzgpKuwIPwYYwjpcyEnwwNm1gUM0lk+YoSh81I5FFA5Sslyanh cZsJUaqbMGS7VU1dNgbcW65iS8QsvZSJIpFvuH+n2v3rHfeMXul91NDKYW/eEd9PoNifVEwpQSRuY mB/k0g+vf+q13+tkNDVW9W6NCwrkz16ADq2Tth4uieArb/VP3hRs3zVFDbwH1mkweFP7DxrDFJwH0 Nkn+UrKkGTWl818phjAlNkQ/ceCT5Q51hpP9JsgMNAuAd6zVgc0n4obhd6lcfwr0heNfXMBtYH80A rmbO4lH9YfQ8Gy/c6Iqw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihSr0-00049x-Q9; Wed, 18 Dec 2019 06:30:38 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihSqu-00045l-DG for linux-arm-kernel@lists.infradead.org; Wed, 18 Dec 2019 06:30:36 +0000 Received: by mail-pf1-x441.google.com with SMTP id 2so624110pfg.12 for ; Tue, 17 Dec 2019 22:30:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=QUqCKPDBExCLLAwVtzgi61MYbDhx2OZCOHrZup6vycw=; b=WVTTapXo9831RocflUB0ikHKFJuh9iAvfg6my6hM4pUeSOGR+cnsYT1tCVdopTiQHg a9iyF7SBYSz9UrCG2ZhM5bNW2gpuyr4iZK+AREwohsVYFPGEm3aJRxhiJoNKRvDCWBHH 4E9e9gsfZo2EyGyj4UVSpFyMPwZKH/MGKHkN/6w3Dc+ayTlnFZSl8dy9UlJEuimtMebw hR1PyhRC8cTn/D+OJt/V/RKflu+iF9f35hC5f/4d3DJNrgZ6hbymq2gc7V/5oso7HO6F xqeBCMVDMd5B6szz4pJ9wsJuj00hJjcZf+ZH3dqw1+1/63XOgvTlvCVrQzT4/Etad3w1 4QYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=QUqCKPDBExCLLAwVtzgi61MYbDhx2OZCOHrZup6vycw=; b=k9HQLk068DqdpgRrorK69VuO/scnByDzVv3TokB4QPw9cJvoEHFde0UwWE791JQNcG n29uUiDz8Rcviw7ywhSxcmWgUlo3YVm9+JkDx8SQuKp1BaNXdGmBAY/qW1w4glS/97pQ OHn/6skIPoT04n5nwOt7FT+SdDlXNfpxJvNJB4oXfScfieIe0VtwEu7NfeRYx1bMko7/ SlPotnnx6uhbX6CIr9hHAjO6vjI6T2X4hjBx6HMduFTi0YOnIHencbNqcK42+yy8oW6K fjG/UxZkgEcqdUUML4HjGaywupid9LDlGpdWyywbLIHkCsWilHP7VYkyjS/zmnfngxIa CaCg== X-Gm-Message-State: APjAAAX06Ug7ifoyLapoTjYIEgYe1Vo1dkDuMWgMnxg57iVSsmxW7akQ n4FViXDi5uxfSrXxmdNnX5ZNYQ== X-Google-Smtp-Source: APXvYqzIvX0pWBlNmYdcCxRQD7mXEfg6Upgu8h5ATMfO9O8MRrkIOt+XJa8qeUETe/PDXbEwm9iagA== X-Received: by 2002:aa7:848c:: with SMTP id u12mr1237038pfn.12.1576650631883; Tue, 17 Dec 2019 22:30:31 -0800 (PST) Received: from builder (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id p5sm1253789pgs.28.2019.12.17.22.30.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 22:30:31 -0800 (PST) Date: Tue, 17 Dec 2019 22:30:28 -0800 From: Bjorn Andersson To: Yangtao Li Subject: Re: [PATCH 10/13] mmc: sdhci-msm: convert to devm_platform_ioremap_resource Message-ID: <20191218063028.GC3755841@builder> References: <20191215175120.3290-1-tiny.windzz@gmail.com> <20191215175120.3290-10-tiny.windzz@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191215175120.3290-10-tiny.windzz@gmail.com> User-Agent: Mutt/1.12.2 (2019-09-21) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191217_223033_614859_BB4733CB X-CRM114-Status: GOOD ( 14.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kstewart@linuxfoundation.org, ulf.hansson@linaro.org, geert+renesas@glider.be, linus.walleij@linaro.org, linux-kernel@vger.kernel.org, yamada.masahiro@socionext.com, khilman@baylibre.com, jh80.chung@samsung.com, wens@csie.org, agross@kernel.org, chaotian.jing@mediatek.com, linux-arm-msm@vger.kernel.org, wsa+renesas@sang-engineering.com, mripard@kernel.org, linux-mediatek@lists.infradead.org, ben-linux@fluff.org, matthias.bgg@gmail.com, linux-amlogic@lists.infradead.org, tglx@linutronix.de, allison@lohutok.net, linux-arm-kernel@lists.infradead.org, nico@fluxnic.net, gregkh@linuxfoundation.org, yoshihiro.shimoda.uh@renesas.com, linux-mmc@vger.kernel.org, adrian.hunter@intel.com, vireshk@kernel.org, manuel.lauss@gmail.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun 15 Dec 09:51 PST 2019, Yangtao Li wrote: > Use devm_platform_ioremap_resource() to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/mmc/host/sdhci-msm.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > index 3d0bb5e2e09b..6daacef4ceec 100644 > --- a/drivers/mmc/host/sdhci-msm.c > +++ b/drivers/mmc/host/sdhci-msm.c > @@ -1746,7 +1746,6 @@ static int sdhci_msm_probe(struct platform_device *pdev) > struct sdhci_host *host; > struct sdhci_pltfm_host *pltfm_host; > struct sdhci_msm_host *msm_host; > - struct resource *core_memres; > struct clk *clk; > int ret; > u16 host_version, core_minor; > @@ -1847,9 +1846,7 @@ static int sdhci_msm_probe(struct platform_device *pdev) > } > > if (!msm_host->mci_removed) { > - core_memres = platform_get_resource(pdev, IORESOURCE_MEM, 1); > - msm_host->core_mem = devm_ioremap_resource(&pdev->dev, > - core_memres); > + msm_host->core_mem = devm_platform_ioremap_resource(pdev, 1); > This would now look better without this empty line. Reviewed-by: Bjorn Andersson Regards, Bjorn > if (IS_ERR(msm_host->core_mem)) { > ret = PTR_ERR(msm_host->core_mem); > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel