From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Kent Gibson <warthog618@gmail.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-gpio@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [libgpiod][PATCH 6/7] bindings: python: add a method for reading multiple line events
Date: Wed, 18 Dec 2019 15:24:48 +0100 [thread overview]
Message-ID: <20191218142449.10957-7-brgl@bgdev.pl> (raw)
In-Reply-To: <20191218142449.10957-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Add a new method to the Line class allowing to read up to 16 line
events at once.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
---
bindings/python/gpiodmodule.c | 57 +++++++++++++++++++++++++++++++++++
1 file changed, 57 insertions(+)
diff --git a/bindings/python/gpiodmodule.c b/bindings/python/gpiodmodule.c
index 27a8118..b0b52ee 100644
--- a/bindings/python/gpiodmodule.c
+++ b/bindings/python/gpiodmodule.c
@@ -850,6 +850,57 @@ static gpiod_LineEventObject *gpiod_Line_event_read(gpiod_LineObject *self,
return ret;
}
+PyDoc_STRVAR(gpiod_Line_event_read_multiple_doc,
+"event_read_multiple() -> list of gpiod.LineEvent object\n"
+"\n"
+"Read up to 16 line events from this GPIO line object.");
+
+static PyObject *gpiod_Line_event_read_multiple(gpiod_LineObject *self,
+ PyObject *Py_UNUSED(ignored))
+{
+ struct gpiod_line_event evbuf[16];
+ gpiod_LineEventObject *event;
+ int rv, num_events, i;
+ PyObject *events;
+
+ if (gpiod_ChipIsClosed(self->owner))
+ return NULL;
+
+ memset(evbuf, 0, sizeof(evbuf));
+ Py_BEGIN_ALLOW_THREADS;
+ num_events = gpiod_line_event_read_multiple(self->line, evbuf,
+ sizeof(evbuf) / sizeof(*evbuf));
+ Py_END_ALLOW_THREADS;
+ if (num_events < 0)
+ return PyErr_SetFromErrno(PyExc_OSError);
+
+ events = PyList_New(num_events);
+ if (!events)
+ return NULL;
+
+ for (i = 0; i < num_events; i++) {
+ event = PyObject_New(gpiod_LineEventObject,
+ &gpiod_LineEventType);
+ if (!event) {
+ Py_DECREF(events);
+ return NULL;
+ }
+
+ memcpy(&event->event, &evbuf[i], sizeof(event->event));
+ Py_INCREF(self);
+ event->source = self;
+
+ rv = PyList_SetItem(events, i, (PyObject *)event);
+ if (rv < 0) {
+ Py_DECREF(events);
+ Py_DECREF(event);
+ return NULL;
+ }
+ }
+
+ return events;
+}
+
PyDoc_STRVAR(gpiod_Line_event_get_fd_doc,
"event_get_fd() -> integer\n"
"\n"
@@ -1026,6 +1077,12 @@ static PyMethodDef gpiod_Line_methods[] = {
.ml_flags = METH_NOARGS,
.ml_doc = gpiod_Line_event_read_doc,
},
+ {
+ .ml_name = "event_read_multiple",
+ .ml_meth = (PyCFunction)gpiod_Line_event_read_multiple,
+ .ml_flags = METH_NOARGS,
+ .ml_doc = gpiod_Line_event_read_multiple_doc,
+ },
{
.ml_name = "event_get_fd",
.ml_meth = (PyCFunction)gpiod_Line_event_get_fd,
--
2.23.0
next prev parent reply other threads:[~2019-12-18 14:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 14:24 [libgpiod][PATCH 0/7] teach libgpiod to read multiple line events at once Bartosz Golaszewski
2019-12-18 14:24 ` [libgpiod][PATCH 1/7] core: use gpiod_line_event_get_fd() in gpiod_line_event_read() Bartosz Golaszewski
2019-12-18 14:24 ` [libgpiod][PATCH 2/7] core: provide functions for reading multiple line events at once Bartosz Golaszewski
2019-12-18 14:24 ` [libgpiod][PATCH 3/7] tests: event: extend test coverage " Bartosz Golaszewski
2019-12-19 13:35 ` Kent Gibson
2019-12-19 13:48 ` Bartosz Golaszewski
2019-12-19 14:05 ` Kent Gibson
2019-12-19 14:07 ` Bartosz Golaszewski
2019-12-19 14:36 ` Kent Gibson
2019-12-19 16:19 ` Bartosz Golaszewski
2019-12-24 12:11 ` Bartosz Golaszewski
2019-12-18 14:24 ` [libgpiod][PATCH 4/7] bindings: cxx: provide a method for reading multiple line events Bartosz Golaszewski
2019-12-18 14:24 ` [libgpiod][PATCH 5/7] bindings: cxx: tests: add a test-case " Bartosz Golaszewski
2019-12-18 14:24 ` Bartosz Golaszewski [this message]
2019-12-18 14:24 ` [libgpiod][PATCH 7/7] bindings: python: " Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218142449.10957-7-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.