From: Guenter Roeck <linux@roeck-us.net>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Henry Lin <henryl@nvidia.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] usb: xhci: Fix build warning seen with CONFIG_PM=n
Date: Wed, 18 Dec 2019 07:59:46 -0800 [thread overview]
Message-ID: <20191218155946.GA331@roeck-us.net> (raw)
In-Reply-To: <04cef5f6-2bc2-b056-d2c4-e79ba5498225@linux.intel.com>
On Wed, Dec 18, 2019 at 05:38:06PM +0200, Mathias Nyman wrote:
> On 18.12.2019 16.29, Greg Kroah-Hartman wrote:
> > On Tue, Dec 17, 2019 at 05:19:11PM -0800, Guenter Roeck wrote:
> > > The following build warning is seen if CONFIG_PM is disabled.
> > >
> > > drivers/usb/host/xhci-pci.c:498:13: warning:
> > > unused function 'xhci_pci_shutdown'
> > >
> > > Fixes: f2c710f7dca8 ("usb: xhci: only set D3hot for pci device")
> > > Cc: Henry Lin <henryl@nvidia.com>
> > > Cc: stable@vger.kernel.org # all stable releases with 2f23dc86c3f8
Somehow I messed up the commit sha here. It is f2c710f7dca8, obviously.
2f23dc86c3f8 is the sha from v4.19.y. Sorry for that.
Guenter
> > > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > > ---
> > > drivers/usb/host/xhci-pci.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Nice catch.
> >
> > Mathias, I can queue this up now if you give me an ack.
>
> Yes, please
>
> Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
>
prev parent reply other threads:[~2019-12-18 15:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 1:19 [PATCH] usb: xhci: Fix build warning seen with CONFIG_PM=n Guenter Roeck
2019-12-18 14:29 ` Greg Kroah-Hartman
2019-12-18 15:38 ` Mathias Nyman
2019-12-18 15:59 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218155946.GA331@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gregkh@linuxfoundation.org \
--cc=henryl@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.