From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Will Deacon <will@kernel.org>,
linux-media@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
Kostya Serebryany <kcc@google.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH RESEND RESEND] media: uvc: Avoid cyclic entity chains due to malformed USB descriptors
Date: Wed, 18 Dec 2019 18:51:53 +0200 [thread overview]
Message-ID: <20191218165153.GC17876@pendragon.ideasonboard.com> (raw)
In-Reply-To: <CAAeHK+xyv-x6ejwcqNAn=5eKoBYPkJsN=SgJLHJ1ey=6v+YyyA@mail.gmail.com>
On Wed, Dec 18, 2019 at 01:46:00PM +0100, Andrey Konovalov wrote:
> On Wed, Dec 18, 2019 at 1:23 PM Greg Kroah-Hartman wrote:
> > On Wed, Dec 18, 2019 at 11:41:38AM +0000, Will Deacon wrote:
> >> On Mon, Dec 16, 2019 at 02:17:52PM +0100, Andrey Konovalov wrote:
> >>> On Mon, Dec 16, 2019 at 1:16 PM Will Deacon <will@kernel.org> wrote:
> >>>> On Fri, Nov 08, 2019 at 05:55:03PM +0200, Laurent Pinchart wrote:
> >>>>> Thank you for the patch.
> >>>>>
> >>>>> I'm sorry for the delay, and will have to ask you to be a bit more
> >>>>> patient I'm afraid. I will leave tomorrow for a week without computer
> >>>>> access and will only be able to go through my backlog when I will be
> >>>>> back on the 17th.
> >>>>
> >>>> Gentle reminder on this, now you've been back a month ;)
> >>>
> >>> I think we now have a reproducer for this issue that syzbot just reported:
> >>>
> >>> https://syzkaller.appspot.com/bug?extid=0a5c96772a9b26f2a876
> >>>
> >>> You can try you patch on it :)
> >>
> >> Oh wow, I *really* like the raw USB gadget thingy you have to reproduce
> >> these! I also really like that this patch fixes the issue. Logs below.
>
> Thanks! An easier way to test the patch would be to issue a syz test
> command, but I'm glad you managed to set up raw gadget manually and it
> worked for you.
>
> >
> > Ok, that's a good poke for me to go review that raw gadget code to see
> > if it can be merged upstream :)
>
> Looking forward to it! =)
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and merged in my tree. I'm so sorry for the way too long delay.
> >> Laurent -- can we please merge this now?
> >
> > Yes, that would be good to have, as this obviously fixes a problem, and
> > I can take it off of my "patches to track" list....
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2019-12-18 16:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 15:48 [PATCH RESEND RESEND] media: uvc: Avoid cyclic entity chains due to malformed USB descriptors Will Deacon
2019-11-08 15:55 ` Laurent Pinchart
2019-11-08 15:59 ` Will Deacon
2019-12-16 12:16 ` Will Deacon
2019-12-16 13:17 ` Andrey Konovalov
2019-12-18 11:41 ` Will Deacon
2019-12-18 12:23 ` Greg Kroah-Hartman
2019-12-18 12:46 ` Andrey Konovalov
2019-12-18 16:51 ` Laurent Pinchart [this message]
2019-12-18 16:59 ` Will Deacon
2020-01-21 19:01 ` Will Deacon
2020-01-21 22:53 ` Laurent Pinchart
2020-01-22 8:58 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218165153.GC17876@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kcc@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stable@vger.kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.