All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-stable@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com
Subject: Re: [PATCH 1/3] block: Activate recursively even for already active nodes
Date: Wed, 18 Dec 2019 18:02:24 +0100	[thread overview]
Message-ID: <20191218170224.GG4632@linux.fritz.box> (raw)
In-Reply-To: <20191217145939.5537-2-kwolf@redhat.com>

Am 17.12.2019 um 15:59 hat Kevin Wolf geschrieben:
> bdrv_invalidate_cache_all() assumes that all nodes in a given subtree
> are either active or inactive when it starts. Therefore, as soon as it
> arrives at an already active node, it stops.
> 
> However, this assumption is wrong. For example, it's possible to take a
> snapshot of an inactive node, which results in an active overlay over an
> inactive backing file. The active overlay is probably also the root node
> of an inactive BlockBackend (blk->disable_perm == true).
> 
> In this case, bdrv_invalidate_cache_all() does not need to do anything
> to activate the overlay node, but it still needs to recurse into the
> children and the parents to make sure that after returning success,
> really everything is activated.
> 
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>

Actually:
Cc: qemu-stable@nongnu.org



  reply	other threads:[~2019-12-18 17:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17 14:59 [PATCH 0/3] block: Fix external snapshot with VM state Kevin Wolf
2019-12-17 14:59 ` [PATCH 1/3] block: Activate recursively even for already active nodes Kevin Wolf
2019-12-18 17:02   ` Kevin Wolf [this message]
2019-12-19 12:46   ` Max Reitz
2019-12-17 14:59 ` [PATCH 2/3] hmp: Allow using qdev ID for qemu-io command Kevin Wolf
2019-12-17 14:59 ` [PATCH 3/3] iotests: Test external snapshot with VM state Kevin Wolf
2019-12-19 14:26   ` Max Reitz
2019-12-19 15:47     ` Kevin Wolf
2020-01-02 13:25       ` Dr. David Alan Gilbert
2020-01-06 16:06         ` Kevin Wolf
2020-02-10 12:31           ` Dr. David Alan Gilbert
2020-02-10 13:37             ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191218170224.GG4632@linux.fritz.box \
    --to=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.