From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Dan Robertson <dan@dlrobertson.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-iio@vger.kernel.org,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Hartmut Knaack <knaack.h@gmx.de>,
Mark Rutland <mark.rutland@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Randy Dunlap <rdunlap@infradead.org>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH v6 1/2] dt-bindings: iio: accel: bma400: add bindings
Date: Wed, 18 Dec 2019 11:05:15 -0600 [thread overview]
Message-ID: <20191218170515.GA18325@bogus> (raw)
In-Reply-To: <CACRpkdb9O7RjpXdUPCtN1M+PLC+2hPomhsw2Q5Ehhg4pEVOStQ@mail.gmail.com>
On Thu, Dec 12, 2019 at 11:16:47AM +0100, Linus Walleij wrote:
> Hi Dan,
>
> thanks for your patch!
>
> On Wed, Dec 11, 2019 at 2:20 AM Dan Robertson <dan@dlrobertson.com> wrote:
>
> > Add devicetree binding for the Bosch BMA400 3-axes ultra-low power
> > accelerometer sensor.
> >
> > Signed-off-by: Dan Robertson <dan@dlrobertson.com>
> (...)
>
> > + Specifications about the sensor can be found at:
> > + https://ae-bst.resource.bosch.com/media/_tech/media/datasheets/BST-BMA400-DS000.pdf
>
> As can be seen in page 113 in the manual this component
> has VDD and VDDIO supplies and sooner or later someone
> is going to have to model that so I'd say add vdd-supply and
> vddio-supply regulator phandles as optional to the component
> already from start.
And interrupts too. Doesn't matter what the driver currently uses.
Rob
next prev parent reply other threads:[~2019-12-18 17:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 1:03 [PATCH v6 0/2] iio: add driver for Bosch BMA400 accelerometer Dan Robertson
2019-12-11 1:03 ` [PATCH v6 1/2] dt-bindings: iio: accel: bma400: add bindings Dan Robertson
2019-12-12 10:16 ` Linus Walleij
2019-12-18 17:05 ` Rob Herring [this message]
2019-12-18 21:16 ` Dan Robertson
2019-12-18 17:20 ` Rob Herring
2019-12-11 1:03 ` [PATCH v6 2/2] iio: (bma400) add driver for the BMA400 Dan Robertson
2019-12-11 13:21 ` Andy Shevchenko
2019-12-12 0:17 ` Dan Robertson
2019-12-12 9:41 ` Andy Shevchenko
2019-12-15 16:31 ` Jonathan Cameron
2019-12-12 10:27 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218170515.GA18325@bogus \
--to=robh@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=dan@dlrobertson.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=joe@perches.com \
--cc=knaack.h@gmx.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.