From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B9ACC43603 for ; Wed, 18 Dec 2019 18:25:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 210A520716 for ; Wed, 18 Dec 2019 18:25:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="qv8uysBl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727415AbfLRSZU (ORCPT ); Wed, 18 Dec 2019 13:25:20 -0500 Received: from mail26.static.mailgun.info ([104.130.122.26]:24453 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727071AbfLRSZU (ORCPT ); Wed, 18 Dec 2019 13:25:20 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1576693519; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=wbgekAz2uN18H2Y7xQKuUSB/FojZz1qn3faWVvqfdzk=; b=qv8uysBli7w352ET8r3YNS/EhlxaJ8ELQfShYVRkqBLTzwEtg5z5bFoCtR6QH5B9HRz1AiyI M2nr1+kcMFQXX5YnVYknT3mLv3SWQeR82a1XFZT03g/x6PoTmyHMPlTXiHafDZxf/UeywP33 cw9mZEkoieKFaOxG6l5RCKuyKAE= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5dfa6f0d.7fd31355f148-smtp-out-n01; Wed, 18 Dec 2019 18:25:17 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D85B8C447A3; Wed, 18 Dec 2019 18:25:17 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0AB15C433A2; Wed, 18 Dec 2019 18:25:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0AB15C433A2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] mt76: fix LED link time failure From: Kalle Valo In-Reply-To: <20191216131902.3251040-1-arnd@arndb.de> References: <20191216131902.3251040-1-arnd@arndb.de> To: Arnd Bergmann Cc: Felix Fietkau , Lorenzo Bianconi , "David S. Miller" , Matthias Brugger , Arnd Bergmann , Ryder Lee , Roy Luo , Stanislaw Gruszka , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20191218182517.D85B8C447A3@smtp.codeaurora.org> Date: Wed, 18 Dec 2019 18:25:17 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Arnd Bergmann wrote: > The mt76_led_cleanup() function is called unconditionally, which > leads to a link error when CONFIG_LEDS is a loadable module or > disabled but mt76 is built-in: > > drivers/net/wireless/mediatek/mt76/mac80211.o: In function `mt76_unregister_device': > mac80211.c:(.text+0x2ac): undefined reference to `led_classdev_unregister' > > Use the same trick that is guarding the registration, using an > IS_ENABLED() check for the CONFIG_MT76_LEDS symbol that indicates > whether LEDs can be used or not. > > Fixes: 36f7e2b2bb1d ("mt76: do not use devm API for led classdev") > Signed-off-by: Arnd Bergmann > Acked-by: Felix Fietkau Patch applied to wireless-drivers.git, thanks. d68f4e43a46f mt76: fix LED link time failure -- https://patchwork.kernel.org/patch/11294195/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches