From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:c345:0:0:0:0:0 with SMTP id t66csp1229518lff; Wed, 18 Dec 2019 11:31:03 -0800 (PST) X-Google-Smtp-Source: APXvYqzKqMAj7yBVtXJ/SgavDkMgxovkBWIN0+0vyd+hq2bFZLpfnXeMfX0ZxSKkn8DP1OGGxxDV X-Received: by 2002:a9d:754a:: with SMTP id b10mr4334014otl.273.1576697463544; Wed, 18 Dec 2019 11:31:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576697463; cv=none; d=google.com; s=arc-20160816; b=uvTe7X4Djew40gYuCjm5FiPoCi//EpOAsooQF0Tk/QbZNb5pX/ZhAu0iyyIY+Q3BlH 2yxa/wHqmmwcrDqVIKqa3qw1tdzXplMOIiOYl9BTxYzxT4hs1ZHgE/ND6ez0TwPZelZD 78SlRsCc/3aV48QXz1kmDipwmfrkiaJQ9Iu04Pv5a/dLcbK1N4cfDxq2AXkb03lrSJ41 SOCzNtN2F15pjedn9/3Y3Bh+grud/jJ//DPEiduS9ht+AzUrgFABCV448VE1AU8IMcQA +yElDWcABD+CCGqDvDxn0JPCm7NJkHypruNog+bjB2X7IOGRiu8aWhvwZbrg4SE3l8rR DShQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=TdxvmB9Qgxghb+PTOnONzrGSfc8UbEoa7GDLETeQHLY=; b=dslT3ybCLaa0EArOfWx/GmHd5liDksFMBKGLKE9LSiBfeuse/4/zOeXD6y7GuliYzg +1Ly/uze1XsO48HYqMimJj53pstiaQydsFzYaAtMhX+G/Q2uRjF2Q8fvtoxvFvYC0Hrh rfVOJoojL3kBgkD9g7DrlSmQMKUn+viKvTpw4N1DSrW72fAxyAADa0BzpIjQzjYgBx5b OLpuWFOcz466gPYvcOxJ7N25hGNrm5cP7LluxoupuKtWEx+s98NYKr1xIrdPDfhzUFce CejEn30iKMz26n96aNtNudjawWANNEtD8wsb3hiLeNrSCzaF8pcMRooS6H8F+SlTOzjT zxCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=FufARakB; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id c126si1882459oib.239.2019.12.18.11.31.03 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Dec 2019 11:31:03 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=FufARakB; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:59546 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihf2D-0004UQ-Uu for alex.bennee@linaro.org; Wed, 18 Dec 2019 14:31:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34322) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ihexZ-00088w-31 for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ihexW-0003ub-4v for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:12 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:22077 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ihexV-0003ry-SY for qemu-devel@nongnu.org; Wed, 18 Dec 2019 14:26:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576697169; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TdxvmB9Qgxghb+PTOnONzrGSfc8UbEoa7GDLETeQHLY=; b=FufARakBJ6wVGTURsUbZuLvPkirJJDQxQJge8R0RQmPigHYH/y+6vxG76xeKjsWjJR1FPh nOmwEny/dQhdpH+fXgSSKVBLal6K3Adheb/8I/OUqFFC0fOzGvz/pNVyImiK8wuoXq9QEr jfCnWIY8CeYd7+KjKXmhOo/ddJ3p/E8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-325-xXWuz7rlM1Cc8jiMhQbi7g-1; Wed, 18 Dec 2019 14:26:08 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9FB5D8024D3; Wed, 18 Dec 2019 19:26:06 +0000 (UTC) Received: from x1w.redhat.com (ovpn-116-235.ams2.redhat.com [10.36.116.235]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 98C6B60C81; Wed, 18 Dec 2019 19:26:01 +0000 (UTC) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 4/6] hw/net/imx_fec: Rewrite fall through comments Date: Wed, 18 Dec 2019 20:25:24 +0100 Message-Id: <20191218192526.13845-5-philmd@redhat.com> In-Reply-To: <20191218192526.13845-1-philmd@redhat.com> References: <20191218192526.13845-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: xXWuz7rlM1Cc8jiMhQbi7g-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Jason Wang , Richard Henderson , qemu-arm@nongnu.org, Peter Chubb , Aleksandar Markovic , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-devel" X-TUID: dvGuXuFQ5M8Z GCC9 is confused by this comment when building with CFLAG -Wimplicit-fallthrough=3D2: hw/net/imx_fec.c: In function =E2=80=98imx_eth_write=E2=80=99: hw/net/imx_fec.c:906:12: error: this statement may fall through [-Werror= =3Dimplicit-fallthrough=3D] 906 | if (unlikely(single_tx_ring)) { | ^ hw/net/imx_fec.c:912:5: note: here 912 | case ENET_TDAR: /* FALLTHROUGH */ | ^~~~ cc1: all warnings being treated as errors Rewrite the comments in the correct place, using 'fall through' which is recognized by GCC and static analyzers. Reviewed-by: Richard Henderson Reviewed-by: Aleksandar Markovic Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Peter Chubb Cc: Peter Maydell Cc: Jason Wang Cc: qemu-arm@nongnu.org --- hw/net/imx_fec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index bd99236864..c01ce4f078 100644 --- a/hw/net/imx_fec.c +++ b/hw/net/imx_fec.c @@ -909,7 +909,8 @@ static void imx_eth_write(void *opaque, hwaddr offset, = uint64_t value, TYPE_IMX_FEC, __func__); return; } - case ENET_TDAR: /* FALLTHROUGH */ + /* fall through */ + case ENET_TDAR: if (s->regs[ENET_ECR] & ENET_ECR_ETHEREN) { s->regs[index] =3D ENET_TDAR_TDAR; imx_eth_do_tx(s, index); --=20 2.21.0