From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
Ian Jackson <Ian.Jackson@citrix.com>
Subject: Re: [Xen-devel] [PATCH] tools/python: Python 3 compatibility
Date: Wed, 18 Dec 2019 23:46:26 +0100 [thread overview]
Message-ID: <20191218224626.GI25235@mail-itl> (raw)
In-Reply-To: <025d5b59-3355-03f4-e885-8dd99776c3c0@citrix.com>
[-- Attachment #1.1: Type: text/plain, Size: 1240 bytes --]
On Wed, Dec 18, 2019 at 10:32:47PM +0000, Andrew Cooper wrote:
> On 18/12/2019 22:26, Marek Marczykowski-Górecki wrote:
> >> @@ -70,7 +73,7 @@ class VM(object):
> >>
> >> # libxl
> >> self.libxl = fmt == "libxl"
> >> - self.emu_xenstore = "" # NUL terminated key&val pairs from "toolstack" records
> >> + self.emu_xenstore = b"" # NUL terminated key&val pairs from "toolstack" records
> >>
> >> def write_libxc_ihdr():
> >> stream_write(pack(libxc.IHDR_FORMAT,
> > You also need to update write_record (string constants).
> > And few calls to it with string constants (write_libxl_end,
> > write_libxl_libxc_context, read_pv_tail, read_hvm_tail).
> > And blkid == ... in read_pv_extended_info().
>
> Urgh - well spotted.
>
> Was this manual inspection, or something else?
Manual search for " and '.
> (I probably should
> complete and upstream write-legacy-stream for the purpose of dev-testing
> the convert-legacy-stream script now that 4.6 is waaay in the past.)
>
> ~Andrew
--
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-12-18 22:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 15:05 [Xen-devel] [PATCH] tools/python: Python 3 compatibility Andrew Cooper
2019-12-18 22:26 ` Marek Marczykowski-Górecki
2019-12-18 22:32 ` Andrew Cooper
2019-12-18 22:46 ` Marek Marczykowski-Górecki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218224626.GI25235@mail-itl \
--to=marmarek@invisiblethingslab.com \
--cc=Ian.Jackson@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.