From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A0AC43603 for ; Wed, 18 Dec 2019 23:51:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41AC121582 for ; Wed, 18 Dec 2019 23:51:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41AC121582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BBBCC6EAA7; Wed, 18 Dec 2019 23:51:53 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4B1196E043; Wed, 18 Dec 2019 23:51:52 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 15:51:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,330,1571727600"; d="scan'208";a="212851109" Received: from labuser-z97x-ud5h.jf.intel.com (HELO intel.com) ([10.54.75.49]) by fmsmga007.fm.intel.com with ESMTP; 18 Dec 2019 15:51:51 -0800 Date: Wed, 18 Dec 2019 15:53:24 -0800 From: Manasi Navare To: "Manna, Animesh" Subject: Re: [PATCH v2 2/9] drm/amd/display: Fix compilation issue. Message-ID: <20191218235324.GI12192@intel.com> References: <20191218151350.19579-1-animesh.manna@intel.com> <20191218151350.19579-3-animesh.manna@intel.com> <03119efd-5130-3851-5dec-bd4ef5b8cfd5@amd.com> <0a2bc02e-e3fa-b177-0c3b-fe7c323337a0@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0a2bc02e-e3fa-b177-0c3b-fe7c323337a0@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: jani.nikula@intel.com, nidhi1.gupta@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, uma.shankar@intel.com, anshuman.gupta@intel.com, Alex Deucher , Harry Wentland Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Dec 18, 2019 at 09:43:49PM +0530, Manna, Animesh wrote: > > On 18-12-2019 21:12, Harry Wentland wrote: > >On 2019-12-18 10:13 a.m., Animesh Manna wrote: > >>[Why]: > >>Aligh with DP spec wanted to follow same naming convention. > >> > >>[How]: > >>Changed the macro name of the dpcd address used for getting requested > >>test-pattern. > >> > >Please roll this into your patch that renames the definition. All > >patches should compile on their own. > > > Thanks Harry for review, wanted to follow similar commit-description format > followed in amd-driver compare to i915 and created a separate patch. Maybe > is it good idea to change the patch sequence and make it as first patch. > > Regards, > Animesh Like Harry said, all these changes should happen in the same patch that renames the DP_TEST_PHY_PATTERN which is patch 1/9 because like you see the build still fails now since patch 1 doesnt compile. So the idea would be in patch 1 - rename, make changes in AMD and existing place where it gets used Patch 2 - get/set PHY test paarams that use this renamed value Manasi > > > > >Thanks, > >Harry > > > >>Cc: Harry Wentland > >>Cc: Alex Deucher > >>Signed-off-by: Animesh Manna > >>--- > >> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >>diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c > >>index 42aa889fd0f5..1a6109be2fce 100644 > >>--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c > >>+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c > >>@@ -2491,7 +2491,7 @@ static void dp_test_send_phy_test_pattern(struct dc_link *link) > >> /* get phy test pattern and pattern parameters from DP receiver */ > >> core_link_read_dpcd( > >> link, > >>- DP_TEST_PHY_PATTERN, > >>+ DP_PHY_TEST_PATTERN, > >> &dpcd_test_pattern.raw, > >> sizeof(dpcd_test_pattern)); > >> core_link_read_dpcd( > >> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31787C43603 for ; Wed, 18 Dec 2019 23:51:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B64421582 for ; Wed, 18 Dec 2019 23:51:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B64421582 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A282B6E043; Wed, 18 Dec 2019 23:51:53 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4B1196E043; Wed, 18 Dec 2019 23:51:52 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2019 15:51:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,330,1571727600"; d="scan'208";a="212851109" Received: from labuser-z97x-ud5h.jf.intel.com (HELO intel.com) ([10.54.75.49]) by fmsmga007.fm.intel.com with ESMTP; 18 Dec 2019 15:51:51 -0800 Date: Wed, 18 Dec 2019 15:53:24 -0800 From: Manasi Navare To: "Manna, Animesh" Message-ID: <20191218235324.GI12192@intel.com> References: <20191218151350.19579-1-animesh.manna@intel.com> <20191218151350.19579-3-animesh.manna@intel.com> <03119efd-5130-3851-5dec-bd4ef5b8cfd5@amd.com> <0a2bc02e-e3fa-b177-0c3b-fe7c323337a0@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0a2bc02e-e3fa-b177-0c3b-fe7c323337a0@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Subject: Re: [Intel-gfx] [PATCH v2 2/9] drm/amd/display: Fix compilation issue. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Harry Wentland , jani.nikula@intel.com, nidhi1.gupta@intel.com, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Alex Deucher , Harry Wentland Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, Dec 18, 2019 at 09:43:49PM +0530, Manna, Animesh wrote: > > On 18-12-2019 21:12, Harry Wentland wrote: > >On 2019-12-18 10:13 a.m., Animesh Manna wrote: > >>[Why]: > >>Aligh with DP spec wanted to follow same naming convention. > >> > >>[How]: > >>Changed the macro name of the dpcd address used for getting requested > >>test-pattern. > >> > >Please roll this into your patch that renames the definition. All > >patches should compile on their own. > > > Thanks Harry for review, wanted to follow similar commit-description format > followed in amd-driver compare to i915 and created a separate patch. Maybe > is it good idea to change the patch sequence and make it as first patch. > > Regards, > Animesh Like Harry said, all these changes should happen in the same patch that renames the DP_TEST_PHY_PATTERN which is patch 1/9 because like you see the build still fails now since patch 1 doesnt compile. So the idea would be in patch 1 - rename, make changes in AMD and existing place where it gets used Patch 2 - get/set PHY test paarams that use this renamed value Manasi > > > > >Thanks, > >Harry > > > >>Cc: Harry Wentland > >>Cc: Alex Deucher > >>Signed-off-by: Animesh Manna > >>--- > >> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >>diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c > >>index 42aa889fd0f5..1a6109be2fce 100644 > >>--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c > >>+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c > >>@@ -2491,7 +2491,7 @@ static void dp_test_send_phy_test_pattern(struct dc_link *link) > >> /* get phy test pattern and pattern parameters from DP receiver */ > >> core_link_read_dpcd( > >> link, > >>- DP_TEST_PHY_PATTERN, > >>+ DP_PHY_TEST_PATTERN, > >> &dpcd_test_pattern.raw, > >> sizeof(dpcd_test_pattern)); > >> core_link_read_dpcd( > >> _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx