From: Stephen Boyd <sboyd@kernel.org>
To: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>, mturquette@baylibre.com
Cc: agross@kernel.org, bjorn.andersson@linaro.org,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org,
Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Subject: Re: [PATCH] clk: qcom: Make gcc_gpu_cfg_ahb_clk critical
Date: Wed, 18 Dec 2019 22:00:19 -0800 [thread overview]
Message-ID: <20191219060020.573342146E@mail.kernel.org> (raw)
In-Reply-To: <20191217171205.5492-1-jeffrey.l.hugo@gmail.com>
Quoting Jeffrey Hugo (2019-12-17 09:12:05)
> diff --git a/drivers/clk/qcom/gcc-msm8998.c b/drivers/clk/qcom/gcc-msm8998.c
> index df1d7056436c..26cc1458ce4a 100644
> --- a/drivers/clk/qcom/gcc-msm8998.c
> +++ b/drivers/clk/qcom/gcc-msm8998.c
> @@ -2044,6 +2044,7 @@ static struct clk_branch gcc_gpu_cfg_ahb_clk = {
> .hw.init = &(struct clk_init_data){
> .name = "gcc_gpu_cfg_ahb_clk",
> .ops = &clk_branch2_ops,
> + .flags = CLK_IS_CRITICAL, /* to access gpucc */
Can we not do the thing that Bjorn did to turn on ahb clks with runtime
PM for clk controllers that need them? See 892df0191b29 ("clk: qcom: Add
QCS404 TuringCC").
next prev parent reply other threads:[~2019-12-19 6:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 17:12 [PATCH] clk: qcom: Make gcc_gpu_cfg_ahb_clk critical Jeffrey Hugo
2019-12-19 6:00 ` Stephen Boyd [this message]
2019-12-19 14:20 ` Jeffrey Hugo
2019-12-24 2:23 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219060020.573342146E@mail.kernel.org \
--to=sboyd@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=jeffrey.l.hugo@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.