Re: [PATCH 2/4] qapi: Create module 'monitor'

[Kevin Wolf <kwolf@redhat.com>]

Am 18.12.2019 um 20:20 hat Markus Armbruster geschrieben:
> Kevin Wolf <kwolf@redhat.com> writes:
> 
> > misc.json contains definitions that are related to the system emulator,
> > so it can't be used for the storage daemon. This patch moves basic
> > functionality that is related to the monitor itself into a new
> > monitor.json, which could be used in tools as well.
> >
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>

> > +##
> > +# @query-version:
> > +#
> > +# Returns the current version of QEMU.
> > +#
> > +# Returns:  A @VersionInfo object describing the current version of QEMU.
> > +#
> > +# Since: 0.14.0
> > +#
> > +# Example:
> > +#
> > +# -> { "execute": "query-version" }
> > +# <- {
> > +#       "return":{
> > +#          "qemu":{
> > +#             "major":0,
> > +#             "minor":11,
> > +#             "micro":5
> > +#          },
> > +#          "package":""
> > +#       }
> > +#    }
> > +#
> > +##
> > +{ 'command': 'query-version', 'returns': 'VersionInfo',
> > +  'allow-preconfig': true }
> 
> Borderline.  I guess you move query-version (along with VersionInfo,
> VersionTriple) because qmp_greeting() uses it.

Also because if querying the version makes sense for QEMU, it probably
also makes sense for any other tool.

> > +##
> > +# @quit:
> > +#
> > +# This command will cause the QEMU process to exit gracefully.  While every
> > +# attempt is made to send the QMP response before terminating, this is not
> > +# guaranteed.  When using this interface, a premature EOF would not be
> > +# unexpected.
> > +#
> > +# Since: 0.14.0
> > +#
> > +# Example:
> > +#
> > +# -> { "execute": "quit" }
> > +# <- { "return": {} }
> > +##
> > +{ 'command': 'quit' }
> 
> Borderline.
> 
> Perhaps it's just a matter of naming.  monitor.json suggests it's about
> the monitor.  It's in fact about QMP, plus whatever else any program
> sporting a QMP monitor has.  Can we find a name for that?  Hmm...
> control.json?

As this is what should make sense for every tool implementing QMP, how
about something like base.json or core.json?

Kevin