From: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
To: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH] regulator: bd71828: remove get_voltage operation
Date: Thu, 19 Dec 2019 13:34:44 +0200 [thread overview]
Message-ID: <20191219113444.GA28299@localhost.localdomain> (raw)
Simplify LDO6 voltage getting on BD71828 by removing the
get_voltage call-back and providing the fixed voltage in
regulator_desc instead
Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Suggested-by: Mark Brown <broonie@kernel.org>
---
drivers/regulator/bd71828-regulator.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/regulator/bd71828-regulator.c b/drivers/regulator/bd71828-regulator.c
index edba51da5661..b2fa17be4988 100644
--- a/drivers/regulator/bd71828-regulator.c
+++ b/drivers/regulator/bd71828-regulator.c
@@ -197,15 +197,9 @@ static const struct regulator_ops bd71828_ldo_ops = {
.get_voltage_sel = regulator_get_voltage_sel_regmap,
};
-static int bd71828_ldo6_get_voltage(struct regulator_dev *rdev)
-{
- return BD71828_LDO_6_VOLTAGE;
-}
-
static const struct regulator_ops bd71828_ldo6_ops = {
.enable = regulator_enable_regmap,
.disable = regulator_disable_regmap,
- .get_voltage = bd71828_ldo6_get_voltage,
.is_enabled = regulator_is_enabled_regmap,
};
@@ -697,6 +691,7 @@ static const struct bd71828_regulator_data bd71828_rdata[] = {
.id = BD71828_LDO6,
.ops = &bd71828_ldo6_ops,
.type = REGULATOR_VOLTAGE,
+ .fixed_uV = BD71828_LDO_6_VOLTAGE,
.n_voltages = 1,
.enable_reg = BD71828_REG_LDO6_EN,
.enable_mask = BD71828_MASK_RUN_EN,
base-commit: 522498f8cb8c547f415a9a39fb54fd1f7e1a1eda
--
2.21.0
--
Matti Vaittinen, Linux device drivers
ROHM Semiconductors, Finland SWDC
Kiviharjunlenkki 1E
90220 OULU
FINLAND
~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~
Simon says - in Latin please.
~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~
Thanks to Simon Glass for the translation =]
next reply other threads:[~2019-12-19 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 11:34 Matti Vaittinen [this message]
2019-12-20 13:09 ` Applied "regulator: bd71828: remove get_voltage operation" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219113444.GA28299@localhost.localdomain \
--to=matti.vaittinen@fi.rohmeurope.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.