From: Andrew Lunn <andrew@lunn.ch>
To: madalin.bucur@nxp.com
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux@armlinux.org.uk, f.fainelli@gmail.com,
hkallweit1@gmail.com, shawnguo@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/6] arm64: dts: ls104xardb: set correct PHY interface mode
Date: Thu, 19 Dec 2019 17:05:37 +0100 [thread overview]
Message-ID: <20191219160537.GI17475@lunn.ch> (raw)
In-Reply-To: <1576768881-24971-3-git-send-email-madalin.bucur@oss.nxp.com>
On Thu, Dec 19, 2019 at 05:21:17PM +0200, Madalin Bucur wrote:
> From: Madalin Bucur <madalin.bucur@nxp.com>
>
> The DPAA 1 based LS1043ARDB and LS1046ARDB boards are using
> XFI for the 10G interfaces. Since at the moment of the addition
> of the first DPAA platforms the only 10G PHY interface type used
> was XGMII, although the boards were actually using XFI, they were
> wrongly declared as xgmii. This has propagated along the DPAA
> family of SoCs, all 10G interfaces being declared wrongly as
> XGMII. This patch addresses the problem for the ARM based DPAA
> SoCs. After the introduction of XFI PHY interface type we can
> address this issue.
Hi Madalin
This patch should come at the end, after you have added support for
these new modes. Otherwise anybody doing a git bisect could land on
code which has broken ethernet.
Andrew
next prev parent reply other threads:[~2019-12-19 16:05 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-19 15:21 [PATCH 0/6] Add PHY connection types for XFI and SFI Madalin Bucur
2019-12-19 15:21 ` [PATCH 1/6] net: phy: add interface modes for XFI, SFI Madalin Bucur
2019-12-19 17:28 ` Russell King - ARM Linux admin
2019-12-19 18:32 ` Madalin Bucur
2019-12-19 19:03 ` Russell King - ARM Linux admin
2019-12-19 21:34 ` Madalin Bucur (OSS)
2019-12-19 21:49 ` Russell King - ARM Linux admin
2019-12-20 7:38 ` Madalin Bucur (OSS)
2019-12-20 9:16 ` Russell King - ARM Linux admin
2019-12-20 9:29 ` Andrew Lunn
2019-12-20 9:39 ` Madalin Bucur (OSS)
2019-12-20 10:06 ` Andrew Lunn
2019-12-23 7:50 ` Madalin Bucur (OSS)
2019-12-23 8:26 ` Russell King - ARM Linux admin
2019-12-23 9:57 ` Madalin Bucur (OSS)
2019-12-23 10:57 ` Russell King - ARM Linux admin
2019-12-23 12:07 ` Russell King - ARM Linux admin
2019-12-23 13:46 ` Andrew Lunn
2019-12-23 14:30 ` Russell King - ARM Linux admin
2020-01-03 7:01 ` Madalin Bucur (OSS)
2020-01-03 9:27 ` Russell King - ARM Linux admin
2020-01-03 9:42 ` Russell King - ARM Linux admin
2020-01-03 12:03 ` Madalin Bucur (OSS)
2020-01-03 12:53 ` Russell King - ARM Linux admin
2020-01-03 13:35 ` Andrew Lunn
2020-01-03 16:21 ` Madalin Bucur (OSS)
2020-01-03 17:17 ` Andrew Lunn
2020-01-06 9:34 ` Madalin Bucur (OSS)
2020-01-03 15:57 ` Madalin Bucur (OSS)
2020-01-03 17:19 ` Russell King - ARM Linux admin
2020-01-06 10:17 ` Madalin Bucur (OSS)
2020-01-06 13:57 ` Andrew Lunn
2020-01-06 15:03 ` Madalin Bucur (OSS)
2019-12-19 15:21 ` [PATCH 2/6] arm64: dts: ls104xardb: set correct PHY interface mode Madalin Bucur
2019-12-19 16:05 ` Andrew Lunn [this message]
2019-12-19 18:09 ` Madalin Bucur (OSS)
2019-12-19 15:21 ` [PATCH 3/6] net: fsl/fman: rename IF_MODE_XGMII to IF_MODE_10G Madalin Bucur
2019-12-19 15:21 ` [PATCH 4/6] net: fsl/fman: add support for PHY_INTERFACE_MODE_XFI Madalin Bucur
2019-12-19 15:21 ` [PATCH 5/6] net: fsl/fman: add support for PHY_INTERFACE_MODE_SFI Madalin Bucur
2019-12-19 17:30 ` Russell King - ARM Linux admin
2019-12-19 18:50 ` Madalin Bucur (OSS)
2019-12-19 15:21 ` [PATCH 6/6] net: phy: aquantia: add support for PHY_INTERFACE_MODE_XFI Madalin Bucur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219160537.GI17475@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux@armlinux.org.uk \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.