From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E15F6C43603 for ; Thu, 19 Dec 2019 16:53:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1FE42146E for ; Thu, 19 Dec 2019 16:53:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1FE42146E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 285A06E075; Thu, 19 Dec 2019 16:53:09 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id B163D6E075 for ; Thu, 19 Dec 2019 16:53:07 +0000 (UTC) Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 1CA0D20026; Thu, 19 Dec 2019 17:53:02 +0100 (CET) Date: Thu, 19 Dec 2019 17:53:01 +0100 From: Sam Ravnborg To: Daniel Vetter Subject: Re: [PATCH] drm/todo: Updating logging todo Message-ID: <20191219165301.GA17514@ravnborg.org> References: <20191219161722.2779994-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191219161722.2779994-1-daniel.vetter@ffwll.ch> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=QyXUC8HyAAAA:8 a=pGLkceISAAAA:8 a=7gkXJVJtAAAA:8 a=PueDHSs-hDy7qKLiRj4A:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula , Daniel Vetter , Sean Paul , DRI Development , Wambui Karuga Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Daniel. On Thu, Dec 19, 2019 at 05:17:22PM +0100, Daniel Vetter wrote: > Jani has merged a new set of logging functions, which we hope to be > the One True solution now, pinky promises: > > commit fb6c7ab8718eb2543695d77ad8302ff81e8e1e32 > Author: Jani Nikula > Date: Tue Dec 10 14:30:43 2019 +0200 > > drm/print: introduce new struct drm_device based logging macros > > Update the todo entry to match the new preference. > > Cc: Jani Nikula > Cc: Sean Paul > Cc: Wambui Karuga > Signed-off-by: Daniel Vetter > --- > Documentation/gpu/todo.rst | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > index 2d85f37284a1..017f3090f8a1 100644 > --- a/Documentation/gpu/todo.rst > +++ b/Documentation/gpu/todo.rst > @@ -142,13 +142,13 @@ Contact: Daniel Vetter, respective driver maintainers > > Level: Advanced > > -Convert instances of dev_info/dev_err/dev_warn to their DRM_DEV_* equivalent > ----------------------------------------------------------------------------- > +Convert logging to drm_* functions with drm_device paramater > +------------------------------------------------------------ > > For drivers which could have multiple instances, it is necessary to > differentiate between which is which in the logs. Since DRM_INFO/WARN/ERROR > don't do this, drivers used dev_info/warn/err to make this differentiation. We > -now have DRM_DEV_* variants of the drm print macros, so we can start to convert > +now have drm_* variants of the drm print functions, so we can start to convert > those drivers back to using drm-formwatted specific log messages. s/drm-formwatted/drm-formatted/? Acked-by: Sam Ravnborg drm_print.h could use a rework so it is obvious what is legacy and what is the right way to do things. I will add that to my personal todo list for now. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel