From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C79FC2D0D1 for ; Thu, 19 Dec 2019 17:16:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61E7724689 for ; Thu, 19 Dec 2019 17:16:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="rBzzEYfy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727092AbfLSRQH (ORCPT ); Thu, 19 Dec 2019 12:16:07 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:39734 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727106AbfLSRPs (ORCPT ); Thu, 19 Dec 2019 12:15:48 -0500 Received: by mail-wm1-f66.google.com with SMTP id 20so6331389wmj.4 for ; Thu, 19 Dec 2019 09:15:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=uycbaS0g1vE0Cuob7CqLcnjNvgH80U0c2b2m+7/3Ktw=; b=rBzzEYfyA1MtQaHuNuBZq+0ETt+FtIFBvw4RFKKOcpSVbBFxol0tf56M85YAhphsr5 a/HmMFRQKK/20smBrmLQA4rAUYEhkJKpwC1Sft2mP16nyeCkBG76iQr9pcTYfyTib+bY LOhO5AWg6DkMc1VUTfA5F7UbE8rVtwLCnyPT7zK9+jP+9iv77TX1eRVoYYLi+Z4X0V/a 4TJ6xwHag5hCVsmXg0LdXyKCyzsU1aOVDB+eECTV35zGRLzWJjXJ95Xgtbh4Y8HONcEY 0wyoBWzcCOXk+7lYfiUqoX2Agfn+cFBFqqi4C+CmqCjJjGvZgDxaOHpKJOQlbUOruwOP MQ+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=uycbaS0g1vE0Cuob7CqLcnjNvgH80U0c2b2m+7/3Ktw=; b=LWyxUF+fj5xBDIjuVB8hztrj4P77Nn4QB/NSmYUsPVdKo9wuyrjNp3moiuVETsOqV2 9W2bDNBkLWNT78DQbW/keZbLCJVW8+PbapjFlEKKQHK65J/AHb8pesHYKqh2y8cQBWVn ZgHW2+IkPAdAxUvXeMqpHhlPSUFB0pOD5DYwQczRKncG1tRwEccjuVnibabZjKlhggIE 0qmDk5MOhnvo/XukwkJA6FZB4ktxZ2tZrp34bD7kfgrWCAJ6R+uxW72eoM99jrBAyLa4 jWgILlinb7rU222tqCN+13j5ibWrNR5hz6SlaSfBIzh9QF5mEv0muodZ6SwNu7nBCPpE uKiQ== X-Gm-Message-State: APjAAAVN9uoBpzJRxsAZ5UnoEn9YmTzDS4NAzKrV1cyPE2wgQLa9EnAn Ji/rN+ntwC4fzHA/FE62NP2yqg== X-Google-Smtp-Source: APXvYqwsGU6Wo1uPHcriBaY8UhilFJcnLEteqy07AwUJ7zq340qlG3Ixhg1A+rJmWNmKh/4+fligKQ== X-Received: by 2002:a05:600c:108a:: with SMTP id e10mr10817499wmd.38.1576775746351; Thu, 19 Dec 2019 09:15:46 -0800 (PST) Received: from debian-brgl.home ([2a01:cb1d:af:5b00:6d6c:8493:1ab5:dad7]) by smtp.gmail.com with ESMTPSA id q6sm7401428wrx.72.2019.12.19.09.15.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 09:15:45 -0800 (PST) From: Bartosz Golaszewski To: Kent Gibson , Linus Walleij , Andy Shevchenko , Greg Kroah-Hartman Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v3 10/13] gpiolib: emit a debug message when adding events to a full kfifo Date: Thu, 19 Dec 2019 18:15:25 +0100 Message-Id: <20191219171528.6348-11-brgl@bgdev.pl> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191219171528.6348-1-brgl@bgdev.pl> References: <20191219171528.6348-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Bartosz Golaszewski Currently if the line-event kfifo is full, we just silently drop any new events. Add a ratelimited debug message so that we at least have some trace in the kernel log of event overflow. Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpiolib.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 073bc75b3d45..e27cf2113fed 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -979,6 +979,9 @@ static irqreturn_t lineevent_irq_thread(int irq, void *p) 1, &le->wait.lock); if (ret) wake_up_poll(&le->wait, EPOLLIN); + else + pr_debug_ratelimited( + "%s: event FIFO is full - event dropped\n", __func__); return IRQ_HANDLED; } -- 2.23.0