From: Andrew Lunn <andrew@lunn.ch>
To: David Miller <davem@davemloft.net>
Cc: rmk+kernel@armlinux.org.uk, f.fainelli@gmail.com,
hkallweit1@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH net] net: phy: make phy_error() report which PHY has failed
Date: Thu, 19 Dec 2019 22:05:03 +0100 [thread overview]
Message-ID: <20191219210503.GR17475@lunn.ch> (raw)
In-Reply-To: <20191219.125010.1105219757379875134.davem@davemloft.net>
> I think I agree with Heiner that it is valuable to know whether the
> error occurred from the interrupt handler or the state machine (and
> if the state machine, where that got called from).
>
> So I totally disagree with removing the backtrace, sorry.
Russell does have a point about the backtrace not giving an indication
of which phy experienced the error. So adding the phydev_err() call,
which will prefix the print with an identifier for the PHY, is a good
idea. So we should add that, and keep the WARN().
Andrew
next prev parent reply other threads:[~2019-12-19 21:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-17 12:53 [PATCH net] net: phy: make phy_error() report which PHY has failed Russell King
2019-12-17 21:41 ` Heiner Kallweit
2019-12-17 23:34 ` Russell King - ARM Linux admin
2019-12-18 20:54 ` Heiner Kallweit
2019-12-18 22:09 ` Russell King - ARM Linux admin
2019-12-19 7:10 ` Heiner Kallweit
2019-12-19 17:06 ` Russell King - ARM Linux admin
2019-12-20 18:46 ` Florian Fainelli
2019-12-20 22:28 ` Heiner Kallweit
2019-12-19 20:50 ` David Miller
2019-12-19 21:05 ` Andrew Lunn [this message]
2019-12-19 22:14 ` David Miller
2019-12-19 21:45 ` Russell King - ARM Linux admin
2019-12-20 9:18 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191219210503.GR17475@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.