All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kamel Bouhara <kamel.bouhara@bootlin.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: alexandre.belloni@bootlin.com, Ludovic.Desroches@microchip.com,
	thomas.petazzoni@bootlin.com, Claudiu.Beznea@microchip.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] power: reset: at91-reset: add sysfs interface to the power on reason
Date: Fri, 20 Dec 2019 11:07:53 +0100	[thread overview]
Message-ID: <20191220100753.GA2601@kb-xps> (raw)
In-Reply-To: <20191219171314.lgltzc5bvrvpwphs@earth.universe>

On Thu, Dec 19, 2019 at 06:13:14PM +0100, Sebastian Reichel wrote:
> Hi,
>

Hi,

[...]

> >
> > > Moreover, you are doing 2 things on a patch:
> > > 1/ export the reset reasons through sysfs
> > > 2/ introduce the reset reason defines
> >
> > Ok, I shall split it in two patches, if it could clarify things ?
>
> Yes, please split into two patches.
>

OK.

[...]

>
> Is this user reset button from the sysfs file? I think just "User"
> is a bit too short. Also please make sure, that the list actually
> matches the API described in the documentation :)
>

OK, fixed in v4, please check.

Cheers.

Kamel

--
Kamel Bouhara, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      reply	other threads:[~2019-12-20 10:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09  9:43 [PATCH v3] power: reset: at91-reset: add sysfs interface to the power on reason Kamel Bouhara
2019-12-09 11:33 ` Claudiu.Beznea
2019-12-09 13:44   ` Kamel Bouhara
2019-12-19 17:13     ` Sebastian Reichel
2019-12-20 10:07       ` Kamel Bouhara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191220100753.GA2601@kb-xps \
    --to=kamel.bouhara@bootlin.com \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=sebastian.reichel@collabora.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.